public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] .pytool: Add two keys in cspell.base.yaml
@ 2020-03-19  9:37 Zhang, Shenglei
  2020-03-19 15:10 ` [EXTERNAL] " Bret Barkelew
  0 siblings, 1 reply; 2+ messages in thread
From: Zhang, Shenglei @ 2020-03-19  9:37 UTC (permalink / raw)
  To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao

In order to catch as many issues as possible in a single
pass (to allow devs to fix test failures in one commit rather than
 several), recommend increasing the max failure count and max
duplicate count in SpellCheck plugin.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2593

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 .pytool/Plugin/SpellCheck/cspell.base.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.pytool/Plugin/SpellCheck/cspell.base.yaml b/.pytool/Plugin/SpellCheck/cspell.base.yaml
index 53000fc38141..7620dff3ceb2 100644
--- a/.pytool/Plugin/SpellCheck/cspell.base.yaml
+++ b/.pytool/Plugin/SpellCheck/cspell.base.yaml
@@ -21,6 +21,8 @@
         "*.jpg"
     ],
     "minWordLength": 5,
+    "maxNumberOfProblems": 200,
+    "maxDuplicateProblems": 200,
     "allowCompoundWords": false,
     "ignoreWords": [
         "muchange"
-- 
2.18.0.windows.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [EXTERNAL] [PATCH] .pytool: Add two keys in cspell.base.yaml
  2020-03-19  9:37 [PATCH] .pytool: Add two keys in cspell.base.yaml Zhang, Shenglei
@ 2020-03-19 15:10 ` Bret Barkelew
  0 siblings, 0 replies; 2+ messages in thread
From: Bret Barkelew @ 2020-03-19 15:10 UTC (permalink / raw)
  To: Shenglei Zhang, devel@edk2.groups.io
  Cc: Sean Brogan, Kinney, Michael D, Liming Gao

[-- Attachment #1: Type: text/plain, Size: 1883 bytes --]

Reviewed-by: Bret Barkelew <Bret.barkelew@microsoft.com>

- Bret
________________________________
From: Shenglei Zhang <shenglei.zhang@intel.com>
Sent: Thursday, March 19, 2020 2:37:54 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao <liming.gao@intel.com>
Subject: [EXTERNAL] [PATCH] .pytool: Add two keys in cspell.base.yaml

In order to catch as many issues as possible in a single
pass (to allow devs to fix test failures in one commit rather than
 several), recommend increasing the max failure count and max
duplicate count in SpellCheck plugin.
REF: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2593&amp;data=02%7C01%7CBret.Barkelew%40microsoft.com%7Cfc576b01311c475fe39008d7cbe93a55%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637202074886021018&amp;sdata=jWldOGRLBGli6KGd0D86FvWXRxHJek6nIyXTXytxgF4%3D&amp;reserved=0

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 .pytool/Plugin/SpellCheck/cspell.base.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.pytool/Plugin/SpellCheck/cspell.base.yaml b/.pytool/Plugin/SpellCheck/cspell.base.yaml
index 53000fc38141..7620dff3ceb2 100644
--- a/.pytool/Plugin/SpellCheck/cspell.base.yaml
+++ b/.pytool/Plugin/SpellCheck/cspell.base.yaml
@@ -21,6 +21,8 @@
         "*.jpg"
     ],
     "minWordLength": 5,
+    "maxNumberOfProblems": 200,
+    "maxDuplicateProblems": 200,
     "allowCompoundWords": false,
     "ignoreWords": [
         "muchange"
--
2.18.0.windows.1


[-- Attachment #2: Type: text/html, Size: 3371 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-19 15:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-19  9:37 [PATCH] .pytool: Add two keys in cspell.base.yaml Zhang, Shenglei
2020-03-19 15:10 ` [EXTERNAL] " Bret Barkelew

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox