From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.107]) by mx.groups.io with SMTP id smtpd.web11.7097.1590649066894171276 for ; Wed, 27 May 2020 23:57:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=S0eGkAwZ; spf=pass (domain: microsoft.com, ip: 40.107.92.107, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fM22YzcZJbFYoILVz1gO6UtEwu+ojzulaUgZhUKV4fBWQ+gBTOfLIADTpo4+FLynydbupjXCWv0PWQs1P5lqPXUTMmAC1vjpPwrnlrPrTlk9t8qVgeUaanvhrDXVpxvoZxEqUkaWZ85pUZgPyesP2Sbm/g8cjA3QfdEUOMCT1BgY2xunHCmp4XowyenvwKa9W6qK9ahSVTuSvFqB19MUCOfMfmYG0YI6HYrYeRMLWwH1k0xVao9VSlkSOnHzbJQVWl9mouFJnFwC6ufCwA0jeLN1BSDwIjTUMnLWwWlp2xbArIOLEPaip5ozgF7B36MeA6ERDA2NpG/Y+HsP3IEqJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D6vBXjFbfNUjMerHmlSx3JBBeNANAZ6amNVGb8gNWxU=; b=iL5za2l6b9+cAnPTgE03sdDpnG9T8/p6Fbj7VpEJ3+GMKcdOgynttfaMrW9cjvGpgKhU+OSXjzoaTjUBV5sSz/V+L4JLxH5tRDOurnzU9kVXqyki9zfxmSJngBSmnXuCoZP7ij6Uh785+ou6LD5GTn1RED3yvkgL6lYGWQcM19y3nJta52HLO5Xng9y8MxhiiVV7hR236OLWtqFV6x/lkbN/74ddE86K/js5tn0G25FEzm2zLbijQiAYcQoswRnZJbSn/7ycemcYPAJUxfELDXYHYuAezG13uBQhzgeoLRD7xUk5IdY3FYTNmNNwZ7PgpdslO3bmNzF8xjIj6gJqxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D6vBXjFbfNUjMerHmlSx3JBBeNANAZ6amNVGb8gNWxU=; b=S0eGkAwZRMKbnc/ZN58LNQUBZXdboptyIyFgOFZc6s0fShpO8S04jznumidB20FhzVbNugwex5LWmz5ilxigzAuPpbIWTBbdP19f7y1r8Bsi2m/t4SyPkuVvEYrnVZ9QRvGPGGUFC76g4ON3XthkdM3rM8UJxK+RbxPRTzDdsKg= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB0133.namprd21.prod.outlook.com (2603:10b6:903:b2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.12; Thu, 28 May 2020 06:57:45 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::f112:82fb:d4fd:f7dd]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::f112:82fb:d4fd:f7dd%12]) with mapi id 15.20.3066.007; Thu, 28 May 2020 06:57:44 +0000 From: "Bret Barkelew" To: Rebecca Cran , "rfc@edk2.groups.io" , "lersek@redhat.com" , Andrew Fish , Michael Kubacki CC: "devel@edk2.groups.io" , "spbrogan@outlook.com" , "Desimone, Nathaniel L" , "Kinney, Michael D" , "Leif Lindholm (Nuvia address)" Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process Thread-Topic: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process Thread-Index: AQHWMkpAQllVD47S7Uu5/CgTnOOvwai5GwsAgAAFA4CAAg4DCIAArYoAgACmIwD//7ZU5YAA3ac3 Date: Thu, 28 May 2020 06:57:44 +0000 Message-ID: References: <2107AEA7-9145-4FC9-9E1A-C396F23877ED@apple.com> ,, In-Reply-To: Accept-Language: en-US X-Mentions: Michael.Kubacki@microsoft.com X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-05-27T17:43:25.8462785Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [71.212.144.72] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b77cf164-e11e-4b6f-85f2-08d802d46c5d x-ms-traffictypediagnostic: CY4PR21MB0133: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0417A3FFD2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ctbYAWliN3A6CbcLQmErOsi7u0WExIzceSvHkKyg6LAlkFaOJAV/PDrQ4VULAxMTmFUcr8jsNiCce/Ov2szIYcg4RcTsR3DNxLF1ieZPAYS1I1A4RwWLOr4dMXERwZT1YPmn2cqog3U4NgyOFuHq+/+CtJhDb+SrGblDqzgvlxvbuuEIenHMlFZb8WD9kbmEgYsxrXPNxCL4Zkhe0Vh79BUZYTcrpUOtcquisltdKrr00Zhfyomql0DlWZTGc3WxcjJaBS9SRjguxYgA+wsBteAmy7QRvVgK/ZG60hmmovIBsC3/fc4EqFB/0NqKem7UqU1PskwdwjT4HiOEGDhsUlRSwNpk1F42W6yapsQeTFI5MuX+KB73czEHCmBCJln+iU38cl0Wwr2DWX+MRHt5ZmiA3Xfdv61ErVmky9/bqX6AuNo4xnPHbcZ6/kGPSDDZa1EPs46OyYmoOOaN2NHjOQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR21MB0743.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(396003)(366004)(136003)(346002)(376002)(64756008)(66556008)(86362001)(33656002)(166002)(8990500004)(82950400001)(2906002)(83380400001)(82960400001)(54906003)(6636002)(66476007)(66446008)(9686003)(66946007)(76116006)(4326008)(5660300002)(55016002)(478600001)(966005)(316002)(7696005)(10290500003)(8936002)(6506007)(52536014)(110136005)(71200400001)(26005)(53546011)(8676002)(186003)(460985005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 0rdTLrhyQEMpGB/2ZGjCTkjNjopq/+4U6bVcrvlHsiDzRx5KEC0WyeWjTMCwst0IBw3jSEVhOliSMo/wCUIEEBFq587doB3rIT2bH9HEveyabps2Cwro4FgirtpEbOM3brXHjGoUWUI76iYV6ENZRBV0Xt8jY8MpYHGCvEfO7U+IsLqwC3VZWRz7otMAmwVTnwo7ww9MZxEdpYS1poDbS9yNjoI8ETu7H/sMAo959EItoSZlx4QeCWvcn7GM+TX6I9g3+CAG4S7UjQC49M3y250Wf0wVGeGiw3gRTjAV1RsTJnZPFIZHAdEBYnUzw6m1pshyiGSHn6hb/F/XJulYHG24wXesP21xCLSTpwRWBzdghj3oZ52njSk4uoyEpVvm5iQ8OjaTr+7O6ZzMDYJFGdl86cnJ9XcISYZqjrkOhw5GmHY3JrLdIUNkKaYvEnK7zt2zHVoSsekEbn1o3GXQxVWaPC9T/Rxgmp3bArgfEZlnUeM3pJGqtw6djtgaFGJZ MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: b77cf164-e11e-4b6f-85f2-08d802d46c5d X-MS-Exchange-CrossTenant-originalarrivaltime: 28 May 2020 06:57:44.5346 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KUKpThpv4df/Lj5K1OHE9dp8AqJcFFlRMZIZqRX+3sZZ/JWgGKKD23MzgixVWC+GdHT4g1VnKhihzYGNwqYeNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0133 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB0743B77264CD589D6F518299EF8E0CY4PR21MB0743namp_" --_000_CY4PR21MB0743B77264CD589D6F518299EF8E0CY4PR21MB0743namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Rebecca, I was able to confirm that it was an issue with Git for Windows. Looks like= it=92s fixed in current snapshots and will be in the next release: https://github.com/git-for-windows/git/issues/2598 Also, ATTN: @Michael Kubacki - Bret From: Bret Barkelew Sent: Wednesday, May 27, 2020 10:45 AM To: Rebecca Cran; rfc@edk2.groups.io; lersek@redhat.com; Andrew Fish Cc: devel@edk2.groups.io; spbrogan@outlook.com= ; Desimone, Nathaniel L; Kinney, Michael D; Lei= f Lindholm (Nuvia address) Subject: RE: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based C= ode Review Process That=92s not a bad idea: I should try with my WSL install. I=92m on the same version of Git for Windows, and think I=92ll open it as a= n issue to the maintainer. For now, going though the paces is just as useful to me as getting a viable= environment (after all, PRs soon!), so I don=92t mind trying another OS or= install if that=92s what it takes. - Bret From: Rebecca Cran Sent: Wednesday, May 27, 2020 9:07 AM To: rfc@edk2.groups.io; lersek@redhat.com; Bret Barkelew; And= rew Fish Cc: devel@edk2.groups.io; spbrogan@outlook.com= ; Desimone, Nathaniel L; Kinney, Michael D; Lei= f Lindholm (Nuvia address) Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based C= ode Review Process On 5/27/2020 6:12 AM, Laszlo Ersek wrote: > So, it could be a MINGW64 packaging bug, perhaps. I'm getting the same error, but with a different packaging of Git: mine's in C:\Program Files\Git\cmd\git.exe . It's version "git version 2.26.2.windows.1". Of course it's possible it's just the same MINGW version that's been put into its own installer. I also tried using my openSUSE WSL installation, but it failed with: STARTTLS failed! SSL connect attempt failed error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed at /usr/lib/git/git-send-email line 1548. So I ended up copying it to one of my FreeBSD systems and sent it from there. -- Rebecca Cran --_000_CY4PR21MB0743B77264CD589D6F518299EF8E0CY4PR21MB0743namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Rebecca,

 

I was able to confirm that it was an issue with Git = for Windows. Looks like it=92s fixed in current snapshots and will be in th= e next release:

https://github.com/git-for-windows/git/issues/2598

 

Also, ATTN: @Michael Kubacki

 

- Bret

 

From: Bret Barkelew
Sent: Wednesday, May 27, 2020 10:45 AM
To: Rebecca Cran; rfc@edk2.groups.io; lersek@redhat.= com; Andrew Fish
Cc: devel@edk2.groups.io= ; spbrogan@outlook.com; Desimone, Nathaniel L; Kinney, Michael D; Leif Lindholm (Nuvia address)
Subject: RE: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request = based Code Review Process

 

That=92s not a bad idea: I should try with my WSL in= stall.

 

I=92m on the same version of Git for Windows, and th= ink I=92ll open it as an issue to the maintainer.

 

For now, going though the paces is just as useful to= me as getting a viable environment (after all, PRs soon!), so I don=92t mi= nd trying another OS or install if that=92s what it takes.

 

- Bret

 

From: Re= becca Cran
Sent: Wednesday, May 27, 2020 9:07 AM
To: rfc@edk2.groups.io; lersek@redhat.com; Bret = Barkelew; Andrew Fish
Cc: devel@edk2.groups.io= ; spbrogan@outlook.com; Desimone, Nathaniel L; Kinney, Michael D; Leif Lindholm (Nuvia address)
Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request = based Code Review Process

 

On 5/27/2020 6:12 AM,= Laszlo Ersek wrote:

> So, it could be a MINGW64 packaging bug, perhaps.

I'm getting the same error, but with a different packaging of Git:
mine's in C:\Program Files\Git\cmd\git.exe .

It's version "git version 2.26.2.windows.1".

Of course it's possible it's just the same MINGW version that's been put into its own installer.


I also tried using my openSUSE WSL installation, but it failed with:

STARTTLS failed! SSL connect attempt failed error:1416F086:SSL
routines:tls_process_server_certificate:certificate verify failed at
/usr/lib/git/git-send-email line 1548.


So I ended up copying it to one of my FreeBSD systems and sent it from
there.


--
Rebecca Cran

 

 

--_000_CY4PR21MB0743B77264CD589D6F518299EF8E0CY4PR21MB0743namp_--