Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: Jiang, Guomin <guomin.jiang@intel.com>
> Sent: Sunday, March 22, 2020 10:56 PM
> To: devel@edk2.groups.io; Zhang, Shenglei
> <shenglei.zhang@intel.com>; newexplorerj@gmail.com
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
> sean.brogan@microsoft.com; Bret.Barkelew@microsoft.com
> Subject: RE: [edk2-devel] [PATCH] UnitTestFrameworkPkg:
> Invalid index may be used.
>
> Hi Michael, Sean, Bret,
>
> Could help review the patch?
>
> Thanks
> > -----Original Message-----
> > From: devel@edk2.groups.io
> [
mailto:devel@edk2.groups.io] On Behalf Of
> > Zhang, Shenglei
> > Sent: Wednesday, March 4, 2020 3:59 PM
> > To: devel@edk2.groups.io; newexplorerj@gmail.com
> > Subject: Re: [edk2-devel] [PATCH]
> UnitTestFrameworkPkg: Invalid index may
> > be used.
> >
> > Reviewed-by: Shenglei Zhang
> <shenglei.zhang@intel.com>
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io
> [
mailto:devel@edk2.groups.io] On Behalf Of
> > > GuoMinJ
> > > Sent: Thursday, February 20, 2020 9:42 AM
> > > To: devel@edk2.groups.io
> > > Cc: GuoMinJ <newexplorerj@gmail.com>
> > > Subject: [edk2-devel] [PATCH] UnitTestFrameworkPkg:
> Invalid index may
> > > be used.
> > >
> > > REF:
>
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2535&data=02%7C01%7CBret.Barkelew%40microsoft.com%7C6e119160718c41dd8bea08d7cf503d05%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205815839534686&sdata=G5r02YNEXW3PG%2BJUsOg9A5BrKdqpkdlJHceyK4Gkd1Y%3D&reserved=0
> > >
> > > The UINT_TEST_STATUS and FAILURE_TYPE have used 0
> as status, so use 0
> > > as unknown is confused, remove it from array
> enumeration but keep it
> > > location in the array.
> > >
> > > Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> > > ---
> > >
> .../Library/UnitTestResultReportLib/UnitTestResultRepor
> tLib.c | 4
> > > ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git
> > >
> >
> a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/
> UnitTestResultR
> > > eportLib.c
> > >
> >
> b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/
> UnitTestResultR
> > > eportLib.c
> > > index 687a04f55d..eba68e330c 100644
> > > ---
> > >
> >
> a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/
> UnitTestResultR
> > > eportLib.c
> > > +++
> > >
> >
> b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/
> UnitTestResultR
> > > eportLib.c
> > > @@ -65,7 +65,7 @@ GetStringForUnitTestStatus ( {
> > > UINTN Index;
> > >
> > > - for (Index = 0; Index < ARRAY_SIZE
> (mStatusStrings); Index++) {
> > > + for (Index = 0; Index < ARRAY_SIZE
> (mStatusStrings) - 1; Index++) {
> > > if (mStatusStrings[Index].Status == Status) {
> > > //
> > > // Return string from matching entry @@ -
> 87,7 +87,7 @@
> > > GetStringForFailureType ( {
> > > UINTN Index;
> > >
> > > - for (Index = 0; Index < ARRAY_SIZE
> (mFailureTypeStrings); Index++)
> > > {
> > > + for (Index = 0; Index < ARRAY_SIZE
> (mFailureTypeStrings) - 1;
> > > + Index++) {
> > > if (mFailureTypeStrings[Index].Type ==
> Failure) {
> > > //
> > > // Return string from matching entry
> > > --
> > > 2.17.1
> > >
> > >
> > >
> >
> >
> >