From: "Bret Barkelew" <bret.barkelew@microsoft.com>
To: Bob Feng <bob.c.feng@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Liming Gao <liming.gao@intel.com>
Subject: Re: [EXTERNAL] [Patch 1/1] BaseTools: Add .map file as a target in makefile
Date: Tue, 24 Mar 2020 17:40:09 +0000 [thread overview]
Message-ID: <CY4PR21MB0743C99FB448720058DCDA8FEFF10@CY4PR21MB0743.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20200324031239.13084-1-bob.c.feng@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2200 bytes --]
Updated the Bugzilla with feedback on this. I don’t think this is a good final solution.
It creates two new empty dependencies: one for the binary blob, but one for the parent driver. The parent driver dependency causes a warning in compiling.
- Bret
From: Bob Feng<mailto:bob.c.feng@intel.com>
Sent: Monday, March 23, 2020 8:12 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Liming Gao<mailto:liming.gao@intel.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [Patch 1/1] BaseTools: Add .map file as a target in makefile
Ref: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2624&data=02%7C01%7CBret.Barkelew%40microsoft.com%7C9c94983c098f4f1d604708d7cfa13bb2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637206163707852733&sdata=wqLUJ4Chlj%2FPHGbKr8Kfpscf6ZBFn26GGCewpz0RbYo%3D&reserved=0
The .map file may not exist, adding .map as a target
with empty dependency and command will avoid build failure.
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
BaseTools/Source/Python/AutoGen/GenMake.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/Python/AutoGen/GenMake.py
index bbb3c29446f5..f09a0b88297e 100755
--- a/BaseTools/Source/Python/AutoGen/GenMake.py
+++ b/BaseTools/Source/Python/AutoGen/GenMake.py
@@ -731,10 +731,11 @@ cleanlib:
if Dst not in self.ResultFileList:
self.ResultFileList.append(Dst)
if '%s :' %(Dst) not in self.BuildTargetList:
self.BuildTargetList.append("%s : %s" %(Dst,Src))
self.BuildTargetList.append('\t' + self._CP_TEMPLATE_[self._Platform] %{'Src': Src, 'Dst': Dst})
+ self.BuildTargetList.append("%s :" %(Src,))
FfsCmdList = Cmd[0]
for index, Str in enumerate(FfsCmdList):
if '-o' == Str:
OutputFile = FfsCmdList[index + 1]
--
2.20.1.windows.1
[-- Attachment #2: Type: text/html, Size: 5591 bytes --]
prev parent reply other threads:[~2020-03-24 17:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 3:12 [Patch 1/1] BaseTools: Add .map file as a target in makefile Bob Feng
2020-03-24 17:40 ` Bret Barkelew [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR21MB0743C99FB448720058DCDA8FEFF10@CY4PR21MB0743.namprd21.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox