From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.130]) by mx.groups.io with SMTP id smtpd.web11.1188.1585071610825591575 for ; Tue, 24 Mar 2020 10:40:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=HylOI5kh; spf=pass (domain: microsoft.com, ip: 40.107.236.130, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EO1klD0e2Qz1Xfsx9zMCvymDepCyG8DI/6oxCDFfdYn/QhJKnl+Rhd39sedhTSFjDKnGCIhYpf32CeFKK1Sgcc8gmAwN9p3v0nnT3NmdkY2ZWlL2BH8DFBNxDp4O5Wyx3bQL4x+RuGNbPeGP/5XbNGcJ0pvbel5gemMIiS4GSw79VH3yevvgLBvEXYUHV8BGNaho+Trlx49TN2H0CTueGn8yQy6N1LxQI4kPhd5u3LoqVrxL5e9cB1ng5Fo+cyW5GhY+KRLjivg6vUeLzijN7/JA2GZ+D9/AVPbDxJWH9T7NJE3MM3L32Ms4DgJb2+moZuv46zwsqn7iZpYv0gzW0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GPxlJfwWfLy/dYvwobqfX/PXiZkpnyUVRzjhIyFPdUs=; b=G/siWN/givxD+3bmNwhKeJnJ4FfsbvzUIwyopxPbk7uFzaTgQwvd7w37oalCG3dHEbckC9drrIk51JpOrfkDrSq5QmBovIb1/qzpgVv7iXN/JiBscKDA34N2oORW/Ntj1gWeTV2uy494c3hWQ+30IxhRrDnK4Ws+H7R6a1YjB3aV4F80hkeCdm4CCZv1f2SXMLZ3i758DIECS+2FEthdofAoR9AlYdM7CuoGIoKyYrRwPA6CC+d6qUK1GTz8thRaHnRUdbvgzB/KG50AY1uyYt2t0b6uBlf71Zj4xqNglX/OCkEpFoWiut/InNM9EGXr0FzBVIHvUfcxZGZ4wkjrGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GPxlJfwWfLy/dYvwobqfX/PXiZkpnyUVRzjhIyFPdUs=; b=HylOI5khI6fw31joJg8AL8wZgn1dcDILcd0Nd1E/b0//GQfkJZGY6AHEkq3Zzx9IeFBKBTFTQsNBNlwQCWG7YfpVpX3j3d+lBy4YrBhbWVb1KgG9ZeJ0Xw9BxJb2c+1BN6yZu2szMyR0o/rZh+inl0X0frCpWbIBG5VpMLQZvEE= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB0821.namprd21.prod.outlook.com (2603:10b6:903:b8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.2; Tue, 24 Mar 2020 17:40:09 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318%10]) with mapi id 15.20.2878.000; Tue, 24 Mar 2020 17:40:09 +0000 From: "Bret Barkelew" To: Bob Feng , "devel@edk2.groups.io" CC: Liming Gao Subject: Re: [EXTERNAL] [Patch 1/1] BaseTools: Add .map file as a target in makefile Thread-Topic: [EXTERNAL] [Patch 1/1] BaseTools: Add .map file as a target in makefile Thread-Index: AQHWAYoayZMkoMbnFk2by4OhIyw5EqhYAxlB Date: Tue, 24 Mar 2020 17:40:09 +0000 Message-ID: References: <20200324031239.13084-1-bob.c.feng@intel.com> In-Reply-To: <20200324031239.13084-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-03-24T17:38:54.0375113Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bret.Barkelew@microsoft.com; x-originating-ip: [71.212.145.195] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 128df8a4-8e37-4d45-e979-08d7d01a65d7 x-ms-traffictypediagnostic: CY4PR21MB0821: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2089; x-forefront-prvs: 03524FBD26 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(366004)(39860400002)(346002)(376002)(136003)(396003)(7696005)(966005)(5660300002)(55016002)(9686003)(8990500004)(110136005)(2906002)(316002)(478600001)(53546011)(6506007)(33656002)(8936002)(76116006)(52536014)(81166006)(81156014)(86362001)(10290500003)(26005)(71200400001)(186003)(8676002)(64756008)(66946007)(4326008)(66476007)(66446008)(66556008)(91956017)(142923001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0821;H:CY4PR21MB0743.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0V32AXIJ3sZJoyZq4OOhA/BP46qIH10f84W+2zJg6VcMiVI2ipphSBffVrBjSXBYpDHg/XHr++dwKSr7qUNM4gITX5HJG0AneXSvT4farcahYnrGegowkPSzXOr178axrCSEu1pPT+Km7OfvG5VWUd6TWTV4pSau6ad0OadA+NNLarXVvFCj7ynCk8fL33Dnt4SFmz1Iau9PT1VZGh0KrDO7luYEcC9wX67H+Hud4AqZr/+XrH0ob9y/ZdpafymWAI8NwkwIDCys2tJcCoqu+LxAjL2EmXiln1GAQp7FdsO7+i4wmHBeQCuoyA4R6sKxBfIKyAgzVxTMvH6XOUz8jFFIYTDrhU2xoMoRxIG/CqvVimCiPELPbwQhhLktRNWpMvnc9uIXMsG/pwQv1doaMTrETS8OWhYrieImutP73ZVCQkVt/igVBKF41QHxvGqb+8a0wlFBXXf31Wy4wTmqH5gX9cMEaIjgj0+dDRXKe2mFfEDkvTH9mzcX1T5M9LEiBN5AVbvKVOSgoVlpvdq334Oy+X2qcPbSDskOetCyz7qwuq0dPWCCd931zecsp3Jt x-ms-exchange-antispam-messagedata: ok/fzGvONjTUR193r0LKLNUndT9JoF7hkfzYlLOSdWs/B7wHObOs5qDdfTNuWfoJ8SjisGPqUx8ik8MV44PO1H7P0ELwhshsDFhnb/golAcLRhlmNZmVjsXlZdFFcBAjgkAiwctFsze1hyVwy37N7Q== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 128df8a4-8e37-4d45-e979-08d7d01a65d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2020 17:40:09.1181 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N7uGUeGRNculTf8SXV0SLOppm7nj4dTtLW4MUVbLFBOrU+Is2E/w+mGV+NzBqJ4NNuscDd4MM3tATXcuCGhhTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0821 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB0743C99FB448720058DCDA8FEFF10CY4PR21MB0743namp_" --_000_CY4PR21MB0743C99FB448720058DCDA8FEFF10CY4PR21MB0743namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Updated the Bugzilla with feedback on this. I don=92t think this is a good = final solution. It creates two new empty dependencies: one for the binary blob, but one for= the parent driver. The parent driver dependency causes a warning in compil= ing. - Bret From: Bob Feng Sent: Monday, March 23, 2020 8:12 PM To: devel@edk2.groups.io Cc: Liming Gao; Bret Barkelew Subject: [EXTERNAL] [Patch 1/1] BaseTools: Add .map file as a target in mak= efile Ref: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbu= gzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2624&data=3D02%7C01%7CBret.B= arkelew%40microsoft.com%7C9c94983c098f4f1d604708d7cfa13bb2%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637206163707852733&sdata=3DwqLUJ4Chlj%2FPH= GbKr8Kfpscf6ZBFn26GGCewpz0RbYo%3D&reserved=3D0 The .map file may not exist, adding .map as a target with empty dependency and command will avoid build failure. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Bret Barkelew --- BaseTools/Source/Python/AutoGen/GenMake.py | 1 + 1 file changed, 1 insertion(+) diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/= Python/AutoGen/GenMake.py index bbb3c29446f5..f09a0b88297e 100755 --- a/BaseTools/Source/Python/AutoGen/GenMake.py +++ b/BaseTools/Source/Python/AutoGen/GenMake.py @@ -731,10 +731,11 @@ cleanlib: if Dst not in self.ResultFileList: self.ResultFileList.append(Dst) if '%s :' %(Dst) not in self.BuildTargetList: self.BuildTargetList.append("%s : %s" %(Dst,Src)) self.BuildTargetList.append('\t' + self._CP_TEMPLA= TE_[self._Platform] %{'Src': Src, 'Dst': Dst}) + self.BuildTargetList.append("%s :" %(Src,)) FfsCmdList =3D Cmd[0] for index, Str in enumerate(FfsCmdList): if '-o' =3D=3D Str: OutputFile =3D FfsCmdList[index + 1] -- 2.20.1.windows.1 --_000_CY4PR21MB0743C99FB448720058DCDA8FEFF10CY4PR21MB0743namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Updated the Bugzilla with feedback on this. I don=92= t think this is a good final solution.

It creates two new empty dependencies: one for the b= inary blob, but one for the parent driver. The parent driver dependency cau= ses a warning in compiling.

 

- Bret

 

From: Bob Feng
Sent: Monday, March 23, 2020 8:12 PM
To: devel@edk2.groups.io=
Cc: Liming Gao; Bret Barkelew
Subject: [EXTERNAL] [Patch 1/1] BaseTools: Add .map file as a target= in makefile

 

Ref: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzill= a.tianocore.org%2Fshow_bug.cgi%3Fid%3D2624&amp;data=3D02%7C01%7CBret.Ba= rkelew%40microsoft.com%7C9c94983c098f4f1d604708d7cfa13bb2%7C72f988bf86f141a= f91ab2d7cd011db47%7C1%7C0%7C637206163707852733&amp;sdata=3DwqLUJ4Chlj%2= FPHGbKr8Kfpscf6ZBFn26GGCewpz0RbYo%3D&amp;reserved=3D0

The .map file may not exist, adding .map as a target
with empty dependency and command will avoid build failure.

Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 BaseTools/Source/Python/AutoGen/GenMake.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/= Python/AutoGen/GenMake.py
index bbb3c29446f5..f09a0b88297e 100755
--- a/BaseTools/Source/Python/AutoGen/GenMake.py
+++ b/BaseTools/Source/Python/AutoGen/GenMake.py
@@ -731,10 +731,11 @@ cleanlib:
            &nb= sp;        if Dst not in self.ResultFile= List:
            &nb= sp;            self.= ResultFileList.append(Dst)
            &nb= sp;        if '%s :' %(Dst) not in self.= BuildTargetList:
            &nb= sp;            self.= BuildTargetList.append("%s : %s" %(Dst,Src))
            &nb= sp;            self.= BuildTargetList.append('\t' + self._CP_TEMPLATE_[self._Platform] %{'Src= ': Src, 'Dst': Dst})
+           &nbs= p;            self.B= uildTargetList.append("%s :" %(Src,))
 
             Ff= sCmdList =3D Cmd[0]
             fo= r index, Str in enumerate(FfsCmdList):
            &nb= sp;    if '-o' =3D=3D Str:
            &nb= sp;        OutputFile =3D FfsCmdList[ind= ex + 1]
--
2.20.1.windows.1

 

--_000_CY4PR21MB0743C99FB448720058DCDA8FEFF10CY4PR21MB0743namp_--