From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.122]) by mx.groups.io with SMTP id smtpd.web12.7492.1589380878117767598 for ; Wed, 13 May 2020 07:41:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=OY5gldah; spf=pass (domain: microsoft.com, ip: 40.107.236.122, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VpJZQqkZMYpeHRkYaJhyHw6pCBbt8sGUR1RChJzzdQCxvDbXKzx4w23udDWHEfNryn7QtnrU1x8okiGqjapS4Hss0JtYi078YPkYOqQ9x5Y9m0wVQnjoo145LqTs2Bwddff+JKMIqwTtdvnmNxwzFCg2orsz2PUWxM+9m6h4h+Wp8cBRkiuvpuKKjZiQWw6N70LGIyv+N1BRZkSaTIIpndR0zPul2QeluBTp/QR9MOT7xUaxcfraryJy+Pq6kHTGzvp+cNZD8NeOwJkkdCLWaOWGVOwXN76mIAriSbKsXx4EHtCKfu413cKbCus4ZZyjHOb/Qaz8VH73ycK4VAwrcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fkQXgBWqcg1FNR5FPjVD47SvItcpXyNrhQK/XquIzRg=; b=oAYWzdv79ebEYT35LZlb2PeV6LPcgbNONJPXx7CrLJZsJ/l1L7TmzvgJf+VUYkxhhnHmZyNzV3g0Kjl3VQfqtImN13iRSEn0+A4qWEbacGMG39hHb3YHNRWgprc/TKOpmkxcAuDQYjXKKoy0QhjPHHcGbYg+UUHdQUx2Uy/5x1Kww5eCT1yrU3tkg/53aigu3vs1KYQkpWv88m2N81MM4ti4jE9Zz/bW7OwDdRyiQM1kFE47gnxR2eSE0kFk2bxM6e28FtCSDdXig1GEBdaApu4PZ3FTJc76uZW6nEvcAKtJAO5Andg0D2bmsGK5D/YABiTc6RQtOx8matbil6p1Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fkQXgBWqcg1FNR5FPjVD47SvItcpXyNrhQK/XquIzRg=; b=OY5gldahsuZC8M89LJovb+UBgWx/XhYM5iCRA869tB+Ok3JKqI6uvD+9/j30Ew6I2V9Sfr3Ly5ihcCtN5fsJR8yrq2B8+NvG2CVQQpZkRArVSbsWmNo3KMu+Jd9BiNXTL9kyZWBfFTzcUDRQ0rPmTexmSJhJDiVb4E2NwoETi/4= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB1554.namprd21.prod.outlook.com (2603:10b6:910:92::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.3; Wed, 13 May 2020 14:41:15 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::9918:8742:bbe7:84e8]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::9918:8742:bbe7:84e8%14]) with mapi id 15.20.3021.002; Wed, 13 May 2020 14:41:15 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , "lersek@redhat.com" , "Kinney, Michael D" , Vitaly Cheptsov CC: Andrew Fish , =?Windows-1252?Q?Marvin_H=E4user?= , liming.gao , "Gao, Zhichao" Subject: Re: [EXTERNAL] Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions Thread-Topic: [EXTERNAL] Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions Thread-Index: AQHWKIm51wEY45gWnECjCNtI7h0Q76ilvTYAgABaYFM= Date: Wed, 13 May 2020 14:41:15 +0000 Message-ID: References: <20200511154121.3878-1-cheptsov@ispras.ru> <44ac1ca1-953a-21a2-0c9e-c83aca153b0b@redhat.com> ,<9347b132-b0e9-5b26-f993-910aafc9d6ae@redhat.com> In-Reply-To: <9347b132-b0e9-5b26-f993-910aafc9d6ae@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-05-13T14:39:39.3098004Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [71.212.135.200] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 6489fd28-4257-4b9f-88fc-08d7f74bb0dc x-ms-traffictypediagnostic: CY4PR21MB1554: x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 0402872DA1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fQVJRFa0vR92q3BMY1V0Ra44tiIgfm1CkiSBZadsc0TZTJ6zp0ERhLNffgZSJuxANTTstf+c/N6YgsNqMcIeGCSMrvFNdNcfjnK5TRpmLB+iIgu24Tbe0IEnjy0xbgppJ6COxaiMm1HhJcycgzeXcXulT7pA+FO9qc+/m/3XSjC8RZwSwcXtQ+KCO1rYjeufCzAlQLVKK8mOgkpaqpOTGibop89MHJ6hi3Q7ve2DZzN64VNb4/KViehy7MTR/F5HucPuH4KN40eCwNZVEBaHsqwUHVDLxWn7tjcmAlEoJMIcx6HVj9F5dMEQ5DZ20KSa+zVvjzuHmeOogIO+23A+8yhlwEGa3KFmWZRL83hYjRaXOszEdu7B8t/GbUeCNUTlC7vYjDh9daWCnIzLLQIPh29JrkucKPsCO031WgmRKBmiNRUBsqJKwbzii9I5Zkhr5E13qA2udBu/xo7IdueALJjSK9CK/aHf174BfYziX1ncFOvzjsD2E2F1EKD2cDqaocHTLifrL3nc+O5oc46K59IG83r5ZO5H6/CVnGc9Lsy0ADOIEqbQOFbaEpLjHM2djcP+5hv36mxdQGARb7em6QyR/o2sdtlD16bbnlExCns= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR21MB0743.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(366004)(376002)(39860400002)(346002)(33430700001)(478600001)(186003)(966005)(52536014)(316002)(2906002)(71200400001)(166002)(66574014)(86362001)(33440700001)(8990500004)(26005)(10290500003)(7696005)(91956017)(4326008)(110136005)(82950400001)(82960400001)(8676002)(8936002)(55016002)(9686003)(54906003)(76116006)(66476007)(5660300002)(64756008)(66556008)(66446008)(33656002)(66946007)(53546011)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: axagpht2b+nmpw1aCBP6k5oye+nATTygEhk83hynnoitCebR5AUw1tnb0BO33Ns/3JkwN2Z8YUmlkge4CyhRUszTGTS0O6N8DREmReR0GnN2b/ofT7JukvQb8IVauIZeC0Rl7K/Xfl0kULdBs5EVCqesoaaZ/UbDon053T1J4jqRQ9UR6tGQM0jxPZZyMSuKIB13jK+KxcrnxOJ3/Aqm1RSFgIqEYDsUXhKmO8RXu+/FJGko5KDGVb/IgNkvUmPQ8SbcvgAJN0TEYUGmhdWqvByMclQzQaiHaU90CUO78yYo7MVEYV+OGNgNudeeXU2vBaB6MDUCBM/CpP+zWl9LHgmFLyNehi0Qm3S+P3ckP93DN2NYAs5yuvgjGqOpaW9RtN6F3kRg30rKj2BcRw6Kx9IWMITCtT7r7lTAGd0yWrzBPlqp2jGIkM9bR4mBwJg4aLO4/LKm/BUha6hiaWFXK+0Igh2ho+elvMK6GRGW7w5FXDJs4gmHjsBY7x9MVh4n x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6489fd28-4257-4b9f-88fc-08d7f74bb0dc X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 14:41:15.5166 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: L2wnozavMTCFf80gCfErMmB9RWDsHlFA6zjmMsupa7NV8EeVQ/1ykiGuKEEXADeT2IP3sNN2iYMQ8LIX3CB8qw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB1554 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB0743D980C8E13FA85E250DE1EFBF0CY4PR21MB0743namp_" --_000_CY4PR21MB0743D980C8E13FA85E250DE1EFBF0CY4PR21MB0743namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Ooooo. Does that mean we get to start on DebugLibEx? In all seriousness, I=92m also in the camp of =93can=92t we just drop thes= e assertions=94? - Bret ________________________________ From: devel@edk2.groups.io on behalf of Laszlo Erse= k via groups.io Sent: Wednesday, May 13, 2020 2:16:12 AM To: Kinney, Michael D ; devel@edk2.groups.io <= devel@edk2.groups.io>; Vitaly Cheptsov Cc: Andrew Fish ; Marvin H=E4user ; = liming.gao ; Gao, Zhichao Subject: [EXTERNAL] Re: [edk2-devel] [PATCH V4 00/27] Disabling safe strin= g constraint assertions Hi Mike, On 05/12/20 20:18, Kinney, Michael D wrote: > What if there is a > DebugLib implementation of the DebugLib class that > does not depend on DebugCommonLib. There need not be a link failure in this case either, if the DebugLib instance in question provides the DebugCommonLib API implementations too. Anyway I don't want to obsess about this. I'm just sad there are zero acceptable solutions apparently to the 100% valid problem statement that Vitaly submitted last August, in TianoCore#2054. (Asserting properties of untrusted external data is *asinine*.) But then, if Vitaly proposes to update all DebugLib instances one by one, that gets shot down because "too many DebugLib instances in platforms". And if Vitaly extracts the common bits so that only the common bits have to be updated, that gets shot down by "we don't support this kind of dependency, please update all DebugLib instances instead". Let's just be honest and call DebugLib frozen forever. Laszlo --_000_CY4PR21MB0743D980C8E13FA85E250DE1EFBF0CY4PR21MB0743namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable
Ooooo. Does that mean we get to start on De= bugLibEx?

In all seriousness, I=92m also in the camp = of =93can=92t we just drop these assertions=94?

- Bret
From: devel@edk2.groups.io= <devel@edk2.groups.io> on behalf of Laszlo Ersek via groups.io <l= ersek=3Dredhat.com@groups.io>
Sent: Wednesday, May 13, 2020 2:16:12 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk= 2.groups.io <devel@edk2.groups.io>; Vitaly Cheptsov <cheptsov@ispr= as.ru>
Cc: Andrew Fish <afish@apple.com>; Marvin H=E4user <mhaeus= er@outlook.de>; liming.gao <liming.gao@intel.com>; Gao, Zhichao &l= t;zhichao.gao@intel.com>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH V4 00/27] Disabling saf= e string constraint assertions
 
Hi Mike,

On 05/12/20 20:18, Kinney, Michael D wrote:

> What if there is a
> DebugLib implementation of the DebugLib class that
> does not depend on DebugCommonLib.

There need not be a link failure in this case either, if the DebugLib
instance in question provides the DebugCommonLib API implementations too.<= br>
Anyway I don't want to obsess about this. I'm just sad there are zero
acceptable solutions apparently to the 100% valid problem statement that Vitaly submitted last August, in TianoCore#2054. (Asserting properties
of untrusted external data is *asinine*.) But then, if Vitaly proposes
to update all DebugLib instances one by one, that gets shot down because "too many DebugLib instances in platforms". And if Vitaly extrac= ts the
common bits so that only the common bits have to be updated, that gets
shot down by "we don't support this kind of dependency, please update=
all DebugLib instances instead".

Let's just be honest and call DebugLib frozen forever.

Laszlo




--_000_CY4PR21MB0743D980C8E13FA85E250DE1EFBF0CY4PR21MB0743namp_--