public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bret Barkelew" <bret.barkelew@microsoft.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"liming.gao@intel.com" <liming.gao@intel.com>,
	"Zhang, Shenglei" <shenglei.zhang@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH] pip-requirements.txt: Update extensions min version to 0.13.3
Date: Tue, 7 Apr 2020 21:24:05 +0000	[thread overview]
Message-ID: <CY4PR21MB0743F1505C14FC5A4019D9B3EFC30@CY4PR21MB0743.namprd21.prod.outlook.com> (raw)
In-Reply-To: <0eca8ba801dc40ba834c97f170e1b2cb@intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 3661 bytes --]

Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>

- Bret


From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Liming Gao via groups.io <liming.gao=intel.com@groups.io>
Sent: Tuesday, April 7, 2020 12:52:24 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Zhang, Shenglei <shenglei.zhang@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH] pip-requirements.txt: Update extensions min version to 0.13.3

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhang, Shenglei
> Sent: Tuesday, April 7, 2020 2:48 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-devel] [PATCH] pip-requirements.txt: Update extensions min version to 0.13.3
>
> REF: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2616&amp;data=02%7C01%7Cbret.barkelew%40microsoft.com%7C6021f77b97e34c96669708d7dac89f6a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637218427518277862&amp;sdata=KBYxcmatNgKG4m9qVdJJYwywGEhRQCJ38tSlzR2gAbc%3D&amp;reserved=0
> Pytool extensions are locked on 0.12.x but extensions has
> moved to 0.13.x. So update the pip-requirements.txt.
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  pip-requirements.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pip-requirements.txt b/pip-requirements.txt
> index 6a41a95ec594..574dac43b1a6 100644
> --- a/pip-requirements.txt
> +++ b/pip-requirements.txt
> @@ -9,8 +9,8 @@
>  # https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpypi.org%2Fproject%2Fpip%2F&amp;data=02%7C01%7Cbret.barkelew%40microsoft.com%7C6021f77b97e34c96669708d7dac89f6a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637218427518287862&amp;sdata=Qrpu2VOJEePvUnpZq6kC869cTAPtbBEzczgdaoF%2BqvU%3D&amp;reserved=0
>  # https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpip.pypa.io%2Fen%2Fstable%2Fuser_guide%2F%23requirements-files&amp;data=02%7C01%7Cbret.barkelew%40microsoft.com%7C6021f77b97e34c96669708d7dac89f6a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637218427518287862&amp;sdata=EJKS3MVTDeiwgMduhrRQUWBBnQB%2BashSmMbz3qQT7fQ%3D&amp;reserved=0
>  # https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpip.pypa.io%2Fen%2Fstable%2Freference%2Fpip_install%2F%23requirements-file-format&amp;data=02%7C01%7Cbret.barkelew%40microsoft.com%7C6021f77b97e34c96669708d7dac89f6a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637218427518287862&amp;sdata=gA%2BY7KTBm4PG3zkg1oj5UZbXOpq3%2BbFs%2BLX%2F9M8SQz4%3D&amp;reserved=0
> -#
> +# https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.python.org%2Fdev%2Fpeps%2Fpep-0440%2F%23version-specifiers&amp;data=02%7C01%7Cbret.barkelew%40microsoft.com%7C6021f77b97e34c96669708d7dac89f6a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637218427518287862&amp;sdata=%2FgC4Wt8KqUrMVN%2BPZiYvlTKeNbPPSs2d%2BaqFVFtRQMY%3D&amp;reserved=0
>  ##
>
>  edk2-pytool-library==0.10.*
> -edk2-pytool-extensions==0.12.*
> +edk2-pytool-extensions~=0.13.3
> --
> 2.18.0.windows.1
>
>
>





[-- Attachment #1.2: Type: text/html, Size: 8216 bytes --]

[-- Attachment #2: 243E72E21CD24441BC96F9002E545D1F.png --]
[-- Type: image/png, Size: 159 bytes --]

  reply	other threads:[~2020-04-07 21:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07  6:47 [PATCH] pip-requirements.txt: Update extensions min version to 0.13.3 Zhang, Shenglei
2020-04-07  6:47 ` [PATCH] .azurepiplines/pr-gate-steps.yml: Update python to 3.8.x for ci build Zhang, Shenglei
2020-04-07  7:52   ` [edk2-devel] " Liming Gao
2020-04-07 21:23     ` Bret Barkelew
2020-04-09  5:13   ` Michael Kubacki
2020-04-07  6:47 ` [PATCH] BaseTools/WindowsVsToolChain.py: Update toolchain plugin Zhang, Shenglei
2020-04-07 21:31   ` [EXTERNAL] [edk2-devel] " Bret Barkelew
2020-04-07  7:52 ` [edk2-devel] [PATCH] pip-requirements.txt: Update extensions min version to 0.13.3 Liming Gao
2020-04-07 21:24   ` Bret Barkelew [this message]
2020-04-09  3:22 ` Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR21MB0743F1505C14FC5A4019D9B3EFC30@CY4PR21MB0743.namprd21.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox