From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.33.95; helo=nam01-bn3-obe.outbound.protection.outlook.com; envelope-from=sean.brogan@microsoft.com; receiver=edk2-devel@lists.01.org Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0095.outbound.protection.outlook.com [104.47.33.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 999E521EBD1CC for ; Thu, 19 Apr 2018 22:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=c6wsZsIuQ//AP1kq0lpeszBvNzwvBDx14oGl3v1lIU8=; b=j7mqMv/gmFd379jQQbzicjilXvX4EkMVgKKFixhHTxmut/ZPYeF8O1mR6kzAVmWCZSqUohZWqUqWApYjlIFEnIe3R5nOj2rsnlLVC/LkIycBtw+bxB5O2xW34myV5TtKRlIMIPa1q07fCkt0OvmovCgndcThcQUUaUlN3OpOnds= Received: from CY4PR21MB0789.namprd21.prod.outlook.com (10.175.121.143) by CY4PR21MB0759.namprd21.prod.outlook.com (10.173.192.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.715.4; Fri, 20 Apr 2018 05:07:24 +0000 Received: from CY4PR21MB0789.namprd21.prod.outlook.com ([fe80::1468:84b3:8592:87aa]) by CY4PR21MB0789.namprd21.prod.outlook.com ([fe80::1468:84b3:8592:87aa%7]) with mapi id 15.20.0715.007; Fri, 20 Apr 2018 05:07:24 +0000 From: Sean Brogan To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Zeng, Star" , "Dong, Eric" , "Yao, Jiewen" , "Wei, David" , "Guo, Mang" , "Steele, Kelly" Thread-Topic: [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules Thread-Index: AQHT0fgAN8t0iKfAnkG2VsxZ/M6DvaQJJvvw Date: Fri, 20 Apr 2018 05:07:24 +0000 Message-ID: References: <20180412004830.9904-1-michael.d.kinney@intel.com> In-Reply-To: <20180412004830.9904-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=sebrogan@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-04-20T05:07:19.9288312Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [50.47.108.29] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR21MB0759; 7:rjzZI16cGU/ae+YCu5PwsdjBqAmCSo+sdkkqtSX/rpJHHZZKxWe+EX4qYyEyOtIodd9Lwpz9IWWAowoTd51FgwqSnjoWPiyrBnEP2zANDwmEc1VoJMNLBa0OUmYQrmeEO3QvKjgYqVRsPtUCoeMj3n5W9wKR9TpT3sC3wH7wuSjucurSUN+tXQVQkTtc+DC2mcP1wzbXz9L8Ep1owfI67e6TLiYPMpnkEU59XYgM8TlqIyMQ9nM8HbcvdA8wLLFP; 20:vT3bVVSdblZr0f8fR1f7uX3wpY/PVRXRi33RH0o68H6e+SMpQetbT3YDKMmmSANtg/yUVR/TZKpE/6fqS0ob/9bVhsC7+jISjTDieRsjUCqN1GRP8YMFAT1sHcosoTiLdUTa4bQxRA9Sm0DugQkIhsRdZJSLlleJJPRUn2WLzsI= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(2017052603328)(7193020); SRVR:CY4PR21MB0759; x-ms-traffictypediagnostic: CY4PR21MB0759: authentication-results: outbound.protection.outlook.com; spf=skipped (originating message); dkim=none (message not signed) header.d=none; dmarc=none action=none header.from=microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(166708455590820)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231232)(944501390)(52105095)(3002001)(6055026)(61426038)(61427038)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CY4PR21MB0759; BCL:0; PCL:0; RULEID:; SRVR:CY4PR21MB0759; x-forefront-prvs: 0648FCFFA8 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(346002)(39860400002)(396003)(376002)(39380400002)(13464003)(478600001)(5660300001)(8936002)(305945005)(2900100001)(33656002)(22452003)(8676002)(44832011)(446003)(6116002)(3846002)(74316002)(6436002)(476003)(966005)(316002)(6246003)(81166006)(54906003)(25786009)(186003)(11346002)(26005)(9686003)(53546011)(59450400001)(102836004)(6506007)(53936002)(3280700002)(3660700001)(6306002)(10290500003)(55016002)(86612001)(2501003)(2906002)(66066001)(5250100002)(7736002)(7696005)(4326008)(229853002)(76176011)(110136005)(86362001)(19627235001); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR21MB0759; H:CY4PR21MB0789.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; MLV:sfv; x-microsoft-antispam-message-info: aGJS1iNp6U9MQvzPTpV7ecJbWeuEMyF5RHi9Ovkfg2oLv4tkuJ1z+7tZ63PYZavYdZtbACjy9A1Id7bApzFUmPkHAZNd7K52drA4RACUh+rdoU9f8hMmM/ulOIZS/s6LsUlWf6FZ3VALYRoFvLR8WLuQXbriaoroilI2g1ZV/voChiJu1RL2jt6RTXuVX4fc spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 101c1a90-4a85-4e85-cbf3-08d5a67c9ad1 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 101c1a90-4a85-4e85-cbf3-08d5a67c9ad1 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2018 05:07:24.4197 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0759 Subject: Re: [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2018 05:07:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sean Brogan -----Original Message----- From: Kinney, Michael D =20 Sent: Wednesday, April 11, 2018 5:48 PM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Zeng, Star ; Dong, Eric ; Yao, Jiewen ; W= ei, David ; Guo, Mang ; Steele, Ke= lly ; Kinney, Michael D Subject: [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules https://bugzilla.tianocore.org/show_bug.cgi?id=3D801 Based on content from: https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCapsuleU= pdatePkg/Include/Library/DisplayUpdateProgressLib.h https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleU= pdatePkg/Library/DisplayUpdateProgressGraphicsLib https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleU= pdatePkg/Library/DisplayUpdateProgressTextLib Updates for V2 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D * Change DisplayUpdateProgressGraphicsLib to DisplayUpdateProgressLibGraphi= cs * Change DisplayUpdateProgressTextLib to DisplayUpdateProgressLibText * Clarify that color in Firmware Management Progress Protocol is the foregr= ound color * Add missing parameters to PerformFlashWriteWithProgress() function header= . * Update PerformFlashWriteWithProgress() function header describing the use= of the start and end percentage values. * Update QuarkPlatformPkg PerformFlashWriteWithProgress() to call Progress(= ) for the end precentage. * Update Vlv2Tbl2DevicePkg PerformFlashWriteWithProgress() to call Progress= () for the end precentage. Add DisplayUpdateProgressLib class along implementations for both graphical= (Graphics Output Protocol based) and text (Simple Text Output Protocol bas= ed) consoles. Also add the EDK II Firmware Management Progress Protocol th= at is an optional protocol that provides the progress bar color and a watch= dog timeout value thaty can be used when a firmware image is updated in a f= irmware device. * Add progress support to DxeCapsuleLibFmp * Add progress support to SystemFirmwareUpdateDxe * Add progress support to PlatformFlashAccessLib class and instances. * Reduce Print() calls during a firmware update. Cc: Sean Brogan Cc: Star Zeng Cc: Eric Dong Cc: Jiewen Yao Cc: David Wei Cc: Mang Guo Cc: Kelly Steele Signed-off-by: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Kinney, Michael D (3): QuarkPlatformPkg: Add DisplayUpdateProgressLib mapping MdeModulePkg/DxeCapsuleLibFmp: Add progress bar support SignedCapsulePkg/SystemFirmwareUpdateDxe: Use progress API Michael D Kinney (6): MdeModulePkg: Add DisplayUpdateProgressLib class MdeModulePkg: Add DisplayUpdateProgressLib instances Vlv2Tbl2DevicePkg: Add DisplayUpdateProgressLib mapping SignedCapsulePkg/PlatformFlashAccessLib: Add progress API Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add progress API QuarkPlatformPkg/PlatformFlashAccessLib: Add progress API .../Include/Library/DisplayUpdateProgressLib.h | 65 +++ .../Include/Protocol/FirmwareManagementProgress.h | 51 +++ .../DisplayUpdateProgressLibGraphics.c | 475 +++++++++++++++++= ++++ .../DisplayUpdateProgressLibGraphics.inf | 60 +++ .../DisplayUpdateProgressLibGraphics.uni | 18 + .../DisplayUpdateProgressLibText.c | 174 ++++++++ .../DisplayUpdateProgressLibText.inf | 53 +++ .../DisplayUpdateProgressLibText.uni | 18 + .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 47 +- .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf | 8 +- .../DxeCapsuleLibFmp/DxeCapsuleProcessLib.c | 84 +++- .../DxeCapsuleLibFmp/DxeCapsuleProcessLibNull.c | 21 +- .../DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | 7 +- MdeModulePkg/MdeModulePkg.dec | 11 + MdeModulePkg/MdeModulePkg.dsc | 3 + .../PlatformFlashAccessLibDxe.c | 78 +++- QuarkPlatformPkg/Quark.dsc | 1 + .../Include/Library/PlatformFlashAccessLib.h | 49 ++- .../PlatformFlashAccessLibNull.c | 70 ++- .../SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c | 90 +++- .../PlatformFlashAccessLib.c | 102 +++-- .../PlatformFlashAccessLib.inf | 3 +- Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 + Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + 25 files changed, 1387 insertions(+), 104 deletions(-) create mode 100644= MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h create mode 100644 MdeModulePkg/Include/Protocol/FirmwareManagementProgres= s.h create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/D= isplayUpdateProgressLibGraphics.c create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/D= isplayUpdateProgressLibGraphics.inf create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/D= isplayUpdateProgressLibGraphics.uni create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibText/Displ= ayUpdateProgressLibText.c create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibText/Displ= ayUpdateProgressLibText.inf create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibText/Displ= ayUpdateProgressLibText.uni -- 2.14.2.windows.3