public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Guo Dong" <guo.dong@intel.com>
To: "Hsu, VictorX" <victorx.hsu@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>, "Lu, James" <james.lu@intel.com>,
	"Guo, Gua" <gua.guo@intel.com>
Subject: Re: [PATCH] UefiPayloadPkg: The UPL info section is not aligned at 4-byte boundary
Date: Wed, 16 Nov 2022 03:57:51 +0000	[thread overview]
Message-ID: <CY5PR11MB6260662B32B789700AA75D0B9E079@CY5PR11MB6260.namprd11.prod.outlook.com> (raw)
In-Reply-To: <27f0ba3446516f3806020b293ec63b99f91b2e44.1668567968.git.victorx.hsu@intel.com>


Reviewed-by: Guo Dong <guo.dong@intel.com>

-----Original Message-----
From: Hsu, VictorX <victorx.hsu@intel.com> 
Sent: Tuesday, November 15, 2022 8:08 PM
To: devel@edk2.groups.io
Cc: Hsu, VictorX <victorx.hsu@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>
Subject: [PATCH] UefiPayloadPkg: The UPL info section is not aligned at 4-byte boundary

From: VictorX Hsu <victorx.hsu@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4153

1.Upgrade spec revision to 0.9
2.Align .upld_info with 4-byte boundary by spec

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: James Lu <james.lu@intel.com>
Cc: Gua Guo <gua.guo@intel.com>
Signed-off-by: VictorX Hsu <victorx.hsu@intel.com>
---
 UefiPayloadPkg/UniversalPayloadBuild.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/UefiPayloadPkg/UniversalPayloadBuild.py b/UefiPayloadPkg/UniversalPayloadBuild.py
index 6003de36d1..50a5950e7c 100644
--- a/UefiPayloadPkg/UniversalPayloadBuild.py
+++ b/UefiPayloadPkg/UniversalPayloadBuild.py
@@ -31,7 +31,7 @@ class UPLD_INFO_HEADER(LittleEndianStructure):
     def __init__(self):

         self.Identifier     =  b'PLDH'

         self.HeaderLength   = sizeof(UPLD_INFO_HEADER)

-        self.SpecRevision   = 0x0007

+        self.SpecRevision   = 0x0009

         self.Revision       = 0x0000010105

         self.ImageId        = b'UEFI'

         self.ProducerId     = b'INTEL'

@@ -133,7 +133,7 @@ def BuildUniversalPayload(Args, MacroList):
                        FvOutputDir,

                        EntryOutputDir

                        )

-    set_section    = '"{}" -I {} -O {} --set-section-alignment .upld.upld_info=16 --set-section-alignment .upld.uefi_fv=16 {}'.format (

+    set_section    = '"{}" -I {} -O {} --set-section-alignment .upld_info=4 --set-section-alignment .upld.uefi_fv=16 {}'.format (

                        LlvmObjcopyPath,

                        ObjCopyFlag,

                        ObjCopyFlag,

-- 
2.28.0.windows.1


      parent reply	other threads:[~2022-11-16  3:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16  3:07 [PATCH] UefiPayloadPkg: The UPL info section is not aligned at 4-byte boundary victorx.hsu
2022-11-16  3:33 ` Lu, James
2022-11-16  3:57 ` Guo Dong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY5PR11MB6260662B32B789700AA75D0B9E079@CY5PR11MB6260.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox