From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.6.1660345408620321643 for ; Fri, 12 Aug 2022 16:03:28 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=HlvCjuSQ; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: guo.dong@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660345408; x=1691881408; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=weM1U6Z9NRNqyAgqL7HhS3hwGRYDQ33TxpPwP2RBUpo=; b=HlvCjuSQ+gWkApSULi7kfoSm7/OCx+i+pdP7HhAJLPoGXqikzpu7OAuf 9yM3RZmXV6sQS/fSaGk7IF+fOuh5hfUJeob5bo3oiBMTFzSybYgzsxKzh IF4eYpSH1Q1Bt6dcJo6m5xshEB/I3jAgx8jaQsjA0Rk7i+aHxzMysPper v4b7gmb9Jz67LGyDPCUepe2gWuAsOPDhIBunwc7uoesrttmjQ8QBaJIgt ogeWGD+rT2kkmEujiN1up+W66L+6N3fdc/JFBwWPw23M3kvH5Pn+Q1bqR QwX8tqi8R3BWrCfVi0Ml7qg42KrFQhQic25S6C7S+IeDJEROeJ0+ehPEU Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10437"; a="274758536" X-IronPort-AV: E=Sophos;i="5.93,233,1654585200"; d="scan'208";a="274758536" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2022 16:03:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,233,1654585200"; d="scan'208";a="674252852" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP; 12 Aug 2022 16:03:15 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 12 Aug 2022 16:03:14 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 12 Aug 2022 16:03:14 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Fri, 12 Aug 2022 16:03:14 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.46) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Fri, 12 Aug 2022 16:03:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W6AYr4LvJHi685bGiSHbGWD5xPYOPUcDS3SEbTEtmTXkpbYR5SzlumcBgk8gcX9gQvDACAWRMNOmGkLfRXyr9YKzsp2pYXSCyRI3W4HJ9wyMRElSrO/1j46SdOOw4AQC2Tg7vOux2//XUxbvk18vgOvKTesVNH9kQjy7Vda9wqAmmbHXjtQ6PNhqwql4TOOTO8/ea8IMN/sdEx2gAcvf13F3dWe9KalXiA27vy4Bv489BoXhX1vGD+LxX3OoGxcuVHTptZSKwfxg7GrJhKcpM0AAaLv12HZsgLGYhSaoL1k4ktdxYq3YvTtU92flRLM2gmN6qZFIF6+D80qV5vSEVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dRhPPVTRGl7CboVT+I02jilpjtRAcPddaswWhGacUtg=; b=Crg69drwBxSQ+8X5pVzLCVbFGN4V3Bdh5Y/8FkFojjbq0NNIpZTopL4Gf9hmU8Z4QayRnemlsSc8/ouJCuwD0OpdtVZUb2GsTKx0rBeoU9AyZk6fsj4YOmBgUzYZ7ySkh6AYuHyMj48k3Chrt112mWzbZReh3J8t2oiLxXwNflgiAGPTi+bz2yjMzEgTEkVvyOZo5b0ZSEfMqXm+FQ7yvDf5YrDZmco4t2hO9nGbpqP/Jw5S1/Xv5moTzaX+af12wUjmUDjJNkW+m/L5FfYurJPxFDHJoB3Q4iQueQ9JKx9xY3q2WmmgsBeBuGTSwUWV0BLkiW2oJ9cTVL6u9Q0Zqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY5PR11MB6260.namprd11.prod.outlook.com (2603:10b6:930:23::16) by DM6PR11MB4643.namprd11.prod.outlook.com (2603:10b6:5:2a6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11; Fri, 12 Aug 2022 23:03:12 +0000 Received: from CY5PR11MB6260.namprd11.prod.outlook.com ([fe80::d51:f743:8ca2:8160]) by CY5PR11MB6260.namprd11.prod.outlook.com ([fe80::d51:f743:8ca2:8160%7]) with mapi id 15.20.5525.011; Fri, 12 Aug 2022 23:03:12 +0000 From: "Guo Dong" To: "devel@edk2.groups.io" , "Sravanthi, K KavyaX" CC: "Ni, Ray" , "Rhodes, Sean" , "Guo, Gua" Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL Thread-Topic: [edk2-devel] [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL Thread-Index: AQHYrVEsFfxn3qhltkmfoNHJxK9bt62r5LoQ Date: Fri, 12 Aug 2022 23:03:11 +0000 Message-ID: References: <20220811070739.1973-1-k.kavyax.sravanthi@intel.com> In-Reply-To: <20220811070739.1973-1-k.kavyax.sravanthi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 762b832f-ab47-45a4-3d7e-08da7cb6d4ae x-ms-traffictypediagnostic: DM6PR11MB4643:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dx5iI3SWhLecu6h/w5T87QPuGVHss5RPgq+gIhuPeYc1izig4FOdCzF0KlBnW4UXeHrMhV7CjFkV1Xkh2G57iW3JOGy7Peu+MA7uFteubLSXzaoh/FBiNNKUbzL5OV68j6BSw528NAj43RyymX4cp5D/aTygG/G0JPNz3lN00NZ/UnwTH4NzkPb88Jrfvq4o5XmhIiP6DQoKMjOKuyWIN20MUuGatjLtnWgpG8VN1JXfxhDEnwBmfo8arVv6La9Klkgp0Beq+oboGkgdUPOoP7eyoIID3e4JhIXWWNcf8tObwswCN2uV9Kjb5frkxkpg4fqcvQH/QC3iYbaK7lwo/cBtZse2BQJgvaRv/NOqwy5ZkdMqDQBUOY1lO1zukvFlirypKnvNp8BavsJjFF6biP/VnNLfuJxPliWjc7m9Zh8qQeV8hUejlrQCtr8V/XWU6LhLY4C5fYd8e79wigF4opDMKrBtAf4Y7jP/+ufJAKq1xKu9h/+pgsfLefKSHihDV4kpOrwXDknj2Pqtp7QhaWeXv9H96tWxcs3G9R3IAfAzY6oZXUTDp9o9qsKN0p3Y8PvH460We1lBfnQ9KQwzbonVNe2/FQaJc8xY9NluOM00M1TkY5FCnwhel0WwipU9T8qZ+QBPNnAFzb+iqJj1TPdc7uOvedpeNaYmWYu43bnhoF9tCOHbaNKUS+5NXdRmRZ28qQM59LV9VhHKIXjJiZLlF2FciFkvi3ycW2PKiHbSYDw/a8uyqTDPdwWSPglY/eF6QUXBqoiIY1yp5Uv1q0HajM7RSRSyiSLOE3UXcVpi/EcnTMFC9ASNwAFbIh4YDm/PE2dPmFcuuKALngePYA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY5PR11MB6260.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(136003)(366004)(396003)(39860400002)(6636002)(966005)(71200400001)(41300700001)(478600001)(54906003)(316002)(4326008)(2906002)(66446008)(66556008)(110136005)(64756008)(8676002)(38100700002)(66946007)(66476007)(76116006)(5660300002)(8936002)(52536014)(38070700005)(122000001)(33656002)(86362001)(53546011)(82960400001)(6506007)(107886003)(186003)(7696005)(83380400001)(9686003)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o4cc3SJP6awRd9XpiBp75UFgqaDvAcHecIu6h6ko5co/JEqBkzt3XwALe1SL?= =?us-ascii?Q?lP+BWypyT86Nl5W3/E103iIVpRonKSdpwIqf0hZzQ/AWyECO1l1sx9aZjowa?= =?us-ascii?Q?wOrAORcCNwObs4YbG6XT5GFZHQsaLKYQRJNk/7iALn8V6Q/XGflX9nSXy2Ad?= =?us-ascii?Q?gY18amo/FzasIAOnxHyCU42bp4KMeL847K+bvzi1lSIZRBeqcvn8DBIay3Iu?= =?us-ascii?Q?oeFRFhkdQ7DBcM8BRsp+efUUIGNkFCzGP2Ymsc9hps2O35EWdj+qorV+9yCx?= =?us-ascii?Q?1mLY2EwGYX/6zppU9P1zdVRbSjUuddK/HMvVSjJh/1tXmtXmwBFG0o0kuLMI?= =?us-ascii?Q?CCQZ641/D+BiXnOjQqUjU2NAZ2vzX09499D52ML45bu8/8uK97TQanOd/Ya6?= =?us-ascii?Q?EcjEcM0iFHTHIKpb8+nT6JC0WVuq1uo2PyBWLylgw1YxvjWzQqgvi0B2foxX?= =?us-ascii?Q?Pius0CnrLfux6newInoc40e+QSgtz6p2qCZrnaibXchYb7Ab9xFSTlRMTC6a?= =?us-ascii?Q?abJGiSK0PslO7B+tcoTHRvD+WrkYY8bSlnDgNe7ps7aaviaDTJ/MSobv2a96?= =?us-ascii?Q?8wgjkOqT/wP2s3jVWthcmCxrUXeY6+wku6Zb8qIbktDBWDW7fcuDHNph9qMV?= =?us-ascii?Q?2PLhj7a5oejAt2CWVPcKeJRvoSwS2SuO95k9Eklpxa9sZxjGwBEd02ZlfG8Y?= =?us-ascii?Q?0/btLSaHlT6Anhb+2zaBDfqJ7uK7PVLU9jJFsKPQo80WddaTQGBQktVGOi7V?= =?us-ascii?Q?+yvEAQlqwZbrP1qVlIHsUbLeBrZv7DmK6htv/B8LxfPCIiT8Vq1LvUc1qJsh?= =?us-ascii?Q?dMxO7a46aTvvWZTQkoly80s4wTjWCva+Jr4iEVBuwQOkbnGq1amAOMgzeEET?= =?us-ascii?Q?OR58QFWhTihpjyTOL4QeE+Yb2XEgs4uybUsFrWGGO+Zo7krynJW/4wyPv7lS?= =?us-ascii?Q?2n2h9YPuXsDOJr9qx/By6hyDYcg54Rk/W+yjlgaU4teUMP2MDuM1J1fFmzgs?= =?us-ascii?Q?LNefyFwmEfvJnOJL4QPSq5t4YTjY4VnCho7FrzzwtOLTxQMaa3Z8R2Zn/wtl?= =?us-ascii?Q?JGvbPgfCNAHlGaHDgwZ3VqUzBKBxl7Q7FelnjkOV3AIMgKrRUOH1WF6Gg+mV?= =?us-ascii?Q?lZuNyfPPqS9EpjvY7EBC4NqIKtfF3mVb4oXlYK7L+6CuUCR7Pak5vCeuS16b?= =?us-ascii?Q?PCBorC4kXNzh83CVFP3I84bwD+2bCi1+CDMfH8EU9P+jK6qiMG1KZQhgKwFm?= =?us-ascii?Q?Yoz8/HMs3oHSNsk3/0VMacWiajm1sK0d0BNOZdMkmcO6ltKhjYLi+5TpDJcG?= =?us-ascii?Q?5IGI7E880+C7gLY0uA3OLvkLJtxfKKqPN68/tsYzmVw3l0p6gfqPLWFevbgj?= =?us-ascii?Q?y3iDKEpu8w9a5UlwZCONWIZUSE8YrtKeDodN7NKD1qFpppvn0S91rmqo+LvM?= =?us-ascii?Q?FGHFXbul35ux595PEX3PVbtOZHW+gIivH+jdwCxYXyXer42O6c8ixT6viOkE?= =?us-ascii?Q?ElHtwS6ZQDtjG/Vgoq1FDs9HrGU4ysEpTpPYeS+HT+z8dznnlbDqOmIy4Dl4?= =?us-ascii?Q?6Lku4wUE0EdL/MQbUupiQNYRhH84s9WDumJzgungwlrBOTtdH7RNUlgSOhiT?= =?us-ascii?Q?oTH79SDrTp1lbxTQaz/S7PXl6pPzRoxo7xsunYJ0yTYI?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6260.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 762b832f-ab47-45a4-3d7e-08da7cb6d4ae X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2022 23:03:11.9802 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 56We8ZGbRp6GJ8M7QcZTN2oP5u9d8rhT4jD2vPboFEszlJlFrNZNcPwp1e6QziTwhenHmI4WI29hC23UCyUgLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4643 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Guo Dong -----Original Message----- From: devel@edk2.groups.io On Behalf Of kavya Sent: Thursday, August 11, 2022 12:08 AM To: devel@edk2.groups.io Cc: Sravanthi, K KavyaX ; Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Guo, Gua Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Return PciRootBridges instead= of NULL Return PciRootBridges instead of NULL and set PcdPciDisableBusEnumeration t= o FALSE when root bridge count is zero. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: Gua Guo Signed-off-by: Kavya --- UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c= b/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c index e1faa24ae7..fb76853072 100644 --- a/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c +++ b/UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c @@ -549,6 +549,7 @@ RetrieveRootBridgeInfoFromHob ( } =20 if (PciRootBridgeInfo->Count =3D=3D 0) { + PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE); return NULL; } =20 @@ -589,9 +590,8 @@ RetrieveRootBridgeInfoFromHob ( if (PciRootBridgeInfo->ResourceAssigned) { PcdSetBoolS (PcdPciDisableBusEnumeration, TRUE); } else { - DEBUG ((DEBUG_ERROR, "There is root bridge whose ResourceAssigned is F= ALSE\n")); + DEBUG ((DEBUG_INFO, "There is root bridge whose ResourceAssigned is=20 + FALSE\n")); PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE); - return NULL; } =20 return PciRootBridges; -- 2.30.2.windows.1