public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Guo Dong" <guo.dong@intel.com>
To: Benjamin Doron <benjamin.doron00@gmail.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH v2] UefiPayloadPkg: Add support for logging to CBMEM console
Date: Fri, 27 May 2022 17:08:17 +0000	[thread overview]
Message-ID: <CY5PR11MB6260B59EDFC8DB9D8DADA32B9ED89@CY5PR11MB6260.namprd11.prod.outlook.com> (raw)
In-Reply-To: <5710.1653669202637627313@groups.io>

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]


Thanks Benjamin for the explaining. I have no other comments.

Thanks,
Guo

From: Benjamin Doron <benjamin.doron00@gmail.com>
Sent: Friday, May 27, 2022 9:33 AM
To: Dong, Guo <guo.dong@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v2] UefiPayloadPkg: Add support for logging to CBMEM console

Hi Guo,
Dumping some of the coreboot table shows that some smaller entries/data (such as build information) are inserted inline while larger entries use the cb_cbmem_ref structure. This may answer why some users of FindCbTag() assign the returned pointer directly to their requested structure, while this library must first dereference the console's address.

For reasons unclear to me, cb_cbmem_ref->size == 0x0010, the size of the cb_cbmem_ref structure. Perhaps the structure of cb_cbmem_ref has been changed in the past and the size field informs coreboot payloads? Either way, it doesn't look like a useful field at the moment.

I will add comments and submit a v3. Is there anything else that needs some comments?

Regards,
Benjamin

[-- Attachment #2: Type: text/html, Size: 3152 bytes --]

      reply	other threads:[~2022-05-27 17:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-22 18:47 [PATCH v2] UefiPayloadPkg: Add support for logging to CBMEM console Benjamin Doron
2022-05-26  9:16 ` Sean Rhodes
2022-05-26 17:08   ` [edk2-devel] " Benjamin Doron
2022-05-27  5:59 ` Guo Dong
2022-05-27 16:33   ` Benjamin Doron
2022-05-27 17:08     ` Guo Dong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY5PR11MB6260B59EDFC8DB9D8DADA32B9ED89@CY5PR11MB6260.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox