Re: [edk2-devel] [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

["RichardHo [何明忠]" <richardho@ami.com>]

Hi Pedro/Abner,

UsbNetworkPkg provide the RNDIS/ECM/NCM device support that are implement form USB specification(we have other USB network device's driver to upstream).
It is not specific USB device. The driver could work on any platform. So, we create UsbNetworkPkg same as NetworkPkg in edk2 repo.

Currently, we have some Fixed PCDs in UsbNetworkPkg.dec. Can add it to MdeModulePkg.dec?
Which one is better for upstream from below rules?

#1: edk2-platforms/Features/UsbNetworkPkg
#2: edk2/MdeModulePkg/Bus/Usb/UsbNetwork
#3: edk2/UsbNetworkPkg

Thanks,
Richard

-----Original Message-----
From: Pedro Falcato <pedro.falcato@gmail.com>
Sent: 2023年4月11日 8:39 PM
To: devel@edk2.groups.io; rebecca@bsdio.com
Cc: Richard Ho (何明忠) <RichardHo@ami.com>; Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Michael D Kinney <michael.d.kinney@intel.com>; Michael Kubacki <mikuback@linux.microsoft.com>; Zhiguang Liu <zhiguang.liu@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Tinh Nguyen <tinhnguyen@os.amperecomputing.com>; Tony Lo (羅金松) <TonyLo@ami.com>; Marvin Häuser <mhaeuser@posteo.de>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v7 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

On Tue, Apr 11, 2023 at 1:31 PM Rebecca Cran <rebecca@bsdio.com> wrote:
> Given this is adding a new top-level package, I'd like to see a
> review/feedback from the TianoCore Stewards.

I would personally love to understand why this is being pushed as a top level package in edk2 when "supposedly" edk2-platforms/Features is the more correct approach here (as discussed with Sean, Nate a few months back).

Or is that hellscape only reserved for me? :v

--
Pedro
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.