Re: [edk2-devel] [PATCH v3 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

["RichardHo [何明忠]" <richardho@ami.com>]

Hi Rebecca,

Thanks for your response. We will fixed it next.

Thanks,
Richard

-----Original Message-----
From: Rebecca Cran <rebecca@bsdio.com>
Sent: 2023年2月16日 1:28 AM
To: devel@edk2.groups.io; Tony Lo (羅金松) <TonyLo@ami.com>; Richard Ho (何明忠) <RichardHo@ami.com>
Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Michael D Kinney <michael.d.kinney@intel.com>; Michael Kubacki <michael.kubacki@microsoft.com>; Zhiguang Liu <zhiguang.liu@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Dos Hsieh <doshsieh@ami.com>; Felix Polyudov <Felixp@ami.com>; Srini Narayana <SriniN@ami.com>; Harikrishna Doppalapudi <Harikrishnad@ami.com>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v3 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

[rebecca@bsdio.com appears similar to someone who previously sent you email, but may not be that person. Learn why this could be a risk at https://aka.ms/LearnAboutSenderIdentification ]

**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

It looks like the emails are still getting mangled: when I "View Source"
in Thunderbird I'm seeing "=" replaced with "=3D" for example.

Could you make sure you've run "py3 BaseTools\Scripts\SetupGit.py" to configure your edk2 repo? That should also cause a cover letter to be generated when you run "git format-patch" since I've noticed it's missing.

Also, it looks like the files have UNIX line endings. Could you convert them to DOS please? It would be nice if you could run the paches through
EDK2 CI either locally
(https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FHow-to-Build-With-Stuart&data=05%7C01%7CRichardHo%40ami.com%7C29cbc560717443d9fa4608db0f7a0233%7C27e97857e15f486cb58e86c2b3040f93%7C1%7C0%7C638120788951408230%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=mD4PiwecuPZWIzgjy7Ad%2Bkjf90R3tcpJNZjfbXdFw44%3D&reserved=0)
or by pushing them to a personal GitHub fork and opening a PR. For example, one issue the ECC tool will likely complain about is the header guard format:

 > +#ifndef EDKII_USB_ETHERNET_PROTOCOL_H  > +#define EDKII_USB_ETHERNET_PROTOCOL_H

While there shouldn't be leading underscrore, there _should_ be a trailing underscore.

--
Rebecca Cran

On 2/14/23 22:47, Tony Lo (羅金松) via groups.io wrote:
> +teams
>
> -----Original Message-----
> From: Richard Ho (何明忠) <RichardHo@ami.com>
> Sent: Wednesday, February 15, 2023 1:37 PM
> To: devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm
> <quic_llindhol@quicinc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Michael Kubacki
> <michael.kubacki@microsoft.com>; Zhiguang Liu
> <zhiguang.liu@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Tony
> Lo (羅金松) <TonyLo@ami.com>
> Subject: [PATCH v3 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices
> support
>
> This driver provides UEFI driver for USB RNDIS device
>
> Signed-off-by: Richard Ho <richardho@ami.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Reviewed-by: Tony Lo <tonylo@ami.com>
> ---
>   UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc    |    9 +
>   .../Config/UsbNetworkPkgComponentsDxe.inc.dsc |   20 +
>   .../Config/UsbNetworkPkgComponentsDxe.inc.fdf |   20 +
>   .../Config/UsbNetworkPkgDefines.inc.dsc       |   23 +
>   .../Protocol/EdkIIUsbEthernetProtocol.h       |  877 ++++++++
>   UsbNetworkPkg/NetworkCommon/ComponentName.c   |  263 +++
>   UsbNetworkPkg/NetworkCommon/DriverBinding.c   |  588 ++++++
>   UsbNetworkPkg/NetworkCommon/DriverBinding.h   |  266 +++
>   UsbNetworkPkg/NetworkCommon/NetworkCommon.inf |   49 +
>   UsbNetworkPkg/NetworkCommon/PxeFunction.c     | 1797 +++++++++++++++++
>   UsbNetworkPkg/ReadMe.md                       |   65 +
>   UsbNetworkPkg/ReleaseNotes.md                 |   11 +
>   UsbNetworkPkg/UsbNetworkPkg.dec               |   46 +
>   UsbNetworkPkg/UsbRndis/ComponentName.c        |  172 ++
>   UsbNetworkPkg/UsbRndis/UsbRndis.c             |  886 ++++++++
>   UsbNetworkPkg/UsbRndis/UsbRndis.h             |  586 ++++++
>   UsbNetworkPkg/UsbRndis/UsbRndis.inf           |   42 +
>   UsbNetworkPkg/UsbRndis/UsbRndisFunction.c     | 1714 ++++++++++++++++
>   18 files changed, 7434 insertions(+)
>   create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc
>   create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkgComponentsDxe.inc.dsc
>   create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkgComponentsDxe.inc.fdf
>   create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkgDefines.inc.dsc
>   create mode 100644 UsbNetworkPkg/Include/Protocol/EdkIIUsbEthernetProtocol.h
>   create mode 100644 UsbNetworkPkg/NetworkCommon/ComponentName.c
>   create mode 100644 UsbNetworkPkg/NetworkCommon/DriverBinding.c
>   create mode 100644 UsbNetworkPkg/NetworkCommon/DriverBinding.h
>   create mode 100644 UsbNetworkPkg/NetworkCommon/NetworkCommon.inf
>   create mode 100644 UsbNetworkPkg/NetworkCommon/PxeFunction.c
>   create mode 100644 UsbNetworkPkg/ReadMe.md
>   create mode 100644 UsbNetworkPkg/ReleaseNotes.md
>   create mode 100644 UsbNetworkPkg/UsbNetworkPkg.dec
>   create mode 100644 UsbNetworkPkg/UsbRndis/ComponentName.c
>   create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.c
>   create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.h
>   create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.inf
>   create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndisFunction.c

-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.