Re: [edk2-devel] [PATCH v2 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

["RichardHo [何明忠]" <richardho@ami.com>]

Hi Rebecca,

We will modify it in next patch.

Thanks,
Richard

-----Original Message-----
From: Rebecca Cran <rebecca@bsdio.com>
Sent: 2023年2月8日 12:14 AM
To: devel@edk2.groups.io; Richard Ho (何明忠) <RichardHo@ami.com>
Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Michael D Kinney <michael.d.kinney@intel.com>; Michael Kubacki <michael.kubacki@microsoft.com>; Zhiguang Liu <zhiguang.liu@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Tony Lo (羅金松) <TonyLo@ami.com>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v2 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

[rebecca@bsdio.com appears similar to someone who previously sent you email, but may not be that person. Learn why this could be a risk at https://aka.ms/LearnAboutSenderIdentification ]

**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

On 2/4/23 01:54, RichardHo [何明忠] via groups.io wrote:

> diff --git a/UsbNetworkPkg/Include/Protocol/EdkIIUsbEthernetProtocol.h
> b/UsbNetworkPkg/Include/Protocol/EdkIIUsbEthernetProtocol.h
> new file mode 100644
> index 0000000000..629c83e24e
> --- /dev/null
> +++ b/UsbNetworkPkg/Include/Protocol/EdkIIUsbEthernetProtocol.h
> @@ -0,0 +1,873 @@
> +/** @file
> +  Header file contains code for USB Ethernet Protocol
> +  definitions
> +
> +  Copyright (c) 2023, American Megatrends International LLC. All
> +rights reserved.<BR>
> +  SPDX-License-Identifier: BSD-2-Clause-Patent **/
> +
> +#ifndef _EDKII_USB_ETHERNET_PROTOCOL_H #define
> +_EDKII_USB_ETHERNET_PROTOCOL_H

The header guards shouldn't have a leading underscore, since such names are reserved for compiler use.

--
Rebecca Cran

-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.