From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in6.apple.com (mail-out6.apple.com [17.151.62.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C127821E49BA2 for ; Tue, 22 Aug 2017 10:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1503422495; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-transfer-encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Hsck4Inok6LV7DAuBgm9IcE3XSHlpTSBx0lWOfSoaQs=; b=YZfQH1DZwuUcSyQ0p7o+SmcG7g/f5zrfTzrNsVYc0z4o3onwbwNpc9yCEBdDdQ0X 5rt5LOU17mbHI1py+YXGeb6WKqCPwNeD8MgOTCh2tRTnbLfka5vNKAHZknrPJ5pR wMrqncBF33Z9dSjou6oBNYwGsr+idcdECP+tTaN1zemi43SNcEbNIHNxnGGxlEKe m1mpp5+VBogF1CEgtAOREciMVccTP7O38Fc6uy1WD/WemMwWRaT2KkgA18Q71DaQ MOv4x5kbQU3OP08TXQbEkXfhTDgq72lKvWJs08Kl4hRDvFlwLxwK9FGmACoPSX5i mToxxPsnLZgCbBxNAn7xFA==; Received: from relay22.apple.com (relay22.apple.com [17.171.128.103]) (using TLS with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail-in6.apple.com (Apple Secure Mail Relay) with SMTP id 27.EC.11091.E186C995; Tue, 22 Aug 2017 10:21:35 -0700 (PDT) X-AuditID: 11973e15-049ff70000002b53-c6-599c681e3331 Received: from ma1-mmpp-sz11.apple.com (ma1-mmpp-sz11.apple.com [17.171.128.33]) by relay22.apple.com (Apple SCV relay) with SMTP id A2.D8.07334.D186C995; Tue, 22 Aug 2017 10:21:34 -0700 (PDT) MIME-version: 1.0 Received: from [17.234.170.227] by ma1-mmpp-sz11.apple.com (Oracle Communications Messaging Server 8.0.1.2.20170621 64bit (built Jun 21 2017)) with ESMTPSA id <0OV300ES3K7UXBB0@ma1-mmpp-sz11.apple.com>; Tue, 22 Aug 2017 10:21:33 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish In-reply-to: Date: Tue, 22 Aug 2017 10:21:30 -0700 Cc: "Ni, Ruiyu" , "edk2-devel@lists.01.org" , "Dong, Eric" , "Wu, Hao A" , Jordan Justen , "Gao, Liming" , Mike Kinney , Laszlo Ersek , "Zeng, Star" Message-id: References: <20170820181557.28761-1-pcacjr@zytor.com> <734D49CCEBEEF84792F5B80ED585239D5B9F3CD8@SHSMSX104.ccr.corp.intel.com> To: Paulo Alcantara X-Mailer: Apple Mail (2.3273) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDLMWRmVeSWpSXmKPExsUiuLohXVc+Y06kwa3jshZ7Dh1lttj8Itji 6q1fTBY7rvWzWCw7toPFYsW9DewWHR3/mCz2vf7IaPGyZzW7xb5eawcuj8V7XjJ5dM/+x+Lx ft9VNo8TLV9YA1iiuGxSUnMyy1KL9O0SuDJ+Lz3AVvBRqKL5YQ9LA+Mfvi5GTg4JAROJ9W9f sIDYQgLrmCQmHWKCi288ydzFyAUUP8Qo8WvZfrAEr4CgxI/J94AaODiYBeQlDp6XBQkzC2hJ fH/UygJR/41RYtni2YwgCWEBcYl3ZzYxQ9guElMObQGLswkoS6yY/4EdxOYUsJVYdmwtWJxF QFXi1r47rCCDmAXeMEnceXCZFWKxjcTdZW9ZITZsYpSY9OItG0hCREBN4vKeu6wQZ8tK3Jp9 CexsCYEzbBLTnl9imsAoPAvJ5bMQLp+F5PIFjMyrGIVyEzNzdDPzzPQSCwpyUvWS83M3MYKi Z7qd6A7GM6usDjEKcDAq8fBaWM+JFGJNLCuuzD3EKM3BoiTO6799ZqSQQHpiSWp2ampBalF8 UWlOavEhRiYOTqkGxoM6vpd5QxY2HKz/tdPIvONA28nPgXdMTh3fsH9RyPptB2d9W21kH7OA p6GjoUFsVa/y8kkPMta66vF28XF5n/Msb++pOFjgHyViNOfx1Q+bungbHb3XJMpv/ebZPutC 0oOJQnvjBfcoZTFVVR4T9+hIvplgc+3MBY2gIN5jy49xv24zkPv/TYmlOCPRUIu5qDgRAEbN G+9/AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRmVeSWpSXmKPExsUiuLpBUVcuY06kwcLLzBZ7Dh1lttj8Itji 6q1fTBY7rvWzWCw7toPFYsW9DewWHR3/mCz2vf7IaPGyZzW7xb5eawcuj8V7XjJ5dM/+x+Lx ft9VNo8TLV9YA1iiuGxSUnMyy1KL9O0SuDJ+Lz3AVvBRqKL5YQ9LA+Mfvi5GTg4JAROJ9RtP MncxcnEICRxilPi1bD8TSIJXQFDix+R7LF2MHBzMAvISB8/LgoSZBbQkvj9qZYGo/8YosWzx bEaQhLCAuMS7M5uYIWwXiSmHtoDF2QSUJVbM/8AOYnMK2EosO7YWLM4ioCpxa98dVpBBzAJv mCTuPLjMCrHYRuLusresEBs2MUpMevGWDSQhIqAmcXnPXVaIs2Ulbs2+xDyBUWAWkmNnIRw7 C8mxCxiZVzEKFqXmJFYaGeklFhTkpOol5+duYoQEfPoOxiM3zQ4xCnAwKvHwWljPiRRiTSwr rswFBgcHs5IIr3wsUIg3JbGyKrUoP76oNCe1+BCjNAeLkjivRNHkSCGB9MSS1OzU1ILUIpgs EwenVANj7c1spTc3y0S2ejsvMOvWYL0s/2/t43nZ1l+OpnQr2Ylb2Ie117XeFFQ3Xvdo+6UV l84JWs2efGxxznb52f7r9G/r3rPdYsS7UyFyzeu62pN/p296yG+R/5d/U9bWB+tWxITE/kuf uLTlS8uyB0EPy38G756UVMuxkVHtxdNZamt2zZv8ap7PTCWW4oxEQy3mouJEAO3MnkB0AgAA Subject: Re: [PATCH v2 0/6] read-only UDF file system support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2017 17:19:02 -0000 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII > On Aug 22, 2017, at 6:14 AM, Paulo Alcantara wrote: > > Hi, > > I do apologize my late replies. At the moment, I'm only able to work on this during my free time. Thank you all for the reviews! > > FWIW, my comments below. > > On 8/20/2017 11:29 PM, Ni, Ruiyu wrote: >> Paulo, >> 1. Could you please run the ECC check tool (BaseTools\Source\Python\Ecc\) >> "CRC" might need to be replaced with "Crc". >> I also noticed some TAB key in file content. > > Sure. > >> 2. Your current implementation uses HARD_DRIVE_DEVICE_PATH. >> But with: >> SignatureType = SIGNATURE_TYPE_UDF >> MBRType = MBR_TYPE_PCAT >> Signature = * >> And later UdfDxe driver checks the SignatureType and MBRType. >> I am not sure if it would be better to put the definitions in UEFI Spec, >> since they are referenced by different modules. >> I also noticed you use PARTITION_TYPE_OTHER for PartitionInfo. >> When proposing to UEFI Spec, this also needs to be considered, >> for example, add PARTITION_TYPE_UDF to spec. > > Yes - I agree with you. My only concern is that UEFI specification doesn't either support UDF or there is any interest in supporting it, so by proposing an additional type for something that shouldn't be supported, might not work out. > > (Andrew, any thoughts?) > The enum space is owned by the UEFI spec and should never be extended outside the scope of the spec. Its not good to have an implementation running around that is not in a released spec, as it it is a future compatibility risk. Does the UDF actually start with a real MBR? If so is it possible to define a 32-bit MBR signature to indicate UDF. If not it should probably be a device path node like CD-ROM. You can all ways use the Vendor-Defined Media Device Path since it has GUID there is no risk of collision. Thanks, Andrew Fish > "PARTITION_TYPE_OTHER" is also used when creating EFI_PARTITION_INFO_PROTOCOL for CDROM "El Torito" partitions, so either we could follow the same approach, or propose creating two other types: e.g., PARTITION_TYPE_ELTORITO and PARTITION_TYPE_UDF. > >> 3. The driver model part looks good. > > Cool! Thanks for looking into that. > > Paulo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel