From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] IntelSiliconPkg IntelVTdDxe: use gEfiAcpi10TableGuid for ACPI 1.0
Date: Wed, 25 Oct 2017 09:58:51 +0000 [thread overview]
Message-ID: <D26E550E-68D4-4223-9A26-2B86448E149E@intel.com> (raw)
In-Reply-To: <1508921966-16768-1-git-send-email-star.zeng@intel.com>
reviewed by: jiewen.yao@intel.com
thank you!
Yao, Jiewen
> 在 2017年10月25日，下午4:59，Star Zeng <star.zeng@intel.com> 写道：
>
> According to definition (Acpi.h and MdePkg.dec),
> gEfiAcpiTableGuid = gEfiAcpi20TableGuid, and the code is trying
> to parse ACPI 2.0 first and then ACPI 1.0, but it uses
> gEfiAcpiTableGuid wrongly for ACPI 1.0, this patch is to fix it.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c | 2 +-
> IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c
> index 2456b0c48ff1..39b70a134e1e 100644
> --- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c
> +++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmarAcpiTable.c
> @@ -996,7 +996,7 @@ GetDmarAcpiTable (
> );
> if (EFI_ERROR (Status)) {
> Status = EfiGetSystemConfigurationTable (
> - &gEfiAcpiTableGuid,
> + &gEfiAcpi10TableGuid,
> &AcpiTable
> );
> }
> diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf
> index d45fd67964c9..fde33bb224ca 100644
> --- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf
> +++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.inf
> @@ -64,7 +64,7 @@ [LibraryClasses]
> [Guids]
> gEfiEventExitBootServicesGuid ## CONSUMES ## Event
> gEfiAcpi20TableGuid ## CONSUMES ## SystemTable
> - gEfiAcpiTableGuid ## CONSUMES ## SystemTable
> + gEfiAcpi10TableGuid ## CONSUMES ## SystemTable
>
> [Protocols]
> gEdkiiIoMmuProtocolGuid ## PRODUCES
> --
> 2.7.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-10-25 9:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 8:59 [PATCH] IntelSiliconPkg IntelVTdDxe: use gEfiAcpi10TableGuid for ACPI 1.0 Star Zeng
2017-10-25 9:58 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D26E550E-68D4-4223-9A26-2B86448E149E@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox