From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vib-mx01.apple.com (vib-mx01.apple.com [17.132.96.0]) by mx.groups.io with SMTP id smtpd.web10.57414.1684346460808098355 for ; Wed, 17 May 2023 11:01:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=pMZGHo4D; spf=pass (domain: apple.com, ip: 17.132.96.0, mailfrom: girim@apple.com) Received: from sg-mailsvcp-mta-lapp01.asia.apple.com (sg-mailsvcp-mta-lapp01.asia.apple.com [17.84.67.69]) by vb11p01nt-mxp01.apple.com (Oracle Communications Messaging Server 8.1.0.22.20230228 64bit (built Feb 28 2023)) with ESMTPS id <0RUT03P27E1JGQ20@vb11p01nt-mxp01.apple.com> for devel@edk2.groups.io; Wed, 17 May 2023 18:00:58 +0000 (GMT) X-Proofpoint-GUID: PrAhMhgMXyTE-csHTFCOydt6H7ra1hxM X-Proofpoint-ORIG-GUID: PrAhMhgMXyTE-csHTFCOydt6H7ra1hxM X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.573,18.0.942 definitions=2023-05-10_04:2023-05-05,2023-05-10 signatures=0 X-Proofpoint-Spam-Details: rule=interactive_user_notspam policy=interactive_user score=0 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305100142 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=20180706; bh=9+5929yk1BlcI7am/sRQECAeQ7F2USjUKm3eoRdPviE=; b=pMZGHo4D6IXCV1UFFLPr0e0+5ZmTnYQpkMM3oMcIXcco25R45mHHjH8DLkdh9Cv6Ygvl Ar9bvsLdUEFykf9EXcaDIDELK8llapjZejtJkGOmm7NVbe+CX1liGQ2P+ENYuU0arJOC IOpu/ewCt6Q3p+kid6fw94axfRR1NEwUXQDnBw0iuljqJB8wTICKkoXPIiRxqx8Dggvw IZUtIVbXssjuG+V/qCapCSpdyYLsuMih1LFjqvMQ6H0fXUxhMTFsfkr3Wl7Knuclvze/ NYIVp3Plf74lT8rHbxySJcbYRxJq4/UQkB4LoXJhHZaoelw/gv/Ssq4OAE0gNFfj2+Nq 4g== Received: from sg-mailsvcp-mmp-lapp02.asia.apple.com (sg-mailsvcp-mmp-lapp02.asia.apple.com [17.84.71.202]) by sg-mailsvcp-mta-lapp01.asia.apple.com (Oracle Communications Messaging Server 8.1.0.22.20230228 64bit (built Feb 28 2023)) with ESMTPS id <0RUT0072TE1FKU00@sg-mailsvcp-mta-lapp01.asia.apple.com>; Thu, 18 May 2023 02:00:54 +0800 (+08) Received: from process_milters-daemon.sg-mailsvcp-mmp-lapp02.asia.apple.com by sg-mailsvcp-mmp-lapp02.asia.apple.com (Oracle Communications Messaging Server 8.1.0.22.20230228 64bit (built Feb 28 2023)) id <0RUT00300DGUTI00@sg-mailsvcp-mmp-lapp02.asia.apple.com>; Thu, 18 May 2023 02:00:51 +0800 (+08) X-Va-A: X-Va-T-CD: 81ca60fce39c2560b6c4a7e5841f9b8f X-Va-E-CD: a9a0fcf73f6f6932df49ceaba034fe0d X-Va-R-CD: e3987c1439b248c7e6d4568e4363fb19 X-Va-ID: 657816c0-b338-40ee-8586-2690c43d4cb4 X-Va-CD: 0 X-V-A: X-V-T-CD: 81ca60fce39c2560b6c4a7e5841f9b8f X-V-E-CD: a9a0fcf73f6f6932df49ceaba034fe0d X-V-R-CD: e3987c1439b248c7e6d4568e4363fb19 X-V-ID: 05e47488-04b1-4845-9427-36a394f3a82c X-V-CD: 0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.573,18.0.957 definitions=2023-05-17_02:2023-05-17,2023-05-17 signatures=0 Received: from smtpclient.apple (unknown [17.233.167.59]) by sg-mailsvcp-mmp-lapp02.asia.apple.com (Oracle Communications Messaging Server 8.1.0.22.20230228 64bit (built Feb 28 2023)) with ESMTPSA id <0RUT006AEE1AOJ00@sg-mailsvcp-mmp-lapp02.asia.apple.com>; Thu, 18 May 2023 02:00:47 +0800 (+08) MIME-version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Subject: Re: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect From: "Giri Mudusuru" In-reply-to: Date: Wed, 17 May 2023 23:30:34 +0530 Cc: "devel@edk2.groups.io" , "Ni, Ray" , "Wang, Jian J" , "Gao, Liming" , Andrew Fish , Giri Mudusuru Message-id: References: <7ba00d73bd53c401b9fcd6fd4a3a79f9e43d9662.1683885276.git.girim@apple.com> To: "Wu, Hao A" X-Mailer: Apple Mail (2.3731.400.51.1.1) Content-type: text/plain; charset=us-ascii Content-transfer-encoding: quoted-printable > Please help to use %p for printing pointers. Thanks for approvals. To clarify the value is 64-bit capability register = value. Thanks, -Giri > On May 17, 2023, at 9:49 AM, Wu, Hao A wrote: >=20 > Thanks for the patch, inline comment below: >=20 >=20 >> -----Original Message----- >> From: Giri Mudusuru >> Sent: Friday, May 12, 2023 5:55 PM >> To: devel@edk2.groups.io >> Cc: Giri Mudusuru ; Wu, Hao A ; = Ni, >> Ray ; Wang, Jian J ; Gao, = Liming >> ; Andrew Fish >> Subject: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug >> print is incorrect >>=20 >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4394 >>=20 >> Fix DumpCapabilityReg() debug log to print 64 bit capability instead = of 32 bit >> pointer >>=20 >> Cc: Hao A Wu >> Cc: Ray Ni >> Cc: Jian J Wang >> Cc: Liming Gao >> Cc: Andrew Fish >> Signed-off-by: Giri Mudusuru >> --- >> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c >> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c >> index aab6815328..2e7497a89d 100644 >> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c >> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c >> @@ -30,7 +30,7 @@ DumpCapabilityReg ( >> // >>=20 >> // Dump Capability Data >>=20 >> // >>=20 >> - DEBUG ((DEBUG_INFO, " =3D=3D Slot [%d] Capability is 0x%x =3D=3D\n",= Slot, >> Capability)); >>=20 >> + DEBUG ((DEBUG_INFO, " =3D=3D Slot [%d] Capability is 0x%llx =3D=3D\n= ", Slot, >> *(UINT64 *)Capability)); >=20 >=20 > Please help to use %p for printing pointers. >=20 > Best Regards, > Hao Wu >=20 >=20 >>=20 >> DEBUG ((DEBUG_INFO, " Timeout Clk Freq %d%a\n", Capability- >>> TimeoutFreq, (Capability->TimeoutUnit) ? "MHz" : "KHz")); >>=20 >> DEBUG ((DEBUG_INFO, " Base Clk Freq %dMHz\n", Capability- >>> BaseClkFreq)); >>=20 >> DEBUG ((DEBUG_INFO, " Max Blk Len %dbytes\n", 512 * (1 << >> Capability->MaxBlkLen))); >>=20 >> -- >> 2.39.2 (Apple Git-144) >=20