* [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect @ 2023-05-12 9:54 Giri Mudusuru 2023-05-17 4:19 ` Wu, Hao A 0 siblings, 1 reply; 6+ messages in thread From: Giri Mudusuru @ 2023-05-12 9:54 UTC (permalink / raw) To: devel; +Cc: Giri Mudusuru, Hao A Wu, Ray Ni, Jian J Wang, Liming Gao, Andrew Fish REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4394 Fix DumpCapabilityReg() debug log to print 64 bit capability instead of 32 bit pointer Cc: Hao A Wu <hao.a.wu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Andrew Fish <afish@apple.com> Signed-off-by: Giri Mudusuru <girim@apple.com> --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c index aab6815328..2e7497a89d 100644 --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c @@ -30,7 +30,7 @@ DumpCapabilityReg ( // // Dump Capability Data // - DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%x ==\n", Slot, Capability)); + DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%llx ==\n", Slot, *(UINT64 *)Capability)); DEBUG ((DEBUG_INFO, " Timeout Clk Freq %d%a\n", Capability->TimeoutFreq, (Capability->TimeoutUnit) ? "MHz" : "KHz")); DEBUG ((DEBUG_INFO, " Base Clk Freq %dMHz\n", Capability->BaseClkFreq)); DEBUG ((DEBUG_INFO, " Max Blk Len %dbytes\n", 512 * (1 << Capability->MaxBlkLen))); -- 2.39.2 (Apple Git-144) ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect 2023-05-12 9:54 [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect Giri Mudusuru @ 2023-05-17 4:19 ` Wu, Hao A 2023-05-17 11:45 ` [edk2-devel] " Ard Biesheuvel 2023-05-17 18:00 ` Giri Mudusuru 0 siblings, 2 replies; 6+ messages in thread From: Wu, Hao A @ 2023-05-17 4:19 UTC (permalink / raw) To: Giri Mudusuru, devel@edk2.groups.io Cc: Ni, Ray, Wang, Jian J, Gao, Liming, Andrew Fish Thanks for the patch, inline comment below: > -----Original Message----- > From: Giri Mudusuru <girim@apple.com> > Sent: Friday, May 12, 2023 5:55 PM > To: devel@edk2.groups.io > Cc: Giri Mudusuru <girim@apple.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, > Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming > <gaoliming@byosoft.com.cn>; Andrew Fish <afish@apple.com> > Subject: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug > print is incorrect > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4394 > > Fix DumpCapabilityReg() debug log to print 64 bit capability instead of 32 bit > pointer > > Cc: Hao A Wu <hao.a.wu@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Jian J Wang <jian.j.wang@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Andrew Fish <afish@apple.com> > Signed-off-by: Giri Mudusuru <girim@apple.com> > --- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > index aab6815328..2e7497a89d 100644 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > @@ -30,7 +30,7 @@ DumpCapabilityReg ( > // > > // Dump Capability Data > > // > > - DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%x ==\n", Slot, > Capability)); > > + DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%llx ==\n", Slot, > *(UINT64 *)Capability)); Please help to use %p for printing pointers. Best Regards, Hao Wu > > DEBUG ((DEBUG_INFO, " Timeout Clk Freq %d%a\n", Capability- > >TimeoutFreq, (Capability->TimeoutUnit) ? "MHz" : "KHz")); > > DEBUG ((DEBUG_INFO, " Base Clk Freq %dMHz\n", Capability- > >BaseClkFreq)); > > DEBUG ((DEBUG_INFO, " Max Blk Len %dbytes\n", 512 * (1 << > Capability->MaxBlkLen))); > > -- > 2.39.2 (Apple Git-144) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect 2023-05-17 4:19 ` Wu, Hao A @ 2023-05-17 11:45 ` Ard Biesheuvel 2023-05-17 13:16 ` Wu, Hao A 2023-05-17 18:00 ` Giri Mudusuru 1 sibling, 1 reply; 6+ messages in thread From: Ard Biesheuvel @ 2023-05-17 11:45 UTC (permalink / raw) To: devel, hao.a.wu Cc: Giri Mudusuru, Ni, Ray, Wang, Jian J, Gao, Liming, Andrew Fish On Wed, 17 May 2023 at 06:19, Wu, Hao A <hao.a.wu@intel.com> wrote: > > Thanks for the patch, inline comment below: > > > > -----Original Message----- > > From: Giri Mudusuru <girim@apple.com> > > Sent: Friday, May 12, 2023 5:55 PM > > To: devel@edk2.groups.io > > Cc: Giri Mudusuru <girim@apple.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, > > Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming > > <gaoliming@byosoft.com.cn>; Andrew Fish <afish@apple.com> > > Subject: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug > > print is incorrect > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4394 > > > > Fix DumpCapabilityReg() debug log to print 64 bit capability instead of 32 bit > > pointer > > > > Cc: Hao A Wu <hao.a.wu@intel.com> > > Cc: Ray Ni <ray.ni@intel.com> > > Cc: Jian J Wang <jian.j.wang@intel.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Cc: Andrew Fish <afish@apple.com> > > Signed-off-by: Giri Mudusuru <girim@apple.com> Reviewed-by: Ard Biesheuvel <ardb@kernel.org> > > --- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > > index aab6815328..2e7497a89d 100644 > > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > > @@ -30,7 +30,7 @@ DumpCapabilityReg ( > > // > > > > // Dump Capability Data > > > > // > > > > - DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%x ==\n", Slot, > > Capability)); > > > > + DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%llx ==\n", Slot, > > *(UINT64 *)Capability)); > > > Please help to use %p for printing pointers. > Why? The point of this patch is that we are not interested in the pointer, only in the value that it points to. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect 2023-05-17 11:45 ` [edk2-devel] " Ard Biesheuvel @ 2023-05-17 13:16 ` Wu, Hao A 0 siblings, 0 replies; 6+ messages in thread From: Wu, Hao A @ 2023-05-17 13:16 UTC (permalink / raw) To: devel@edk2.groups.io, ardb@kernel.org Cc: Giri Mudusuru, Ni, Ray, Wang, Jian J, Gao, Liming, Andrew Fish > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard > Biesheuvel > Sent: Wednesday, May 17, 2023 7:46 PM > To: devel@edk2.groups.io; Wu, Hao A <hao.a.wu@intel.com> > Cc: Giri Mudusuru <girim@apple.com>; Ni, Ray <ray.ni@intel.com>; Wang, > Jian J <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; > Andrew Fish <afish@apple.com> > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC > capability debug print is incorrect > > On Wed, 17 May 2023 at 06:19, Wu, Hao A <hao.a.wu@intel.com> wrote: > > > > Thanks for the patch, inline comment below: > > > > > > > -----Original Message----- > > > From: Giri Mudusuru <girim@apple.com> > > > Sent: Friday, May 12, 2023 5:55 PM > > > To: devel@edk2.groups.io > > > Cc: Giri Mudusuru <girim@apple.com>; Wu, Hao A > <hao.a.wu@intel.com>; > > > Ni, Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; > > > Gao, Liming <gaoliming@byosoft.com.cn>; Andrew Fish > > > <afish@apple.com> > > > Subject: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability > debug > > > print is incorrect > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4394 > > > > > > Fix DumpCapabilityReg() debug log to print 64 bit capability instead > > > of 32 bit pointer > > > > > > Cc: Hao A Wu <hao.a.wu@intel.com> > > > Cc: Ray Ni <ray.ni@intel.com> > > > Cc: Jian J Wang <jian.j.wang@intel.com> > > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > > Cc: Andrew Fish <afish@apple.com> > > > Signed-off-by: Giri Mudusuru <girim@apple.com> > > Reviewed-by: Ard Biesheuvel <ardb@kernel.org> > > > > --- > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > > > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > > > index aab6815328..2e7497a89d 100644 > > > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > > > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > > > @@ -30,7 +30,7 @@ DumpCapabilityReg ( > > > // > > > > > > // Dump Capability Data > > > > > > // > > > > > > - DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%x ==\n", > > > Slot, Capability)); > > > > > > + DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%llx ==\n", > > > + Slot, > > > *(UINT64 *)Capability)); > > > > > > Please help to use %p for printing pointers. > > > > Why? The point of this patch is that we are not interested in the pointer, only > in the value that it points to. Thanks. Reviewed-by: Hao A Wu <hao.a.wu@intel.com> Best Regards, Hao Wu > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect 2023-05-17 4:19 ` Wu, Hao A 2023-05-17 11:45 ` [edk2-devel] " Ard Biesheuvel @ 2023-05-17 18:00 ` Giri Mudusuru 2023-05-29 4:53 ` Wu, Hao A 1 sibling, 1 reply; 6+ messages in thread From: Giri Mudusuru @ 2023-05-17 18:00 UTC (permalink / raw) To: Wu, Hao A Cc: devel@edk2.groups.io, Ni, Ray, Wang, Jian J, Gao, Liming, Andrew Fish, Giri Mudusuru > Please help to use %p for printing pointers. Thanks for approvals. To clarify the value is 64-bit capability register value. Thanks, -Giri > On May 17, 2023, at 9:49 AM, Wu, Hao A <hao.a.wu@intel.com> wrote: > > Thanks for the patch, inline comment below: > > >> -----Original Message----- >> From: Giri Mudusuru <girim@apple.com> >> Sent: Friday, May 12, 2023 5:55 PM >> To: devel@edk2.groups.io >> Cc: Giri Mudusuru <girim@apple.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, >> Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming >> <gaoliming@byosoft.com.cn>; Andrew Fish <afish@apple.com> >> Subject: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug >> print is incorrect >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4394 >> >> Fix DumpCapabilityReg() debug log to print 64 bit capability instead of 32 bit >> pointer >> >> Cc: Hao A Wu <hao.a.wu@intel.com> >> Cc: Ray Ni <ray.ni@intel.com> >> Cc: Jian J Wang <jian.j.wang@intel.com> >> Cc: Liming Gao <gaoliming@byosoft.com.cn> >> Cc: Andrew Fish <afish@apple.com> >> Signed-off-by: Giri Mudusuru <girim@apple.com> >> --- >> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c >> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c >> index aab6815328..2e7497a89d 100644 >> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c >> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c >> @@ -30,7 +30,7 @@ DumpCapabilityReg ( >> // >> >> // Dump Capability Data >> >> // >> >> - DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%x ==\n", Slot, >> Capability)); >> >> + DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%llx ==\n", Slot, >> *(UINT64 *)Capability)); > > > Please help to use %p for printing pointers. > > Best Regards, > Hao Wu > > >> >> DEBUG ((DEBUG_INFO, " Timeout Clk Freq %d%a\n", Capability- >>> TimeoutFreq, (Capability->TimeoutUnit) ? "MHz" : "KHz")); >> >> DEBUG ((DEBUG_INFO, " Base Clk Freq %dMHz\n", Capability- >>> BaseClkFreq)); >> >> DEBUG ((DEBUG_INFO, " Max Blk Len %dbytes\n", 512 * (1 << >> Capability->MaxBlkLen))); >> >> -- >> 2.39.2 (Apple Git-144) > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect 2023-05-17 18:00 ` Giri Mudusuru @ 2023-05-29 4:53 ` Wu, Hao A 0 siblings, 0 replies; 6+ messages in thread From: Wu, Hao A @ 2023-05-29 4:53 UTC (permalink / raw) To: Giri Mudusuru Cc: devel@edk2.groups.io, Ni, Ray, Wang, Jian J, Gao, Liming, Andrew Fish Merged via: PR - https://github.com/tianocore/edk2/pull/4439 Commit - https://github.com/tianocore/edk2/commit/e1f5c6249af08c1df2c6257e4bb6abbf6134318c Best Regards, Hao Wu > -----Original Message----- > From: Giri Mudusuru <girim@apple.com> > Sent: Thursday, May 18, 2023 2:01 AM > To: Wu, Hao A <hao.a.wu@intel.com> > Cc: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Wang, Jian J > <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; > Andrew Fish <afish@apple.com>; Giri Mudusuru <girim@apple.com> > Subject: Re: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability > debug print is incorrect > > > Please help to use %p for printing pointers. > Thanks for approvals. To clarify the value is 64-bit capability register value. > > Thanks, > -Giri > > > On May 17, 2023, at 9:49 AM, Wu, Hao A <hao.a.wu@intel.com> wrote: > > > > Thanks for the patch, inline comment below: > > > > > >> -----Original Message----- > >> From: Giri Mudusuru <girim@apple.com> > >> Sent: Friday, May 12, 2023 5:55 PM > >> To: devel@edk2.groups.io > >> Cc: Giri Mudusuru <girim@apple.com>; Wu, Hao A > <hao.a.wu@intel.com>; > >> Ni, Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; > >> Gao, Liming <gaoliming@byosoft.com.cn>; Andrew Fish > <afish@apple.com> > >> Subject: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability > debug > >> print is incorrect > >> > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4394 > >> > >> Fix DumpCapabilityReg() debug log to print 64 bit capability instead > >> of 32 bit pointer > >> > >> Cc: Hao A Wu <hao.a.wu@intel.com> > >> Cc: Ray Ni <ray.ni@intel.com> > >> Cc: Jian J Wang <jian.j.wang@intel.com> > >> Cc: Liming Gao <gaoliming@byosoft.com.cn> > >> Cc: Andrew Fish <afish@apple.com> > >> Signed-off-by: Giri Mudusuru <girim@apple.com> > >> --- > >> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > >> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > >> index aab6815328..2e7497a89d 100644 > >> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > >> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > >> @@ -30,7 +30,7 @@ DumpCapabilityReg ( > >> // > >> > >> // Dump Capability Data > >> > >> // > >> > >> - DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%x ==\n", Slot, > >> Capability)); > >> > >> + DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%llx ==\n", > >> + Slot, > >> *(UINT64 *)Capability)); > > > > > > Please help to use %p for printing pointers. > > > > Best Regards, > > Hao Wu > > > > > >> > >> DEBUG ((DEBUG_INFO, " Timeout Clk Freq %d%a\n", Capability- > >>> TimeoutFreq, (Capability->TimeoutUnit) ? "MHz" : "KHz")); > >> > >> DEBUG ((DEBUG_INFO, " Base Clk Freq %dMHz\n", Capability- > >>> BaseClkFreq)); > >> > >> DEBUG ((DEBUG_INFO, " Max Blk Len %dbytes\n", 512 * (1 << > >> Capability->MaxBlkLen))); > >> > >> -- > >> 2.39.2 (Apple Git-144) > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-29 4:53 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-05-12 9:54 [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect Giri Mudusuru 2023-05-17 4:19 ` Wu, Hao A 2023-05-17 11:45 ` [edk2-devel] " Ard Biesheuvel 2023-05-17 13:16 ` Wu, Hao A 2023-05-17 18:00 ` Giri Mudusuru 2023-05-29 4:53 ` Wu, Hao A
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox