From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in4.apple.com (mail-out4.apple.com [17.151.62.26]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 24E221A1E45 for ; Tue, 13 Sep 2016 10:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1473788708; x=2337702308; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-transfer-encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/guBuX4eTLpavrGEIcC09LNYo6BOvXetaMlFkBl9l2U=; b=oxzAUDesaecgQBCZb/SPF62RUp1xwqGdETsXFY3sX0VYdZZlKrTeRg1q4/WgQ6x4 VQdH/g0EYLxnAC2ybp3DKTyOJlcscMHF7Nspwrn6plsZWpgA5b59sDsQIEoakKmA IXeWAkfq9+K+XtzVbie8bQtOu7VLMZtHYjiuOzB+X4hEsztoeTnsNCXuy6f8l3yi kSvw3nyym3M0uaNhTixwIW78ihyemdNPjDYejOmbx8czwIhv+PYP03HVEhTGlC7+ k8FR6UlThlAxszG9zCwSNmIqASkvAqiDiezmiUnXRXps3lUm8O3EWltDw/YisTtP z25NfE2D+XLyZtI4c3rOyA==; Received: from relay6.apple.com (relay6.apple.com [17.128.113.90]) by mail-in4.apple.com (Apple Secure Mail Relay) with SMTP id B1.35.07433.42B38D75; Tue, 13 Sep 2016 10:45:08 -0700 (PDT) X-AuditID: 11973e12-f79b16d000001d09-be-57d83b249de3 Received: from nwk-mmpp-sz13.apple.com (nwk-mmpp-sz13.apple.com [17.128.115.216]) by relay6.apple.com (Apple SCV relay) with SMTP id E5.98.23613.42B38D75; Tue, 13 Sep 2016 10:45:08 -0700 (PDT) MIME-version: 1.0 Received: from da0601a-dhcp140.apple.com ([17.226.15.140]) by nwk-mmpp-sz13.apple.com (Oracle Communications Messaging Server 8.0.1.1.0 64bit (built Jun 15 2016)) with ESMTPSA id <0ODG00IVTEN8MY20@nwk-mmpp-sz13.apple.com>; Tue, 13 Sep 2016 10:45:08 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish In-reply-to: <1473787620-26953-1-git-send-email-ard.biesheuvel@linaro.org> Date: Tue, 13 Sep 2016 10:45:07 -0700 Cc: edk2-devel@lists.01.org, leif.lindholm@linaro.org Message-id: References: <1473787620-26953-1-git-send-email-ard.biesheuvel@linaro.org> To: Ard Biesheuvel X-Mailer: Apple Mail (2.3112) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsUi2FAYpatifSPc4O4afYv/H3YzWuw5dJTZ 4tPuPSwOzB53ru1h8+ie/Y8lgCmKyyYlNSezLLVI3y6BK+Nw33fWgo9cFa1757E2MG7n6GLk 5JAQMJE4v34OG4QtJnHh3nogm4tDSGAvo8S7ln9ADgdY0fVfnhDxQ4wSLW1HmUEaeAUEJX5M vscCUsMsIC9x8LwsSJhZQEvi+6NWFoj6HiaJ3c96WEESwgLiEu/ObGKGsKMk1m+eygRiswko S6yY/4EdZA6ngJfE2TlOIGEWAVWJP5evMUHMNJXYfHQuG8RaG4kTna/ZQWwhAU+J1RNeM4O0 igjoSbR0mUG8Iiuxb8MCsFckBHawSWxfM5dpAqPILCRXz0K4ehaSqxcwMq9iFMpNzMzRzcwz 0UssKMhJ1UvOz93ECAr76XZCOxhPrbI6xCjAwajEwxvw43q4EGtiWXFl7iFGaQ4WJXHepYFA IYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYwLC9kT3Wa/LsriFT6iF7frwEdj/65zK0W6/rOe 09sT6RTZtUVFLMl5TsJ6wZvHNvXcUYvq7Dx38/sRiairjqrdqT+3n7w4ZdZxHx+XhbIPvDiT T1YsOSJoUS/RojjtzPOX0+94l0xhWv1tj9xqG9VXFrOZLqY9k/vqf+/1K6vLL2p81yYzfJFX YinOSDTUYi4qTgQAU1v7alwCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphkeLIzCtJLcpLzFFi42IRbCi+oatifSPc4O4DLYv/H3YzWuw5dJTZ 4tPuPSwOzB53ru1h8+ie/Y8lgCmKyyYlNSezLLVI3y6BK+Nw33fWgo9cFa1757E2MG7n6GLk 4JAQMJG4/suzi5ETyBSTuHBvPVsXIxeHkMAhRomWtqPMIAleAUGJH5PvsYDUMwvISxw8LwsS ZhbQkvj+qJUFor6HSWL3sx5WkISwgLjEuzObmCHsKIn1m6cygdhsAsoSK+Z/YAeZwyngJXF2 jhNImEVAVeLP5WtMEDNNJTYfncsGsdZG4kTna3YQW0jAU2L1hNfMIK0iAnoSLV1mECfLSuzb sIBtAqPgLCSHzkI4dBaSQxcwMq9iFChKzUmsNNNLLCjISdVLzs/dxAgO08KoHYwNy60OMQpw MCrx8Ab8uB4uxJpYVlyZCwwJDmYlEd5qqxvhQrwpiZVVqUX58UWlOanFhxiTgc6fyCwlmpwP jKG8knhDExMDE2NjM2NjcxNz0oSVxHml1IC2CqQnlqRmp6YWpBbBbGHi4JRqYJS5veNN59fJ G+wSchekz1zLrPbYaME2hs3/w5nCFZcLB5q+4z4rvevBwZnprwr5Pz430jvEUFrD8izb8PWC Tdl8aqF1K59xvW/alWTv9jAx56jYY8O0lk+vVnA4JT0V2MS9kDP+2t00VoaEC7kfdIPZXCb7 vkhxse/vm9XBkjzD3WTOQgWRZUosxRmJhlrMRcWJAIj7jHKXAgAA Subject: Re: [PATCH 2/2] ArmPkg/AsmMacroIoLib: force word alignment for functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2016 17:45:09 -0000 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII > On Sep 13, 2016, at 10:27 AM, Ard Biesheuvel wrote: > > Without an explicit .align directive, the Clang assembler defaults to > no alignment, which may result in instructions appearing misaligned in > the final executable. So use word alignment in all cases. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > ArmPkg/Include/AsmMacroIoLib.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ArmPkg/Include/AsmMacroIoLib.h b/ArmPkg/Include/AsmMacroIoLib.h > index fb73ea9a4694..5e4de1f269c8 100644 > --- a/ArmPkg/Include/AsmMacroIoLib.h > +++ b/ArmPkg/Include/AsmMacroIoLib.h > @@ -56,6 +56,7 @@ > .global Name ; \ > .section #Section, "ax" ; \ > .type Name, %function ; \ > + .align 2 ; \ Ard, I've been burned in the past by as .align is bytes or power of 2 based on what the native assembler defaults to (over simplification). I'm not sure if that issues exists in the ARM world? Thanks, Andrew Fish > Name: > > #define ASM_FUNC(Name) _ASM_FUNC(ASM_PFX(Name), .text. ## Name) > -- > 2.7.4 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel