From: "Alejandro Vallejo via groups.io" <alejandro.vallejo=cloud.com@groups.io>
To: "Gerd Hoffmann" <kraxel@redhat.com>,
"Anthony PERARD" <anthony@xenproject.com>
Cc: <devel@edk2.groups.io>,
"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
"Jiewen Yao" <jiewen.yao@intel.com>
Subject: Re: [edk2-devel] [PATCH] OvmfPkg: Set PcdCpuMaxLogicalProcessorNumber in OvmfXen
Date: Fri, 28 Jun 2024 15:25:44 +0100 [thread overview]
Message-ID: <D2BPX1YCQBB0.3RQ3DZ46TF9LR@cloud.com> (raw)
In-Reply-To: <wfb7agedpzvqtibz7xxhgyizjk5wxpykpofah72z6b2iquoyyr@mroqha2inwa3>
On Thu Apr 25, 2024 at 2:58 PM BST, Gerd Hoffmann wrote:
> Hi,
>
> > It's a bit more complicated than setting it at build time, but we can
> > always ask Xen how many vcpu we have and set the PCD accordingly. This
> > is something that can happen in OvmfPkg/XenPlatformPei module.
>
> Exactly.
>
> > But to be honest, I don't know if it's worth it, because I don't know the
> > downside of having a higher value for PcdCpuMaxLogicalProcessorNumber.
>
> Well, the downside is that you have to keep ovmf and xen in sync
> manually. Your call. If you prefer to do it that way I have no
> objections, just wanted point out the alternative approach.
>
> take care,
> Gerd
FYI, I've created a Xen Gitlab ticket to expose the maximum number of vCPUs as
discussed. It shoudn't be hard to expose the information in the Xen-specific
CPUID leaves at 0x4000000X (they are visible even with Viridian enabled, so that
should be fine).
I'll re-send a runtime version of this patch based on that information after
the required CPUID extension is in place.
https://gitlab.com/xen-project/xen/-/issues/191
Cheers,
Alejandro
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119727): https://edk2.groups.io/g/devel/message/119727
Mute This Topic: https://groups.io/mt/105721898/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-06-28 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 13:36 [edk2-devel] [PATCH] OvmfPkg: Set PcdCpuMaxLogicalProcessorNumber in OvmfXen Alejandro Vallejo via groups.io
2024-04-25 7:31 ` Gerd Hoffmann
2024-04-25 10:42 ` Alejandro Vallejo via groups.io
2024-04-25 10:59 ` Anthony PERARD via groups.io
2024-04-25 13:58 ` Gerd Hoffmann
2024-06-28 14:25 ` Alejandro Vallejo via groups.io [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D2BPX1YCQBB0.3RQ3DZ46TF9LR@cloud.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox