From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 427C821D046AA for ; Sun, 24 Sep 2017 18:01:43 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2017 18:04:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,434,1500966000"; d="scan'208";a="1223169527" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 24 Sep 2017 18:04:53 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Sep 2017 18:04:53 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Sep 2017 18:04:53 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Mon, 25 Sep 2017 09:04:51 +0800 From: "Wang, Jian J" To: Laszlo Ersek , "edk2-devel@lists.01.org" CC: "Zeng, Star" , "Dong, Eric" , "Yao, Jiewen" , "Kinney, Michael D" , "Justen, Jordan L" , "Wolman, Ayellet" Thread-Topic: [PATCH v2 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing Thread-Index: AQHTM5j/5qMZ9Z+j4kK5PXSeKKfJFKLAgcQAgARKWZA= Date: Mon, 25 Sep 2017 01:04:50 +0000 Message-ID: References: <20170921052032.13652-1-jian.j.wang@intel.com> <20170921052032.13652-7-jian.j.wang@intel.com> <6ed8b38e-3387-e3a1-972f-5922470ed4c7@redhat.com> <27af5dab-0c14-1c8b-1e2e-f08772471d06@redhat.com> In-Reply-To: <27af5dab-0c14-1c8b-1e2e-f08772471d06@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 01:01:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 WW91J3JlIHJpZ2h0IHRoYXQgdGhlcmUncyBubyBzdWNoIG5lZWQuIEkganVzdCBzYXcgdGhhdCB0 aGlzIGRyaXZlciBpcyBsb2FkZWQNCmJlZm9yZSBFbmRPZkR4ZSBidXQgbWlzc2VkIHRoZSBmYWN0 IHRoYXQgaXQncyBhY3R1YWxseSBzdGFydGVkIGFmdGVyIHRoYXQuDQpTbyBCSVQ3IG9mIFBjZE51 bGxQb2ludGVyRGV0ZWN0aW9uUHJvcGVydHlNYXNrIGlzIGVub3VnaC4NCg0KQW5kIHRoYW5rcyBh IGxvdCBmb3Igb3RoZXIgZmVlZGJhY2tzIGluIGFub3RoZXIgZW1haWxzLCBlc3BlY2lhbGx5IGZv ciB0aGUgDQpjYXRjaGluZyBvZiBwb3RlbnRpYWwgYXR0cmlidXRlcyBvdmVycmlkZGVuIGlzc3Vl LCB3aGljaCBhbHNvIGV4aXN0cyBpbiBvdGhlciANCnBhcnQgb2YgY29kZS4gDQoNCj4gLS0tLS1P cmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogTGFzemxvIEVyc2VrIFttYWlsdG86bGVyc2Vr QHJlZGhhdC5jb21dDQo+IFNlbnQ6IEZyaWRheSwgU2VwdGVtYmVyIDIyLCAyMDE3IDExOjI5IFBN DQo+IFRvOiBXYW5nLCBKaWFuIEogPGppYW4uai53YW5nQGludGVsLmNvbT47IGVkazItZGV2ZWxA bGlzdHMuMDEub3JnDQo+IENjOiBaZW5nLCBTdGFyIDxzdGFyLnplbmdAaW50ZWwuY29tPjsgRG9u ZywgRXJpYyA8ZXJpYy5kb25nQGludGVsLmNvbT47IFlhbywNCj4gSmlld2VuIDxqaWV3ZW4ueWFv QGludGVsLmNvbT47IEtpbm5leSwgTWljaGFlbCBEDQo+IDxtaWNoYWVsLmQua2lubmV5QGludGVs LmNvbT47IEp1c3RlbiwgSm9yZGFuIEwgPGpvcmRhbi5sLmp1c3RlbkBpbnRlbC5jb20+Ow0KPiBX b2xtYW4sIEF5ZWxsZXQgPGF5ZWxsZXQud29sbWFuQGludGVsLmNvbT4NCj4gU3ViamVjdDogUmU6 IFtQQVRDSCB2MiA2LzZdIE92bWZQa2cvUWVtdVZpZGVvRHhlOiBCeXBhc3MgTlVMTCBwb2ludGVy DQo+IGRldGVjdGlvbiBkdXJpbmcgVkJFIFNISU0gaW5zdGFsbGluZw0KPiANCj4gT24gMDkvMjIv MTcgMTM6NTAsIExhc3psbyBFcnNlayB3cm90ZToNCj4gPiBUaGlzIHBhdGNoIGxvb2tzIGdyZWF0 IHRvIG1lLCBJIHdvdWxkIGxpa2UgdG8gcmVxdWVzdCBhIGZldyBzbWFsbA0KPiA+IHVwZGF0ZXM6 DQo+ID4NCj4gPiBPbiAwOS8yMS8xNyAwNzoyMCwgSmlhbiBKIFdhbmcgd3JvdGU6DQo+ID4+IFFl bXVWaWRlb0R4ZSBkcml2ZXIgd2lsbCBpbnN0YWxsIFZCRSBTSElNIGludG8gcGFnZSAwLiBJZiBO VUxMIHBvaW50ZXINCj4gPg0KPiA+ICgxKSBwbGVhc2UgcmVwbGFjZSB0aGUgd29yZCAiaW5zdGFs bCIgd2l0aCAibGluayIuDQo+ID4NCj4gPiBUaGUgVkJFIFNoaW0gaXMgdGVjaG5pY2FsbHkgaW5z dGFsbGVkIGludG8gdGhlICJyZWFsLW1vZGUiIEMgc2VnbWVudCwNCj4gPiBvbmx5IHRoZSBpbnQg MHgxMCB2ZWN0b3IgbGl2ZXMgaW4gcGFnZSAwLg0KPiA+DQo+ID4+IGRldGVjdGlvbiBpcyBlbmFi bGVkLCB0aGlzIGRyaXZlciB3aWxsIGZhaWwgdG8gbG9hZC4gTlVMTCBwb2ludGVyIGRldGVjdGlv bg0KPiA+PiBieXBhc3NpbmcgY29kZSBpcyBhZGRlZCB0byBwcmV2ZW50IHN1Y2ggcHJvYmxlbSBk dXJpbmcgYm9vdC4NCj4gPj4NCj4gPj4gUGxlYXNlIG5vdGUgdGhhdCBXaW5kb3dzIDcgd2lsbCB0 cnkgdG8gYWNjZXNzIFZCRSBTSElNIGR1cmluZyBib290IGlmIGl0J3MNCj4gPj4gaW5zdGFsbGVk LCBhbmQgdGhlbiBjYXVzZSBib290IGZhaWx1cmUuIFRoaXMgY2FuIGJlIGZpeGVkIGJ5IHNldHRp bmcgQklUNw0KPiA+PiBvZiBQY2ROdWxsUG9pbnRlckRldGVjdGlvblByb3BlcnR5TWFzayB0byBk aXNhYmxlIE5VTEwgcG9pbnRlciBkZXRlY3Rpb24NCj4gPj4gYWZ0ZXIgRW5kT2ZEeGUuIEFzIGZh ciBhcyB3ZSBrbm93LCB0aGVyZSdzIG5vIG90aGVyIE9TcyBoYXMgc3VjaCBpc3N1ZS4NCj4gPg0K PiA+IFRoaXMgaXMgbm90IGEgcmVxdWVzdCwganVzdCBhIGNvbW1lbnQ6IEkgdmVyaWZpZWQgdGhl IGRlZmF1bHQgdmFsdWUgaW4NCj4gPiB0aGUgLmRlYywgYW5kIEkgc2VlIGl0IGlzIDAuIFNvIHRo ZXJlJ3Mgbm8gbmVlZCB0byBwb3N0IGFuIGFkZGl0aW9uYWwNCj4gPiBwYXRjaCBmb3IgdGhlIE9W TUYgRFNDIGZpbGVzLCBpbiBvcmRlciB0byBzZXQgQklUNy4NCj4gDQo+IEFjdHVhbGx5LCBsZXQg bWUgdGFrZSBhIHN0ZXAgYmFjaywgYW5kIHJlLXRoaW5rIHRoZSBuZWNlc3NpdHkgb2YgYWxsDQo+ IHRoaXMgd29yayBmb3IgUWVtdVZpZGVvRHhlIQ0KPiANCj4gVGhlIGZhY3RzIGFyZToNCj4gDQo+ ICgxKSBUaGUgKm9ubHkqIHB1cnBvc2Ugb2YgdGhlIFZCRSBTaGltIGlzIHRvIGFsbG93IFdpbmRv d3MgNyB0byBib290IGluDQo+IHB1cmUgVUVGSSBtb2RlIChpLmUuIHdpdGhvdXQgYSBDU00pLg0K PiANCj4gKDIpIElmIEkgdW5kZXJzdGFuZCBjb3JyZWN0bHksIHlvdSBndXlzIGhhdmUgdmVyaWZp ZWQgdGhhdCBXaW5kb3dzIDcNCj4gY2Fubm90IGJvb3Qgd2l0aCB0aGUgcGFnZTAgcHJvdGVjdGlv biBlbmFibGVkLCAqcmVnYXJkbGVzcyogb2Ygd2hhdCB3ZQ0KPiBkbyBpbiBRZW11VmlkZW9EeGUu IENhbiB5b3UgY29uZmlybSB0aGlzIHBsZWFzZT8NCj4gDQo+IFdpdGggdGhlIGFib3ZlIGluIG1p bmQsIGxldCdzIGNvbnNpZGVyIHRoZSBlZmZlY3RzIG9mIHRoZQ0KPiAiUGNkTnVsbFBvaW50ZXJE ZXRlY3Rpb25Qcm9wZXJ0eU1hc2siIGJpdHM6DQo+IA0KPiAqIEJJVDAgY2xlYXI6DQo+ICAgLSBU aGUgcGFnZTAgcHJvdGVjdGlvbiBpcyBjb21wbGV0ZWx5IGRpc2FibGVkLg0KPiAgIC0gVGhpcyBw YXRjaCBkb2VzIG5vdGhpbmcsIGluIGVmZmVjdC4NCj4gICAtIFRoZSBWQkUgU2hpbSB3b3Jrcy4N Cj4gICAtIFdpbmRvd3MgNyBib290cy4NCj4gDQo+ICogQklUMCBzZXQsIEJJVDcgYWxzbyBzZXQ6 DQo+ICAgLSBUaGUgcGFnZTAgcHJvdGVjdGlvbiBpcyBkaXNhYmxlZCBpbiB0aGUgRFhFIGNvcmUg YXQgdGhlIGVuZCBvZiBEWEUuDQo+ICAgLSBUaGlzIHBhdGNoIGRvZXMgbm90aGluZywgaW4gZWZm ZWN0Lg0KPiAgIC0gVGhlIFZCRSBTaGltIHdvcmtzLCBiZWNhdXNlIGl0IGlzIGEgVUVGSSBkcml2 ZXIsIGFuZCBpdCBjb25uZWN0cyBpdHMNCj4gICAgIGRldmljZXMgKGFuZCBpbnN0YWxscyB0aGUg c2hpbSkgYWZ0ZXIgRW5kLW9mLUR4ZSwgYXQgd2hpY2ggcG9pbnQNCj4gICAgIHBhZ2UwIHByb3Rl Y3Rpb24gaXMgbm8gbG9uZ2VyIGluIGVmZmVjdC4NCj4gICAtIFdpbmRvd3MgNyBib290cyBmaW5l LCBhZ2FpbiBiZWNhdXNlIGl0IGlzIGxvYWRlZCBhZnRlciBFbmQtb2YtRHhlLg0KPiANCj4gKiBC SVQwIHNldCwgQklUNyBjbGVhcjoNCj4gICAtIFRoZSBwYWdlMCBwcm90ZWN0aW9uIGlzIG5ldmVy IGRpc2FibGVkIHVudGlsIHRoZSBPUyAobG9hZGVyKQ0KPiAgICAgaW5zdGFsbHMgaXRzIG93biBw YWdlIHRhYmxlcy4NCj4gICAtIFRoaXMgcGF0Y2ggZW5hYmxlcyB0aGUgVkJFIFNoaW0gdG8gd29y aywgYnkgdGVtcG9yYXJpbHkgZGlzYWJsaW5nDQo+ICAgICBwYWdlMCBwcm90ZWN0aW9uLg0KPiAg IC0gSG93ZXZlciwgV2luZG93cyA3IHdpbGwgZmFpbCB0byBib290IG5vbmV0aGVsZXNzLCBiZWNh dXNlIGl0IGNhbm5vdA0KPiAgICAgY29wZSB3aXRoIHBhZ2UwIHByb3RlY3Rpb24uIChUaGlzIGlz IGZhY3QgKDIpLikNCj4gDQo+IE5vdywgaWYgeW91IGNvbnNpZGVyIGZhY3QgKDEpIGFzIHdlbGw6 IGdpdmVuIHRoYXQgV2luZG93cyA3IGNhbm5vdCBib290DQo+IHdpdGggcGFnZTAgcHJvdGVjdGlv biBlbmFibGVkICphbnl3YXkqLCB3aHkgbWVzcyB3aXRoIHRoZSBWQkUgU2hpbSBhdA0KPiBhbGw/ DQo+IA0KPiBIb3cgYWJvdXQgdGhlIGZvbGxvd2luZyBwYXRjaCBpbnN0ZWFkOg0KPiANCj4gPiBk aWZmIC0tZ2l0IGEvT3ZtZlBrZy9RZW11VmlkZW9EeGUvVmJlU2hpbS5jDQo+IGIvT3ZtZlBrZy9R ZW11VmlkZW9EeGUvVmJlU2hpbS5jDQo+ID4gaW5kZXggZTQ1YTA4ZTg4NzNmLi44YmE1NTIyY2Rl M2MgMTAwNjQ0DQo+ID4gLS0tIGEvT3ZtZlBrZy9RZW11VmlkZW9EeGUvVmJlU2hpbS5jDQo+ID4g KysrIGIvT3ZtZlBrZy9RZW11VmlkZW9EeGUvVmJlU2hpbS5jDQo+ID4gQEAgLTc1LDYgKzc1LDIw IEBAIEluc3RhbGxWYmVTaGltICgNCj4gPiAgICBVSU5UTiAgICAgICAgICAgICAgICBQcmludGVk Ow0KPiA+ICAgIFZCRV9NT0RFX0lORk8gICAgICAgICpWYmVNb2RlSW5mbzsNCj4gPg0KPiA+ICsg IGlmICgoUGNkR2V0OCAoUGNkTnVsbFBvaW50ZXJEZXRlY3Rpb25Qcm9wZXJ0eU1hc2spICYgKEJJ VDB8QklUNykpID09IEJJVDApDQo+IHsNCj4gPiArICAgIERFQlVHICgoDQo+ID4gKyAgICAgIERF QlVHX1dBUk4sDQo+ID4gKyAgICAgICIlYTogcGFnZSAwIHByb3RlY3RlZCwgbm90IGluc3RhbGxp bmcgVkJFIHNoaW1cbiIsDQo+ID4gKyAgICAgIF9fRlVOQ1RJT05fXw0KPiA+ICsgICAgICApKTsN Cj4gPiArICAgIERFQlVHICgoDQo+ID4gKyAgICAgIERFQlVHX1dBUk4sDQo+ID4gKyAgICAgICIl YTogcGFnZSAwIHByb3RlY3Rpb24gcHJldmVudHMgV2luZG93cyA3IGZyb20gYm9vdGluZyBhbnl3 YXlcbiIsDQo+ID4gKyAgICAgIF9fRlVOQ1RJT05fXw0KPiA+ICsgICAgICApKTsNCj4gPiArICAg IHJldHVybjsNCj4gPiArICB9DQo+ID4gKw0KPiA+ICAgIFNlZ21lbnQwID0gMHgwMDAwMDsNCj4g PiAgICBTZWdtZW50QyA9IDB4QzAwMDA7DQo+ID4gICAgU2VnbWVudEYgPSAweEYwMDAwOw0KPiAN Cj4gVGhhbmtzIQ0KPiBMYXN6bG8NCg==