public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Dong, Eric" <eric.dong@intel.com>
Subject: Re: [patch] UefiCpuPkg/CpuDxe: Add missing function description comments
Date: Mon, 25 Sep 2017 06:16:14 +0000	[thread overview]
Message-ID: <D827630B58408649ACB04F44C510003624C9A490@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1506319277-460700-1-git-send-email-dandan.bi@intel.com>

Thanks for adding the comment. It look good to me.

> -----Original Message-----
> From: Bi, Dandan
> Sent: Monday, September 25, 2017 2:01 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
> Subject: [patch] UefiCpuPkg/CpuDxe: Add missing function description
> comments
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  UefiCpuPkg/CpuDxe/CpuDxe.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.h b/UefiCpuPkg/CpuDxe/CpuDxe.h
> index a25b35c..9c0d223 100644
> --- a/UefiCpuPkg/CpuDxe/CpuDxe.h
> +++ b/UefiCpuPkg/CpuDxe/CpuDxe.h
> @@ -263,10 +263,13 @@ VOID
>  EFIAPI
>  SetDataSelectors (
>    UINT16 Selector
>    );
> 
> +/**
> +  Update GCD memory space attributes according to current page table setup.
> +**/
>  VOID
>  RefreshGcdMemoryAttributesFromPaging (
>    VOID
>    );
> 
> --
> 1.9.5.msysgit.1



      reply	other threads:[~2017-09-25  6:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25  6:01 [patch] UefiCpuPkg/CpuDxe: Add missing function description comments Dandan Bi
2017-09-25  6:16 ` Wang, Jian J [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D827630B58408649ACB04F44C510003624C9A490@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox