From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 42DDC21E1B75A for ; Sun, 24 Sep 2017 23:13:06 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2017 23:16:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,435,1500966000"; d="scan'208";a="155553327" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 24 Sep 2017 23:16:17 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Sep 2017 23:16:16 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Sep 2017 23:16:16 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Mon, 25 Sep 2017 14:16:14 +0800 From: "Wang, Jian J" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Dong, Eric" Thread-Topic: [patch] UefiCpuPkg/CpuDxe: Add missing function description comments Thread-Index: AQHTNcPFI8YR7yT8xUWNbdM8JZTOk6LFH7BA Date: Mon, 25 Sep 2017 06:16:14 +0000 Message-ID: References: <1506319277-460700-1-git-send-email-dandan.bi@intel.com> In-Reply-To: <1506319277-460700-1-git-send-email-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] UefiCpuPkg/CpuDxe: Add missing function description comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 06:13:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for adding the comment. It look good to me. > -----Original Message----- > From: Bi, Dandan > Sent: Monday, September 25, 2017 2:01 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Wang, Jian J > Subject: [patch] UefiCpuPkg/CpuDxe: Add missing function description > comments >=20 > Cc: Eric Dong > Cc: Jian J Wang > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > UefiCpuPkg/CpuDxe/CpuDxe.h | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.h b/UefiCpuPkg/CpuDxe/CpuDxe.h > index a25b35c..9c0d223 100644 > --- a/UefiCpuPkg/CpuDxe/CpuDxe.h > +++ b/UefiCpuPkg/CpuDxe/CpuDxe.h > @@ -263,10 +263,13 @@ VOID > EFIAPI > SetDataSelectors ( > UINT16 Selector > ); >=20 > +/** > + Update GCD memory space attributes according to current page table set= up. > +**/ > VOID > RefreshGcdMemoryAttributesFromPaging ( > VOID > ); >=20 > -- > 1.9.5.msysgit.1