From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 368E0208F7903 for ; Tue, 10 Oct 2017 01:38:09 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2017 01:41:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,504,1500966000"; d="scan'208";a="160901228" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2017 01:41:37 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Oct 2017 01:41:36 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Oct 2017 01:41:36 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Tue, 10 Oct 2017 16:41:34 +0800 From: "Wang, Jian J" To: Laszlo Ersek , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Wolman, Ayellet" , "Yao, Jiewen" , "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH v4 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing Thread-Index: AQHTQRby47olaQhbFUeyvVObOnSZBaLbJd0AgAEqueD//+ZtAIAAjZKg Date: Tue, 10 Oct 2017 08:41:34 +0000 Message-ID: References: <20171009141722.992-1-jian.j.wang@intel.com> <20171009141722.992-7-jian.j.wang@intel.com> <4936a3a6-e4ef-ad6c-d915-1ee45c9387b6@redhat.com> <2678dcd3-6408-0b56-dfda-278c7990a936@redhat.com> In-Reply-To: <2678dcd3-6408-0b56-dfda-278c7990a936@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v4 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 08:38:10 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 R290IGl0LiBUaGFuayB5b3UgdmVyeSBtdWNoIGZvciB0aGUgYWR2aWNlIGFuZCBpbmZvcm1hdGlv bi4NCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBMYXN6bG8gRXJzZWsg W21haWx0bzpsZXJzZWtAcmVkaGF0LmNvbV0NCj4gU2VudDogVHVlc2RheSwgT2N0b2JlciAxMCwg MjAxNyA0OjEzIFBNDQo+IFRvOiBXYW5nLCBKaWFuIEogPGppYW4uai53YW5nQGludGVsLmNvbT47 IGVkazItZGV2ZWxAbGlzdHMuMDEub3JnDQo+IENjOiBLaW5uZXksIE1pY2hhZWwgRCA8bWljaGFl bC5kLmtpbm5leUBpbnRlbC5jb20+OyBXb2xtYW4sIEF5ZWxsZXQNCj4gPGF5ZWxsZXQud29sbWFu QGludGVsLmNvbT47IFlhbywgSmlld2VuIDxqaWV3ZW4ueWFvQGludGVsLmNvbT47IERvbmcsIEVy aWMNCj4gPGVyaWMuZG9uZ0BpbnRlbC5jb20+OyBaZW5nLCBTdGFyIDxzdGFyLnplbmdAaW50ZWwu Y29tPg0KPiBTdWJqZWN0OiBSZTogW2VkazJdIFtQQVRDSCB2NCA2LzZdIE92bWZQa2cvUWVtdVZp ZGVvRHhlOiBCeXBhc3MgTlVMTA0KPiBwb2ludGVyIGRldGVjdGlvbiBkdXJpbmcgVkJFIFNISU0g aW5zdGFsbGluZw0KPiANCj4gT24gMTAvMTAvMTcgMDM6NTAsIFdhbmcsIEppYW4gSiB3cm90ZToN Cj4gPiBJIGhhdmUgc3VtbWFyeSBpbiBlYWNoIHBhdGNoIGVtYWlsLg0KPiANCj4gU3VyZSwgeW91 IGhhdmUgYSBjb21taXQgbWVzc2FnZSwgYnV0IHlvdSBkaWRuJ3QgcG9pbnQgb3V0IGFueSB2My0+ djQNCj4gY2hhbmdlcy4gKElmIHRoZXJlIGFyZSBubyB2My0+djQgY2hhbmdlcywgdGhlbiBwbGVh c2UgcGljayB1cCB0aGUgUi1iJ3MNCj4gcmVjZWl2ZWQgZm9yIHYzLikNCj4gDQo+ID4gSSByZW1v dmVkIHRoZSBDQyBvZiBzb21lIHBhdGNoZXMgYmVjYXVzZQ0KPiA+IHRoZXJlJ3Mgbm8gdXBkYXRl IGZyb20gdjMgdG8gdjQuIEkgdGhvdWdodCB0aGlzIGNvdWxkIHJlbWluZCB5b3Ugb2YgdGhpcw0K PiBzaXR1YXRpb24uDQo+ID4gV2hhdCdzIHRoZSByZWNvbW1lbmRlZCB3YXk/IEtlZXAgdGhlIEND IGFzLXdhcyBhbmQganVzdCBhZGQgc3VtbWFyaWVzIGluDQo+ID4gY292ZXIgbGV0dGVyPw0KPiAN Cj4gTWFpbnRhaW5lcnMgc2hvdWxkIGFsd2F5cyBiZSBDQydkLCBldmVuIGlmIHRoZXJlIGFyZSBu byBjaGFuZ2VzIHJlbGF0aXZlDQo+IHRvIHRoZSBwcmV2aW91cyB2ZXJzaW9uLg0KPiANCj4gUGVy c29uYWxseSBJIHByZWZlciBzdW1tYXJpemluZyB0aGUgY2hhbmdlcyBpbiB0aGUgY292ZXIgbGV0 dGVyLCBhbmQNCj4gYWxzbyBleHBsYWluaW5nIHRoZSBjaGFuZ2VzIGluIG1vcmUgZGV0YWlsIC0t IG9yIHBvaW50aW5nIG91dCB0aGUgbGFjaw0KPiBvZiBhbnkgY2hhbmdlcyAtLSBvbiBlYWNoIGlu ZGl2aWR1YWwgcGF0Y2guDQo+IA0KPiBJZiB5b3UgaGF2ZSBhIGJpdCBvZiB0aW1lIGZvciByZWFk aW5nLCBJIHJlY29tbWVuZCB0aGUgZm9sbG93aW5nIHdpa2kNCj4gYXJ0aWNsZToNCj4gDQo+IGh0 dHBzOi8vZ2l0aHViLmNvbS90aWFub2NvcmUvdGlhbm9jb3JlLmdpdGh1Yi5pby93aWtpL0xhc3ps bydzLXVua2VtcHQtZ2l0LQ0KPiBndWlkZS1mb3ItZWRrMi1jb250cmlidXRvcnMtYW5kLW1haW50 YWluZXJzDQo+IA0KPiBJbiBpdCwgSSBoYWQgd3JpdHRlbiBkb3duIG1vc3QgZXZlcnl0aGluZyB0 aGF0IEkgaGF2ZSBpbiBtaW5kIGFib3V0IHRoZQ0KPiBlZGsyIGRldmVsb3BtZW50IHByb2Nlc3Mu IFRoZSBmb2xsb3dpbmcgc3RlcHMgcGVydGFpbiB0byB0aGUgY3VycmVudA0KPiBkaXNjdXNzaW9u IChpLmUuLCBwaWNraW5nIHVwIGZlZWRiYWNrIHRhZ3MsIGFkZGluZyBNYWludGFpbmVyIENDJ3Ms IGFuZA0KPiBwb2ludGluZyBvdXQgY2hhbmdlcyBwZXIgcGF0Y2gpOg0KPiANCj4gaHR0cHM6Ly9n aXRodWIuY29tL3RpYW5vY29yZS90aWFub2NvcmUuZ2l0aHViLmlvL3dpa2kvTGFzemxvJ3MtdW5r ZW1wdC1naXQtDQo+IGd1aWRlLWZvci1lZGsyLWNvbnRyaWJ1dG9ycy1hbmQtbWFpbnRhaW5lcnMj Y29udHJpYi0xOA0KPiANCj4gaHR0cHM6Ly9naXRodWIuY29tL3RpYW5vY29yZS90aWFub2NvcmUu Z2l0aHViLmlvL3dpa2kvTGFzemxvJ3MtdW5rZW1wdC1naXQtDQo+IGd1aWRlLWZvci1lZGsyLWNv bnRyaWJ1dG9ycy1hbmQtbWFpbnRhaW5lcnMjY29udHJpYi0yOA0KPiANCj4gaHR0cHM6Ly9naXRo dWIuY29tL3RpYW5vY29yZS90aWFub2NvcmUuZ2l0aHViLmlvL3dpa2kvTGFzemxvJ3MtdW5rZW1w dC1naXQtDQo+IGd1aWRlLWZvci1lZGsyLWNvbnRyaWJ1dG9ycy1hbmQtbWFpbnRhaW5lcnMjY29u dHJpYi0zMA0KPiANCj4gVGhhbmtzLA0KPiBMYXN6bG8NCj4gDQo+IA0KPiA+DQo+ID4+IC0tLS0t T3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+IEZyb206IExhc3psbyBFcnNlayBbbWFpbHRvOmxl cnNla0ByZWRoYXQuY29tXQ0KPiA+PiBTZW50OiBNb25kYXksIE9jdG9iZXIgMDksIDIwMTcgMTE6 NTYgUE0NCj4gPj4gVG86IFdhbmcsIEppYW4gSiA8amlhbi5qLndhbmdAaW50ZWwuY29tPjsgZWRr Mi1kZXZlbEBsaXN0cy4wMS5vcmcNCj4gPj4gQ2M6IEtpbm5leSwgTWljaGFlbCBEIDxtaWNoYWVs LmQua2lubmV5QGludGVsLmNvbT47IFdvbG1hbiwgQXllbGxldA0KPiA+PiA8YXllbGxldC53b2xt YW5AaW50ZWwuY29tPjsgWWFvLCBKaWV3ZW4gPGppZXdlbi55YW9AaW50ZWwuY29tPjsgRG9uZywN Cj4gRXJpYw0KPiA+PiA8ZXJpYy5kb25nQGludGVsLmNvbT47IFplbmcsIFN0YXIgPHN0YXIuemVu Z0BpbnRlbC5jb20+DQo+ID4+IFN1YmplY3Q6IFJlOiBbZWRrMl0gW1BBVENIIHY0IDYvNl0gT3Zt ZlBrZy9RZW11VmlkZW9EeGU6IEJ5cGFzcyBOVUxMDQo+ID4+IHBvaW50ZXIgZGV0ZWN0aW9uIGR1 cmluZyBWQkUgU0hJTSBpbnN0YWxsaW5nDQo+ID4+DQo+ID4+IE9uIDEwLzA5LzE3IDE3OjU0LCBM YXN6bG8gRXJzZWsgd3JvdGU6DQo+ID4+PiBPbiAxMC8wOS8xNyAxNjoxNywgSmlhbiBKIFdhbmcg d3JvdGU6DQo+ID4+Pj4gUWVtdVZpZGVvRHhlIGRyaXZlciB3aWxsIGxpbmsgVkJFIFNISU0gaW50 byBwYWdlIDAuIElmIE5VTEwgcG9pbnRlcg0KPiA+Pj4+IGRldGVjdGlvbiBpcyBlbmFibGVkLCB0 aGlzIGRyaXZlciB3aWxsIGZhaWwgdG8gbG9hZC4gTlVMTCBwb2ludGVyIGRldGVjdGlvbg0KPiA+ Pj4+IGJ5cGFzc2luZyBjb2RlIGlzIGFkZGVkIHRvIHByZXZlbnQgc3VjaCBwcm9ibGVtIGR1cmlu ZyBib290Lg0KPiA+Pj4+DQo+ID4+Pj4gUGxlYXNlIG5vdGUgdGhhdCBXaW5kb3dzIDcgd2lsbCB0 cnkgdG8gYWNjZXNzIFZCRSBTSElNIGR1cmluZyBib290IGlmIGl0J3MNCj4gPj4+PiBpbnN0YWxs ZWQsIGFuZCB0aGVuIGNhdXNlIGJvb3QgZmFpbHVyZS4gVGhpcyBjYW4gYmUgZml4ZWQgYnkgc2V0 dGluZyBCSVQ3DQo+ID4+Pj4gb2YgUGNkTnVsbFBvaW50ZXJEZXRlY3Rpb25Qcm9wZXJ0eU1hc2sg dG8gZGlzYWJsZSBOVUxMIHBvaW50ZXINCj4gZGV0ZWN0aW9uDQo+ID4+Pj4gYWZ0ZXIgRW5kT2ZE eGUuIEFzIGZhciBhcyB3ZSBrbm93LCB0aGVyZSdzIG5vIG90aGVyIE9TcyBoYXMgc3VjaCBpc3N1 ZS4NCj4gPj4+Pg0KPiA+Pj4+IENjOiBTdGFyIFplbmcgPHN0YXIuemVuZ0BpbnRlbC5jb20+DQo+ ID4+Pj4gQ2M6IEVyaWMgRG9uZyA8ZXJpYy5kb25nQGludGVsLmNvbT4NCj4gPj4+PiBDYzogSmll d2VuIFlhbyA8amlld2VuLnlhb0BpbnRlbC5jb20+DQo+ID4+Pj4gQ2M6IE1pY2hhZWwgS2lubmV5 IDxtaWNoYWVsLmQua2lubmV5QGludGVsLmNvbT4NCj4gPj4+PiBDYzogQXllbGxldCBXb2xtYW4g PGF5ZWxsZXQud29sbWFuQGludGVsLmNvbT4NCj4gPj4+PiBTdWdnZXN0ZWQtYnk6IEF5ZWxsZXQg V29sbWFuIDxheWVsbGV0LndvbG1hbkBpbnRlbC5jb20+DQo+ID4+Pj4gQ29udHJpYnV0ZWQtdW5k ZXI6IFRpYW5vQ29yZSBDb250cmlidXRpb24gQWdyZWVtZW50IDEuMQ0KPiA+Pj4+IFNpZ25lZC1v ZmYtYnk6IEppYW4gSiBXYW5nIDxqaWFuLmoud2FuZ0BpbnRlbC5jb20+DQo+ID4+Pj4gLS0tDQo+ ID4+Pj4gIE92bWZQa2cvUWVtdVZpZGVvRHhlL1FlbXVWaWRlb0R4ZS5pbmYgfCAgMSArDQo+ID4+ Pj4gIE92bWZQa2cvUWVtdVZpZGVvRHhlL1ZiZVNoaW0uYyAgICAgICAgfCAxNCArKysrKysrKysr KysrKw0KPiA+Pj4+ICAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKykNCj4gPj4+Pg0K PiA+Pj4+IGRpZmYgLS1naXQgYS9Pdm1mUGtnL1FlbXVWaWRlb0R4ZS9RZW11VmlkZW9EeGUuaW5m DQo+ID4+IGIvT3ZtZlBrZy9RZW11VmlkZW9EeGUvUWVtdVZpZGVvRHhlLmluZg0KPiA+Pj4+IGlu ZGV4IDU3N2UwN2IwYTguLmZmNjhjOTllOTYgMTAwNjQ0DQo+ID4+Pj4gLS0tIGEvT3ZtZlBrZy9R ZW11VmlkZW9EeGUvUWVtdVZpZGVvRHhlLmluZg0KPiA+Pj4+ICsrKyBiL092bWZQa2cvUWVtdVZp ZGVvRHhlL1FlbXVWaWRlb0R4ZS5pbmYNCj4gPj4+PiBAQCAtNzcsMyArNzcsNCBAQA0KPiA+Pj4+ ICBbUGNkXQ0KPiA+Pj4+ICAgIGdPcHRpb25Sb21Qa2dUb2tlblNwYWNlR3VpZC5QY2REcml2ZXJT dXBwb3J0ZWRFZmlWZXJzaW9uDQo+ID4+Pj4gICAgZ1VlZmlPdm1mUGtnVG9rZW5TcGFjZUd1aWQu UGNkT3ZtZkhvc3RCcmlkZ2VQY2lEZXZJZA0KPiA+Pj4+ICsNCj4gPj4gZ0VmaU1kZU1vZHVsZVBr Z1Rva2VuU3BhY2VHdWlkLlBjZE51bGxQb2ludGVyRGV0ZWN0aW9uUHJvcGVydHlNYXNrDQo+ID4+ Pj4gZGlmZiAtLWdpdCBhL092bWZQa2cvUWVtdVZpZGVvRHhlL1ZiZVNoaW0uYw0KPiA+PiBiL092 bWZQa2cvUWVtdVZpZGVvRHhlL1ZiZVNoaW0uYw0KPiA+Pj4+IGluZGV4IGU0NWEwOGU4ODcuLjhi YTU1MjJjZGUgMTAwNjQ0DQo+ID4+Pj4gLS0tIGEvT3ZtZlBrZy9RZW11VmlkZW9EeGUvVmJlU2hp bS5jDQo+ID4+Pj4gKysrIGIvT3ZtZlBrZy9RZW11VmlkZW9EeGUvVmJlU2hpbS5jDQo+ID4+Pj4g QEAgLTc1LDYgKzc1LDIwIEBAIEluc3RhbGxWYmVTaGltICgNCj4gPj4+PiAgICBVSU5UTiAgICAg ICAgICAgICAgICBQcmludGVkOw0KPiA+Pj4+ICAgIFZCRV9NT0RFX0lORk8gICAgICAgICpWYmVN b2RlSW5mbzsNCj4gPj4+Pg0KPiA+Pj4+ICsgIGlmICgoUGNkR2V0OCAoUGNkTnVsbFBvaW50ZXJE ZXRlY3Rpb25Qcm9wZXJ0eU1hc2spICYgKEJJVDB8QklUNykpID09DQo+IEJJVDApDQo+ID4+IHsN Cj4gPj4+PiArICAgIERFQlVHICgoDQo+ID4+Pj4gKyAgICAgIERFQlVHX1dBUk4sDQo+ID4+Pj4g KyAgICAgICIlYTogcGFnZSAwIHByb3RlY3RlZCwgbm90IGluc3RhbGxpbmcgVkJFIHNoaW1cbiIs DQo+ID4+Pj4gKyAgICAgIF9fRlVOQ1RJT05fXw0KPiA+Pj4+ICsgICAgICApKTsNCj4gPj4+PiAr ICAgIERFQlVHICgoDQo+ID4+Pj4gKyAgICAgIERFQlVHX1dBUk4sDQo+ID4+Pj4gKyAgICAgICIl YTogcGFnZSAwIHByb3RlY3Rpb24gcHJldmVudHMgV2luZG93cyA3IGZyb20gYm9vdGluZyBhbnl3 YXlcbiIsDQo+ID4+Pj4gKyAgICAgIF9fRlVOQ1RJT05fXw0KPiA+Pj4+ICsgICAgICApKTsNCj4g Pj4+PiArICAgIHJldHVybjsNCj4gPj4+PiArICB9DQo+ID4+Pj4gKw0KPiA+Pj4+ICAgIFNlZ21l bnQwID0gMHgwMDAwMDsNCj4gPj4+PiAgICBTZWdtZW50QyA9IDB4QzAwMDA7DQo+ID4+Pj4gICAg U2VnbWVudEYgPSAweEYwMDAwOw0KPiA+Pj4+DQo+ID4+Pg0KPiA+Pj4gSWYgdGhpcyBwYXRjaCBp cyBlbnRpcmVseSBpZGVudGljYWwgdG8gdGhlIHByZXZpb3VzIHZlcnNpb24gKHYzKSwgdGhlbg0K PiA+Pj4geW91IHNob3VsZCBoYXZlIHBsZWFzZSBwaWNrZWQgdXAgdGhlIHJldmlldyB0YWdzIGZy b20gSm9yZGFuIGFuZCBteXNlbGYsDQo+ID4+PiB0aGUgb25lcyB0aGF0IHlvdSBnb3QgZm9yIHYz Og0KPiA+Pj4NCj4gPj4+IGh0dHA6Ly9taWQubWFpbC0NCj4gPj4gYXJjaGl2ZS5jb20vMTUwNjk2 NzExODMxLjI0NTQuMTY3MTIxNzA1MjUxMDM0MTUyNDhAamxqdXN0ZW4tc2tsDQo+ID4+Pg0KPiA+ Pj4gaHR0cDovL21pZC5tYWlsLWFyY2hpdmUuY29tL2QxYTIwYmU1LThkYmYtOGNlNi0xNzM4LQ0K PiA+PiBkMDNiMzMwMDQ3Y2NAcmVkaGF0LmNvbQ0KPiA+Pj4NCj4gPj4+IFRoaXMgd2F5IHdlIGNh biBxdWlja2x5IGZpbHRlciBvdXQgYWxyZWFkeSByZXZpZXdlZCBwYXRjaGVzLCBhbmQgYXZvaWQN Cj4gPj4+IHJlLXJldmlld2luZyB3aGVuIHRoZXJlIGFyZSBubyBjaGFuZ2VzLg0KPiA+Pj4NCj4g Pj4+DQo+ID4+PiBZb3VyIGNvdmVyIGxldHRlciB2NCAwLzYgYWxzbyBkb2VzIG5vdCBzdW1tYXJp emUgdGhlIGNoYW5nZXMgcmVsYXRpdmUgdG8NCj4gPj4+IHYzOyBpbiB0aGUgZnV0dXJlIHBsZWFz ZSBkb24ndCBmb3JnZXQgYWJvdXQgdGhhdC4NCj4gPj4NCj4gPj4gLi4uIHBlcnNvbmFsIENDJ3Mg Zm9yIE92bWZQa2cgbWFpbnRhaW5lcnMgYW5kIHJldmlld2VycyBhcmUgYWxzbyBtaXNzaW5nDQo+ ID4+IGZyb20gdGhpcyBwYXRjaC4gUGxlYXNlIGNoZWNrICJNYWludGFpbmVycy50eHQiIGV2ZXJ5 IHRpbWUuDQo+ID4+DQo+ID4+IFRoYW5rcw0KPiA+PiBMYXN6bG8NCg0K