From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "Wang, Jian J" <jian.j.wang@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"Dong, Eric" <eric.dong@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH v4 0/6] Add NULL pointer detection feature
Date: Wed, 11 Oct 2017 00:52:46 +0000 [thread overview]
Message-ID: <D827630B58408649ACB04F44C510003624CA0C55@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20171009141722.992-1-jian.j.wang@intel.com>
Hi,
Any more comments for this version of patch? If no, I'll check in it today. Thanks.
Jian
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jian J
> Wang
> Sent: Monday, October 09, 2017 10:17 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v4 0/6] Add NULL pointer detection feature
>
> The mechanism behind is to trigger a page fault exception at address 0.
> This can be made by disabling page 0 (0-4095) during page table setup.
> So this feature can only be available on platform with paging enabled.
>
> Once this feature is enabled, any code, like CSM, which has to access
> memory in page 0 needs to enable this page temporarily in advance and
> disable it afterwards.
>
> PcdNullPointerDetectionPropertyMask is used to control and elaborate
> the use cases. For example, BIT7 of this PCD must be set for Windows 7
> boot on Qemu if BIT0 set; or boot will fail.
>
> Suggested-by: Ayellet Wolman <ayellet.wolman@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
>
> Jian J Wang (5):
> MdeModulePkg/DxeIpl: Implement NULL pointer detection
> MdeModulePkg/Core/Dxe: Add EndOfDxe workaround for NULL pointer
> detection
> UefiCpuPkg/PiSmmCpuDxeSmm: Implement NULL pointer detection for SMM
> code
> IntelFrameworkModulePkg/Csm: Add code to bypass NULL pointer detection
> OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM
> installing
>
> Wang, Jian J (1):
> MdeModulePkg/MdeModulePkg.dec,.uni: Add NULL pointer detection PCD
>
> .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c | 101 ++++++++++++++
> .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.h | 2 +
> .../Csm/BiosThunk/KeyboardDxe/KeyboardDxe.inf | 2 +
> .../Csm/LegacyBiosDxe/LegacyBda.c | 4 +
> .../Csm/LegacyBiosDxe/LegacyBios.c | 152 +++++++++++++++++++++
> .../Csm/LegacyBiosDxe/LegacyBiosDxe.inf | 2 +
> .../Csm/LegacyBiosDxe/LegacyBiosInterface.h | 18 +++
> .../Csm/LegacyBiosDxe/LegacyBootSupport.c | 23 +++-
> .../Csm/LegacyBiosDxe/LegacyPci.c | 17 ++-
> IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c | 27 +++-
> MdeModulePkg/Core/Dxe/DxeMain.inf | 1 +
> MdeModulePkg/Core/Dxe/Mem/Page.c | 4 +-
> MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 65 +++++++++
> MdeModulePkg/Core/DxeIplPeim/DxeIpl.h | 25 ++++
> MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 1 +
> MdeModulePkg/Core/DxeIplPeim/DxeLoad.c | 1 +
> MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c | 17 ++-
> MdeModulePkg/Core/DxeIplPeim/X64/DxeLoadFunc.c | 4 +
> MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 93 ++++++++++++-
> MdeModulePkg/MdeModulePkg.dec | 13 ++
> MdeModulePkg/MdeModulePkg.uni | 13 ++
> OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf | 1 +
> OvmfPkg/QemuVideoDxe/VbeShim.c | 14 ++
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 12 ++
> UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 25 +++-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 1 +
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 12 ++
> 27 files changed, 628 insertions(+), 22 deletions(-)
>
> --
> 2.14.1.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-10-11 0:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 14:17 [PATCH v4 0/6] Add NULL pointer detection feature Jian J Wang
2017-10-09 14:17 ` [PATCH v4 1/6] MdeModulePkg/MdeModulePkg.dec, .uni: Add NULL pointer detection PCD Jian J Wang
2017-10-09 14:17 ` [PATCH v4 2/6] MdeModulePkg/DxeIpl: Implement NULL pointer detection Jian J Wang
2017-10-09 14:17 ` [PATCH v4 3/6] MdeModulePkg/Core/Dxe: Add EndOfDxe workaround for " Jian J Wang
2017-10-09 14:17 ` [PATCH v4 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Implement NULL pointer detection for SMM code Jian J Wang
2017-10-09 14:17 ` [PATCH v4 5/6] IntelFrameworkModulePkg/Csm: Add code to bypass NULL pointer detection Jian J Wang
2017-10-11 21:29 ` Laszlo Ersek
2017-10-12 1:06 ` Wang, Jian J
2017-10-09 14:17 ` [PATCH v4 6/6] OvmfPkg/QemuVideoDxe: Bypass NULL pointer detection during VBE SHIM installing Jian J Wang
2017-10-09 15:54 ` Laszlo Ersek
2017-10-09 15:55 ` Laszlo Ersek
2017-10-10 1:50 ` Wang, Jian J
2017-10-10 8:13 ` Laszlo Ersek
2017-10-10 8:41 ` Wang, Jian J
2017-10-11 0:52 ` Wang, Jian J [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D827630B58408649ACB04F44C510003624CA0C55@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox