From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 374642034CF70 for ; Sun, 22 Oct 2017 18:15:42 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2017 18:19:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,420,1503385200"; d="scan'208";a="166219151" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 22 Oct 2017 18:19:23 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 22 Oct 2017 18:19:23 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 22 Oct 2017 18:19:23 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Mon, 23 Oct 2017 09:19:21 +0800 From: "Wang, Jian J" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [patch 1/4] IntelFrameworkModulePkg/Csm: Refine coding style in comments Thread-Index: AQHTST7RO7NVLwJLi0+lhZS8VardM6LwprLg Date: Mon, 23 Oct 2017 01:19:20 +0000 Message-ID: References: <1508461193-5204-1-git-send-email-dandan.bi@intel.com> <1508461193-5204-2-git-send-email-dandan.bi@intel.com> In-Reply-To: <1508461193-5204-2-git-send-email-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDRjODY1NWUtMWViOC00NjgyLThlNDQtMDBjODZjZTEwNjkwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJMblwvOG02TFh6cHNmbG1BYU1tU0lqNFg5b2ZrY0MyTDNpU2M5eVwvR3pFMlVIb1dDZ1dvaHdOWEZveDVkRm9kRFgifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 1/4] IntelFrameworkModulePkg/Csm: Refine coding style in comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 01:15:42 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jian J Wang > -----Original Message----- > From: Bi, Dandan > Sent: Friday, October 20, 2017 9:00 AM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J ; Gao, Liming > Subject: [patch 1/4] IntelFrameworkModulePkg/Csm: Refine coding style in > comments >=20 > Make the comments follow Edk2 coding style: > 1. Make the comments starts with /** and end with **/. > 2. Make the comments descrition end with '.' >=20 > Cc: Jian J Wang > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c | 8 > ++++---- > IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c | 8 +++= +---- > IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h | 8 > ++++---- > 3 files changed, 12 insertions(+), 12 deletions(-) >=20 > diff --git > a/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c > b/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c > index d2224a2..ebf03d3 100644 > --- a/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c > +++ > b/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c > @@ -1731,12 +1731,12 @@ CheckKeyboardConnect ( > return TRUE; > } > } >=20 > /** > - Disable NULL pointer detection > -*/ > + Disable NULL pointer detection. > +**/ > VOID > DisableNullDetection ( > VOID > ) > { > @@ -1778,12 +1778,12 @@ DisableNullDetection ( > DEBUG ((DEBUG_WARN, "!!! Page 0 is supposed to be disabled !!!\r\n")= ); > } > } >=20 > /** > - Enable NULL pointer detection > -*/ > + Enable NULL pointer detection. > +**/ > VOID > EnableNullDetection ( > VOID > ) > { > diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c > b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c > index 3176a98..e009999 100644 > --- a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c > +++ b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c > @@ -792,12 +792,12 @@ ToggleEndOfDxeStatus ( > // functions can be used to disable/enable NULL pointer detection before= /after > // accessing those memory. > // >=20 > /** > - Enable NULL pointer detection > -*/ > + Enable NULL pointer detection. > +**/ > VOID > EnableNullDetection ( > VOID > ) > { > @@ -842,12 +842,12 @@ EnableNullDetection ( > ASSERT_EFI_ERROR (Status); > } > } >=20 > /** > - Disable NULL pointer detection > -*/ > + Disable NULL pointer detection. > +**/ > VOID > DisableNullDetection ( > VOID > ) > { > diff --git > a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h > b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h > index 20dfef3..86a3b09 100644 > --- a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h > +++ b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h > @@ -1543,20 +1543,20 @@ EFI_STATUS > LegacyBiosInstallVgaRom ( > IN LEGACY_BIOS_INSTANCE *Private > ); >=20 > /** > - Enable NULL pointer detection > -*/ > + Enable NULL pointer detection. > +**/ > VOID > EnableNullDetection ( > VOID > ); >=20 > /** > - Disable NULL pointer detection > -*/ > + Disable NULL pointer detection. > +**/ > VOID > DisableNullDetection ( > VOID > ); >=20 > -- > 1.9.5.msysgit.1