From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 355992034CF70 for ; Sun, 22 Oct 2017 18:16:04 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2017 18:19:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,420,1503385200"; d="scan'208";a="166219210" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 22 Oct 2017 18:19:46 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 22 Oct 2017 18:19:46 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 22 Oct 2017 18:19:46 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Mon, 23 Oct 2017 09:19:44 +0800 From: "Wang, Jian J" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [patch 2/4] IntelFrameworkModule/LegacyBios: Avoid explicit comparison for BOOLEAN Thread-Index: AQHTST7SQCMURdutmECkQpCM7HJGGKLwp4Cw Date: Mon, 23 Oct 2017 01:19:43 +0000 Message-ID: References: <1508461193-5204-1-git-send-email-dandan.bi@intel.com> <1508461193-5204-3-git-send-email-dandan.bi@intel.com> In-Reply-To: <1508461193-5204-3-git-send-email-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjhjZTRhZjItZjhlYi00OGQ3LTg1MzMtNGE0M2QxNjRmMGYzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJKOURnTDBjZUpOOXRyVThCTDh6emtPUG1KeXIwZEpzbVlaVHY1MTFnQzNubHdDeHlsNGZ0VHYrT3VwRU5rekl3In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 2/4] IntelFrameworkModule/LegacyBios: Avoid explicit comparison for BOOLEAN X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 01:16:05 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jian J Wang > -----Original Message----- > From: Bi, Dandan > Sent: Friday, October 20, 2017 9:00 AM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J ; Gao, Liming > Subject: [patch 2/4] IntelFrameworkModule/LegacyBios: Avoid explicit > comparison for BOOLEAN >=20 > Cc: Jian J Wang > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c > b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c > index e009999..c6461f5 100644 > --- a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c > +++ b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c > @@ -804,11 +804,11 @@ EnableNullDetection ( > EFI_STATUS Status; > EFI_GCD_MEMORY_SPACE_DESCRIPTOR Desc; >=20 > if (((PcdGet8 (PcdNullPointerDetectionPropertyMask) & BIT0) =3D=3D 0) > || > - ((mEndOfDxe =3D=3D TRUE) && > + ((mEndOfDxe) && > ((PcdGet8 (PcdNullPointerDetectionPropertyMask) & (BIT7|BIT0)) > =3D=3D (BIT7|BIT0))) > ) { > return; > } > @@ -854,11 +854,11 @@ DisableNullDetection ( > EFI_STATUS Status; > EFI_GCD_MEMORY_SPACE_DESCRIPTOR Desc; >=20 > if (((PcdGet8 (PcdNullPointerDetectionPropertyMask) & BIT0) =3D=3D 0) > || > - ((mEndOfDxe =3D=3D TRUE) && > + ((mEndOfDxe) && > ((PcdGet8 (PcdNullPointerDetectionPropertyMask) & (BIT7|BIT0)) > =3D=3D (BIT7|BIT0))) > ) { > return; > } > -- > 1.9.5.msysgit.1