From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2EACE21CEB14C for ; Tue, 24 Oct 2017 18:44:28 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 24 Oct 2017 18:48:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,430,1503385200"; d="scan'208";a="164574126" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 24 Oct 2017 18:48:09 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 24 Oct 2017 18:48:08 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 24 Oct 2017 18:48:07 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Wed, 25 Oct 2017 09:48:05 +0800 From: "Wang, Jian J" To: "Wang, Jian J" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Wolman, Ayellet" , "Yao, Jiewen" , "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH v3 0/6] Implement heap guard feature Thread-Index: AQHTS5kKnTwecoWP+EeIq4s699pmr6LzzsGA Date: Wed, 25 Oct 2017 01:48:05 +0000 Message-ID: References: <20171023005054.7528-1-jian.j.wang@intel.com> In-Reply-To: <20171023005054.7528-1-jian.j.wang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmRkYjZkMWQtNjViNC00ZmVkLTlkOTUtYWVlNDExNGMxZjJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJUN09GNkpvY0c3dGFZblwvVWQ4b1NXTXRJaHY3eEpYamdYMTc2XC9jRnd1ZVNxaGhXZjZpOWxcL3lpY0J6MjF6ck5jIn0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v3 0/6] Implement heap guard feature X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 01:44:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Just a warm reminding. I didn't see any feedbacks on the v3 patch. If no more comments, I'll check in the patch soon. Thanks, Jian > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ji= an J > Wang > Sent: Monday, October 23, 2017 8:51 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Wolman, Ayellet > ; Yao, Jiewen ; Dong, Eri= c > ; Zeng, Star > Subject: [edk2] [PATCH v3 0/6] Implement heap guard feature >=20 > > Patch V3 changes: > > a. Add new protocol gEdkiiSmmMemoryAttributeProtocolGuid to do > > memory attributes update instead of doing it directly in SmmCore > > b. Fix GCC build error >=20 > > Patch V2 changes: > > a. Remove local variable initializer with memory copy from globals > > b. Change map table dump code to use DEBUG_PAGE|DEBUG_POOL level > > message > > c. Fix malfunction in 32-bit boot mode > > d. Add comment for the use of mOnGuarding > > e. Change name of function InitializePageTableLib to > > InitializePageTableGlobals > > f. Add code in 32-bit code to bypass setting page table to read-only > > g. Coding style clean-up > > >=20 > This feature makes use of paging mechanism to add a hidden (not present) > page just before and after the allocated memory block. If the code tries > to access memory outside of the allocated part, page fault exception will > be triggered. >=20 > This feature is disabled by default and is not recommended to enable it > in production build of BIOS. >=20 > Cc: Star Zeng > Cc: Eric Dong > Cc: Jiewen Yao > Cc: Michael Kinney > Cc: Ayellet Wolman > Suggested-by: Ayellet Wolman > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang >=20 > Jian J Wang (6): > MdeModulePkg/DxeCore: Implement heap guard feature for UEFI > MdeModulePkg/PiSmmCore: Implement heap guard feature for SMM mode > MdeModulePkg/MdeModulePkg.dec,.uni: Add Protocol, PCDs and string > tokens > UefiCpuPkg/CpuDxe: Reduce debug message > UefiCpuPkg/PiSmmCpuDxeSmm: Disable page table protection > MdeModulePkg/DxeIpl: Enable paging for heap guard >=20 > MdeModulePkg/Core/Dxe/DxeMain.inf | 4 + > MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 1184 > ++++++++++++++++ > MdeModulePkg/Core/Dxe/Mem/HeapGuard.h | 380 +++++ > MdeModulePkg/Core/Dxe/Mem/Imem.h | 38 +- > MdeModulePkg/Core/Dxe/Mem/Page.c | 130 +- > MdeModulePkg/Core/Dxe/Mem/Pool.c | 154 +- > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 1 + > MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c | 29 +- > MdeModulePkg/Core/PiSmmCore/HeapGuard.c | 1469 > ++++++++++++++++++++ > MdeModulePkg/Core/PiSmmCore/HeapGuard.h | 399 ++++++ > MdeModulePkg/Core/PiSmmCore/Page.c | 51 +- > MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 7 +- > MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 81 +- > MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 8 + > MdeModulePkg/Core/PiSmmCore/Pool.c | 81 +- > MdeModulePkg/Include/Protocol/SmmMemoryAttribute.h | 136 ++ > MdeModulePkg/MdeModulePkg.dec | 60 + > MdeModulePkg/MdeModulePkg.uni | 58 + > UefiCpuPkg/CpuDxe/CpuPageTable.c | 5 +- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 7 + > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 20 + > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 98 ++ > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 2 + > UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 163 +++ > UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 3 +- > 25 files changed, 4472 insertions(+), 96 deletions(-) > create mode 100644 MdeModulePkg/Core/Dxe/Mem/HeapGuard.c > create mode 100644 MdeModulePkg/Core/Dxe/Mem/HeapGuard.h > create mode 100644 MdeModulePkg/Core/PiSmmCore/HeapGuard.c > create mode 100644 MdeModulePkg/Core/PiSmmCore/HeapGuard.h > create mode 100644 MdeModulePkg/Include/Protocol/SmmMemoryAttribute.h >=20 > -- > 2.14.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel