* [PATCH v3 0/3] Fix misuses of AllocateCopyPool
@ 2017-11-08 2:11 Jian J Wang
2017-11-08 2:11 ` [PATCH v3 1/3] MdeModulePkg: " Jian J Wang
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Jian J Wang @ 2017-11-08 2:11 UTC (permalink / raw)
To: edk2-devel
> v3:
> a. Add necessary ASSERT
> b. Correct StrCpyS parameter
> c. Coding style clean-up
> v2:
> a. Use ReallocatePool instead of allocating then copying wherever applicable
AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of
memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger
than size of "Buffer", heap memory overflow occurs during copy.
One solution is to allocate pool first then copy the necessary bytes to new
memory. Another is using ReallocatePool instead if old buffer will be freed
on spot.
Jian J Wang (3):
MdeModulePkg: Fix misuses of AllocateCopyPool
ShellPkg: Fix misuses of AllocateCopyPool
IntelFrameworkModulePkg: Fix misuses of AllocateCopyPool
.../Universal/BdsDxe/DeviceMngr/DeviceManager.c | 10 +++++-----
.../Application/UiApp/FrontPageCustomizedUiSupport.c | 8 ++++++--
.../BootMaintenanceManagerCustomizedUiSupport.c | 8 ++++++--
MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | 10 +++++-----
MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 12 ++++++++----
.../Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c | 3 ++-
MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 9 ++++++---
ShellPkg/Application/Shell/Shell.c | 4 +++-
.../UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 7 +++++--
9 files changed, 46 insertions(+), 25 deletions(-)
--
2.14.1.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool
2017-11-08 2:11 [PATCH v3 0/3] Fix misuses of AllocateCopyPool Jian J Wang
@ 2017-11-08 2:11 ` Jian J Wang
2017-11-08 2:37 ` Zeng, Star
2017-11-08 2:12 ` [PATCH v3 2/3] ShellPkg: " Jian J Wang
2017-11-08 2:12 ` [PATCH v3 3/3] IntelFrameworkModulePkg: " Jian J Wang
2 siblings, 1 reply; 10+ messages in thread
From: Jian J Wang @ 2017-11-08 2:11 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Eric Dong, Bi Dandan
>v3:
> a. Add ASSERT for returned pointer
> b. Correct DestMax parameter in calling StrCpyS
> c. Fix coding style
>v2:
> a. Use ReallocatePool to replace AllocateCopyPool wherever applicable.
AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of
memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger
than size of "Buffer", heap memory overflow occurs during copy.
One solution is to allocate pool first then copy the necessary bytes to new
memory. Another is using ReallocatePool instead if old buffer will be freed
on spot.
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Bi Dandan <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
.../Application/UiApp/FrontPageCustomizedUiSupport.c | 8 ++++++--
.../BootMaintenanceManagerCustomizedUiSupport.c | 8 ++++++--
MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | 10 +++++-----
MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 12 ++++++++----
.../Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c | 3 ++-
MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 9 ++++++---
6 files changed, 33 insertions(+), 17 deletions(-)
diff --git a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
index 1505ef9319..17fc3db507 100644
--- a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
+++ b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
@@ -639,9 +639,13 @@ UiListThirdPartyDrivers (
Count++;
if (Count >= CurrentSize) {
- DriverListPtr = AllocateCopyPool ((Count + UI_HII_DRIVER_LIST_SIZE) * sizeof (UI_HII_DRIVER_INSTANCE), gHiiDriverList);
+ DriverListPtr = ReallocatePool (
+ CurrentSize * sizeof (UI_HII_DRIVER_INSTANCE),
+ (Count + UI_HII_DRIVER_LIST_SIZE)
+ * sizeof (UI_HII_DRIVER_INSTANCE),
+ gHiiDriverList
+ );
ASSERT (DriverListPtr != NULL);
- FreePool (gHiiDriverList);
gHiiDriverList = DriverListPtr;
CurrentSize += UI_HII_DRIVER_LIST_SIZE;
}
diff --git a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerCustomizedUiSupport.c b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerCustomizedUiSupport.c
index b25bc67c06..6dd4fce139 100644
--- a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerCustomizedUiSupport.c
+++ b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerCustomizedUiSupport.c
@@ -435,9 +435,13 @@ BmmListThirdPartyDrivers (
Count++;
if (Count >= CurrentSize) {
- DriverListPtr = AllocateCopyPool ((Count + UI_HII_DRIVER_LIST_SIZE) * sizeof (UI_HII_DRIVER_INSTANCE), gHiiDriverList);
+ DriverListPtr = ReallocatePool (
+ CurrentSize * sizeof (UI_HII_DRIVER_INSTANCE),
+ (Count + UI_HII_DRIVER_LIST_SIZE)
+ * sizeof (UI_HII_DRIVER_INSTANCE),
+ gHiiDriverList
+ );
ASSERT (DriverListPtr != NULL);
- FreePool (gHiiDriverList);
gHiiDriverList = DriverListPtr;
CurrentSize += UI_HII_DRIVER_LIST_SIZE;
}
diff --git a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c
index 23ae6c5392..ac8a975bf6 100644
--- a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c
+++ b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c
@@ -240,7 +240,11 @@ AddIdToMacDeviceList (
} else {
mMacDeviceList.MaxListLen += MAX_MAC_ADDRESS_NODE_LIST_LEN;
if (mMacDeviceList.CurListLen != 0) {
- TempDeviceList = (MENU_INFO_ITEM *)AllocateCopyPool (sizeof (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen, (VOID *)mMacDeviceList.NodeList);
+ TempDeviceList = ReallocatePool (
+ sizeof (MENU_INFO_ITEM) * mMacDeviceList.CurListLen,
+ sizeof (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen,
+ mMacDeviceList.NodeList
+ );
} else {
TempDeviceList = (MENU_INFO_ITEM *)AllocatePool (sizeof (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen);
}
@@ -251,10 +255,6 @@ AddIdToMacDeviceList (
TempDeviceList[mMacDeviceList.CurListLen].PromptId = PromptId;
TempDeviceList[mMacDeviceList.CurListLen].QuestionId = (EFI_QUESTION_ID) (mMacDeviceList.CurListLen + NETWORK_DEVICE_LIST_KEY_OFFSET);
- if (mMacDeviceList.CurListLen > 0) {
- FreePool(mMacDeviceList.NodeList);
- }
-
mMacDeviceList.NodeList = TempDeviceList;
}
mMacDeviceList.CurListLen ++;
diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
index ce894c08b5..f9b8c3df27 100644
--- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
+++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
@@ -464,20 +464,24 @@ HiiGetFormSetFromHiiHandle(
}
if (FormSetBuffer != NULL){
- TempBuffer = AllocateCopyPool (TempSize + ((EFI_IFR_OP_HEADER *) OpCodeData)->Length, FormSetBuffer);
- FreePool(FormSetBuffer);
- FormSetBuffer = NULL;
+ TempBuffer = ReallocatePool (
+ TempSize,
+ TempSize + ((EFI_IFR_OP_HEADER *) OpCodeData)->Length,
+ FormSetBuffer
+ );
if (TempBuffer == NULL) {
Status = EFI_OUT_OF_RESOURCES;
goto Done;
}
CopyMem (TempBuffer + TempSize, OpCodeData, ((EFI_IFR_OP_HEADER *) OpCodeData)->Length);
+ FormSetBuffer = NULL;
} else {
- TempBuffer = AllocateCopyPool (TempSize + ((EFI_IFR_OP_HEADER *) OpCodeData)->Length, OpCodeData);
+ TempBuffer = AllocatePool (TempSize + ((EFI_IFR_OP_HEADER *) OpCodeData)->Length);
if (TempBuffer == NULL) {
Status = EFI_OUT_OF_RESOURCES;
goto Done;
}
+ CopyMem (TempBuffer, OpCodeData, ((EFI_IFR_OP_HEADER *) OpCodeData)->Length);
}
TempSize += ((EFI_IFR_OP_HEADER *) OpCodeData)->Length;
FormSetBuffer = TempBuffer;
diff --git a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
index b81110ff98..e39036aed9 100644
--- a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
+++ b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
@@ -562,7 +562,8 @@ FvSimpleFileSystemOpen (
// No, there was no extension. So add one and search again for the file
// NewFileNameLength = FileNameLength + 1 + 4 = (Number of non-null character) + (file extension) + (a null character)
NewFileNameLength = FileNameLength + 1 + 4;
- FileNameWithExtension = AllocateCopyPool (NewFileNameLength * 2, FileName);
+ FileNameWithExtension = AllocatePool (NewFileNameLength * 2);
+ StrCpyS (FileNameWithExtension, NewFileNameLength, FileName);
StrCatS (FileNameWithExtension, NewFileNameLength, L".EFI");
for (FvFileInfoLink = GetFirstNode (&Instance->FileInfoHead);
diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
index 1b48c1cebe..5d5f17fb17 100644
--- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
+++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
@@ -2543,12 +2543,15 @@ MergeToMultiKeywordResp (
MultiKeywordRespLen = (StrLen (*MultiKeywordResp) + 1 + StrLen (*KeywordResp) + 1) * sizeof (CHAR16);
- StringPtr = AllocateCopyPool (MultiKeywordRespLen, *MultiKeywordResp);
+ StringPtr = ReallocatePool (
+ StrSize (*MultiKeywordResp),
+ MultiKeywordRespLen,
+ *MultiKeywordResp
+ );
if (StringPtr == NULL) {
return EFI_OUT_OF_RESOURCES;
}
-
- FreePool (*MultiKeywordResp);
+
*MultiKeywordResp = StringPtr;
StrCatS (StringPtr, MultiKeywordRespLen / sizeof (CHAR16), L"&");
--
2.14.1.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 2/3] ShellPkg: Fix misuses of AllocateCopyPool
2017-11-08 2:11 [PATCH v3 0/3] Fix misuses of AllocateCopyPool Jian J Wang
2017-11-08 2:11 ` [PATCH v3 1/3] MdeModulePkg: " Jian J Wang
@ 2017-11-08 2:12 ` Jian J Wang
2017-11-08 15:50 ` Carsey, Jaben
2017-11-08 2:12 ` [PATCH v3 3/3] IntelFrameworkModulePkg: " Jian J Wang
2 siblings, 1 reply; 10+ messages in thread
From: Jian J Wang @ 2017-11-08 2:12 UTC (permalink / raw)
To: edk2-devel; +Cc: Jaben Carsey, Ruiyu Ni, Bi Dandan
> v3:
> No update
> v2:
> a. Use ReallocatePool instead of allocating then copying wherever applicable
AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of
memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger
than size of "Buffer", heap memory overflow occurs during copy.
One solution is to allocate pool first then copy the necessary bytes to new
memory. Another is using ReallocatePool instead if old buffer will be freed
on spot.
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Bi Dandan <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
ShellPkg/Application/Shell/Shell.c | 4 +++-
ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 7 +++++--
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/ShellPkg/Application/Shell/Shell.c b/ShellPkg/Application/Shell/Shell.c
index 5471930ba1..656206fdce 100644
--- a/ShellPkg/Application/Shell/Shell.c
+++ b/ShellPkg/Application/Shell/Shell.c
@@ -1646,7 +1646,7 @@ ShellConvertVariables (
//
// now do the replacements...
//
- NewCommandLine1 = AllocateCopyPool(NewSize, OriginalCommandLine);
+ NewCommandLine1 = AllocateZeroPool (NewSize);
NewCommandLine2 = AllocateZeroPool(NewSize);
ItemTemp = AllocateZeroPool(ItemSize+(2*sizeof(CHAR16)));
if (NewCommandLine1 == NULL || NewCommandLine2 == NULL || ItemTemp == NULL) {
@@ -1655,6 +1655,8 @@ ShellConvertVariables (
SHELL_FREE_NON_NULL(ItemTemp);
return (NULL);
}
+ CopyMem (NewCommandLine1, OriginalCommandLine, StrSize (OriginalCommandLine));
+
for (MasterEnvList = EfiShellGetEnv(NULL)
; MasterEnvList != NULL && *MasterEnvList != CHAR_NULL
; MasterEnvList += StrLen(MasterEnvList) + 1
diff --git a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
index 1122c89b8b..ee3db63358 100644
--- a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
+++ b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
@@ -143,10 +143,11 @@ UpdateOptionalData(
OriginalOptionDataSize += (*(UINT16*)(OriginalData + sizeof(UINT32)));
OriginalOptionDataSize -= OriginalSize;
NewSize = OriginalSize - OriginalOptionDataSize + DataSize;
- NewData = AllocateCopyPool(NewSize, OriginalData);
+ NewData = AllocatePool(NewSize);
if (NewData == NULL) {
Status = EFI_OUT_OF_RESOURCES;
} else {
+ CopyMem (NewData, OriginalData, OriginalSize - OriginalOptionDataSize);
CopyMem(NewData + OriginalSize - OriginalOptionDataSize, Data, DataSize);
}
}
@@ -1120,11 +1121,13 @@ BcfgAddOpt(
// Now we know how many EFI_INPUT_KEY structs we need to attach to the end of the EFI_KEY_OPTION struct.
// Re-allocate with the added information.
//
- KeyOptionBuffer = AllocateCopyPool(sizeof(EFI_KEY_OPTION) + (sizeof(EFI_INPUT_KEY) * NewKeyOption.KeyData.Options.InputKeyCount), &NewKeyOption);
+ KeyOptionBuffer = AllocatePool (sizeof(EFI_KEY_OPTION) + (sizeof(EFI_INPUT_KEY) * NewKeyOption.KeyData.Options.InputKeyCount));
if (KeyOptionBuffer == NULL) {
ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_NO_MEM), gShellBcfgHiiHandle, L"bcfg");
ShellStatus = SHELL_OUT_OF_RESOURCES;
+ return ShellStatus;
}
+ CopyMem (KeyOptionBuffer, &NewKeyOption, sizeof(EFI_KEY_OPTION));
}
for (LoopCounter = 0 ; ShellStatus == SHELL_SUCCESS && LoopCounter < NewKeyOption.KeyData.Options.InputKeyCount; LoopCounter++) {
//
--
2.14.1.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 3/3] IntelFrameworkModulePkg: Fix misuses of AllocateCopyPool
2017-11-08 2:11 [PATCH v3 0/3] Fix misuses of AllocateCopyPool Jian J Wang
2017-11-08 2:11 ` [PATCH v3 1/3] MdeModulePkg: " Jian J Wang
2017-11-08 2:12 ` [PATCH v3 2/3] ShellPkg: " Jian J Wang
@ 2017-11-08 2:12 ` Jian J Wang
2017-11-08 2:33 ` Bi, Dandan
2 siblings, 1 reply; 10+ messages in thread
From: Jian J Wang @ 2017-11-08 2:12 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao, Bi Dandan
> v3:
> No updates.
> v2:
> a. Use ReallocatePool instead of allocating then copying wherever applicable
AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of
memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger
than size of "Buffer", heap memory overflow occurs during copy.
One solution is to allocate pool first then copy the necessary bytes to new
memory. Another is using ReallocatePool instead if old buffer will be freed
on spot.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Bi Dandan <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
.../Universal/BdsDxe/DeviceMngr/DeviceManager.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/IntelFrameworkModulePkg/Universal/BdsDxe/DeviceMngr/DeviceManager.c b/IntelFrameworkModulePkg/Universal/BdsDxe/DeviceMngr/DeviceManager.c
index 125c49db5e..5103c7e5d1 100644
--- a/IntelFrameworkModulePkg/Universal/BdsDxe/DeviceMngr/DeviceManager.c
+++ b/IntelFrameworkModulePkg/Universal/BdsDxe/DeviceMngr/DeviceManager.c
@@ -480,7 +480,11 @@ AddIdToMacDeviceList (
} else {
mMacDeviceList.MaxListLen += MAX_MAC_ADDRESS_NODE_LIST_LEN;
if (mMacDeviceList.CurListLen != 0) {
- TempDeviceList = (MENU_INFO_ITEM *)AllocateCopyPool (sizeof (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen, (VOID *)mMacDeviceList.NodeList);
+ TempDeviceList = ReallocatePool (
+ sizeof (MENU_INFO_ITEM) * mMacDeviceList.CurListLen,
+ sizeof (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen,
+ mMacDeviceList.NodeList
+ );
} else {
TempDeviceList = (MENU_INFO_ITEM *)AllocatePool (sizeof (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen);
}
@@ -491,10 +495,6 @@ AddIdToMacDeviceList (
TempDeviceList[mMacDeviceList.CurListLen].PromptId = PromptId;
TempDeviceList[mMacDeviceList.CurListLen].QuestionId = (EFI_QUESTION_ID) (mMacDeviceList.CurListLen + NETWORK_DEVICE_LIST_KEY_OFFSET);
- if (mMacDeviceList.CurListLen > 0) {
- FreePool(mMacDeviceList.NodeList);
- }
-
mMacDeviceList.NodeList = TempDeviceList;
}
mMacDeviceList.CurListLen ++;
--
2.14.1.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v3 3/3] IntelFrameworkModulePkg: Fix misuses of AllocateCopyPool
2017-11-08 2:12 ` [PATCH v3 3/3] IntelFrameworkModulePkg: " Jian J Wang
@ 2017-11-08 2:33 ` Bi, Dandan
0 siblings, 0 replies; 10+ messages in thread
From: Bi, Dandan @ 2017-11-08 2:33 UTC (permalink / raw)
To: Wang, Jian J, edk2-devel@lists.01.org; +Cc: Gao, Liming
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Thanks,
Dandan
-----Original Message-----
From: Wang, Jian J
Sent: Wednesday, November 8, 2017 10:12 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>
Subject: [PATCH v3 3/3] IntelFrameworkModulePkg: Fix misuses of AllocateCopyPool
> v3:
> No updates.
> v2:
> a. Use ReallocatePool instead of allocating then copying wherever
> applicable
AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger than size of "Buffer", heap memory overflow occurs during copy.
One solution is to allocate pool first then copy the necessary bytes to new memory. Another is using ReallocatePool instead if old buffer will be freed on spot.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Bi Dandan <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
.../Universal/BdsDxe/DeviceMngr/DeviceManager.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/IntelFrameworkModulePkg/Universal/BdsDxe/DeviceMngr/DeviceManager.c b/IntelFrameworkModulePkg/Universal/BdsDxe/DeviceMngr/DeviceManager.c
index 125c49db5e..5103c7e5d1 100644
--- a/IntelFrameworkModulePkg/Universal/BdsDxe/DeviceMngr/DeviceManager.c
+++ b/IntelFrameworkModulePkg/Universal/BdsDxe/DeviceMngr/DeviceManager.
+++ c
@@ -480,7 +480,11 @@ AddIdToMacDeviceList (
} else {
mMacDeviceList.MaxListLen += MAX_MAC_ADDRESS_NODE_LIST_LEN;
if (mMacDeviceList.CurListLen != 0) {
- TempDeviceList = (MENU_INFO_ITEM *)AllocateCopyPool (sizeof (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen, (VOID *)mMacDeviceList.NodeList);
+ TempDeviceList = ReallocatePool (
+ sizeof (MENU_INFO_ITEM) * mMacDeviceList.CurListLen,
+ sizeof (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen,
+ mMacDeviceList.NodeList
+ );
} else {
TempDeviceList = (MENU_INFO_ITEM *)AllocatePool (sizeof (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen);
}
@@ -491,10 +495,6 @@ AddIdToMacDeviceList (
TempDeviceList[mMacDeviceList.CurListLen].PromptId = PromptId;
TempDeviceList[mMacDeviceList.CurListLen].QuestionId = (EFI_QUESTION_ID) (mMacDeviceList.CurListLen + NETWORK_DEVICE_LIST_KEY_OFFSET);
- if (mMacDeviceList.CurListLen > 0) {
- FreePool(mMacDeviceList.NodeList);
- }
-
mMacDeviceList.NodeList = TempDeviceList;
}
mMacDeviceList.CurListLen ++;
--
2.14.1.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool
2017-11-08 2:11 ` [PATCH v3 1/3] MdeModulePkg: " Jian J Wang
@ 2017-11-08 2:37 ` Zeng, Star
2017-11-08 2:46 ` Wang, Jian J
0 siblings, 1 reply; 10+ messages in thread
From: Zeng, Star @ 2017-11-08 2:37 UTC (permalink / raw)
To: Wang, Jian J, edk2-devel@lists.01.org; +Cc: Dong, Eric, Bi, Dandan, Zeng, Star
In FrontPageCustomizedUiSupport.c, suggest to use "(CurrentSize + UI_HII_DRIVER_LIST_SIZE)" instead of "(Count + UI_HII_DRIVER_LIST_SIZE)" to be consistent with the following code "CurrentSize += UI_HII_DRIVER_LIST_SIZE".
Same comment to BootMaintenanceManagerCustomizedUiSupport.c
In HiiLib.c, suggest removing "FormSetBuffer = NULL".
And the code logic below in HiiLib.c is strange and suggest refining the code.
TempBuffer = AllocatePool (TempSize + ((EFI_IFR_OP_HEADER *) OpCodeData)->Length);
...
CopyMem (TempBuffer, OpCodeData, ((EFI_IFR_OP_HEADER *) OpCodeData)->Length);
Thanks,
Star
-----Original Message-----
From: Wang, Jian J
Sent: Wednesday, November 8, 2017 10:12 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; Bi, Dandan <dandan.bi@intel.com>
Subject: [PATCH v3 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool
>v3:
> a. Add ASSERT for returned pointer
> b. Correct DestMax parameter in calling StrCpyS
> c. Fix coding style
>v2:
> a. Use ReallocatePool to replace AllocateCopyPool wherever applicable.
AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of
memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger
than size of "Buffer", heap memory overflow occurs during copy.
One solution is to allocate pool first then copy the necessary bytes to new
memory. Another is using ReallocatePool instead if old buffer will be freed
on spot.
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Bi Dandan <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
.../Application/UiApp/FrontPageCustomizedUiSupport.c | 8 ++++++--
.../BootMaintenanceManagerCustomizedUiSupport.c | 8 ++++++--
MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | 10 +++++-----
MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 12 ++++++++----
.../Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c | 3 ++-
MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 9 ++++++---
6 files changed, 33 insertions(+), 17 deletions(-)
diff --git a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
index 1505ef9319..17fc3db507 100644
--- a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
+++ b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
@@ -639,9 +639,13 @@ UiListThirdPartyDrivers (
Count++;
if (Count >= CurrentSize) {
- DriverListPtr = AllocateCopyPool ((Count + UI_HII_DRIVER_LIST_SIZE) * sizeof (UI_HII_DRIVER_INSTANCE), gHiiDriverList);
+ DriverListPtr = ReallocatePool (
+ CurrentSize * sizeof (UI_HII_DRIVER_INSTANCE),
+ (Count + UI_HII_DRIVER_LIST_SIZE)
+ * sizeof (UI_HII_DRIVER_INSTANCE),
+ gHiiDriverList
+ );
ASSERT (DriverListPtr != NULL);
- FreePool (gHiiDriverList);
gHiiDriverList = DriverListPtr;
CurrentSize += UI_HII_DRIVER_LIST_SIZE;
}
diff --git a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerCustomizedUiSupport.c b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerCustomizedUiSupport.c
index b25bc67c06..6dd4fce139 100644
--- a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerCustomizedUiSupport.c
+++ b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerCustomizedUiSupport.c
@@ -435,9 +435,13 @@ BmmListThirdPartyDrivers (
Count++;
if (Count >= CurrentSize) {
- DriverListPtr = AllocateCopyPool ((Count + UI_HII_DRIVER_LIST_SIZE) * sizeof (UI_HII_DRIVER_INSTANCE), gHiiDriverList);
+ DriverListPtr = ReallocatePool (
+ CurrentSize * sizeof (UI_HII_DRIVER_INSTANCE),
+ (Count + UI_HII_DRIVER_LIST_SIZE)
+ * sizeof (UI_HII_DRIVER_INSTANCE),
+ gHiiDriverList
+ );
ASSERT (DriverListPtr != NULL);
- FreePool (gHiiDriverList);
gHiiDriverList = DriverListPtr;
CurrentSize += UI_HII_DRIVER_LIST_SIZE;
}
diff --git a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c
index 23ae6c5392..ac8a975bf6 100644
--- a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c
+++ b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c
@@ -240,7 +240,11 @@ AddIdToMacDeviceList (
} else {
mMacDeviceList.MaxListLen += MAX_MAC_ADDRESS_NODE_LIST_LEN;
if (mMacDeviceList.CurListLen != 0) {
- TempDeviceList = (MENU_INFO_ITEM *)AllocateCopyPool (sizeof (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen, (VOID *)mMacDeviceList.NodeList);
+ TempDeviceList = ReallocatePool (
+ sizeof (MENU_INFO_ITEM) * mMacDeviceList.CurListLen,
+ sizeof (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen,
+ mMacDeviceList.NodeList
+ );
} else {
TempDeviceList = (MENU_INFO_ITEM *)AllocatePool (sizeof (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen);
}
@@ -251,10 +255,6 @@ AddIdToMacDeviceList (
TempDeviceList[mMacDeviceList.CurListLen].PromptId = PromptId;
TempDeviceList[mMacDeviceList.CurListLen].QuestionId = (EFI_QUESTION_ID) (mMacDeviceList.CurListLen + NETWORK_DEVICE_LIST_KEY_OFFSET);
- if (mMacDeviceList.CurListLen > 0) {
- FreePool(mMacDeviceList.NodeList);
- }
-
mMacDeviceList.NodeList = TempDeviceList;
}
mMacDeviceList.CurListLen ++;
diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
index ce894c08b5..f9b8c3df27 100644
--- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
+++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
@@ -464,20 +464,24 @@ HiiGetFormSetFromHiiHandle(
}
if (FormSetBuffer != NULL){
- TempBuffer = AllocateCopyPool (TempSize + ((EFI_IFR_OP_HEADER *) OpCodeData)->Length, FormSetBuffer);
- FreePool(FormSetBuffer);
- FormSetBuffer = NULL;
+ TempBuffer = ReallocatePool (
+ TempSize,
+ TempSize + ((EFI_IFR_OP_HEADER *) OpCodeData)->Length,
+ FormSetBuffer
+ );
if (TempBuffer == NULL) {
Status = EFI_OUT_OF_RESOURCES;
goto Done;
}
CopyMem (TempBuffer + TempSize, OpCodeData, ((EFI_IFR_OP_HEADER *) OpCodeData)->Length);
+ FormSetBuffer = NULL;
} else {
- TempBuffer = AllocateCopyPool (TempSize + ((EFI_IFR_OP_HEADER *) OpCodeData)->Length, OpCodeData);
+ TempBuffer = AllocatePool (TempSize + ((EFI_IFR_OP_HEADER *) OpCodeData)->Length);
if (TempBuffer == NULL) {
Status = EFI_OUT_OF_RESOURCES;
goto Done;
}
+ CopyMem (TempBuffer, OpCodeData, ((EFI_IFR_OP_HEADER *) OpCodeData)->Length);
}
TempSize += ((EFI_IFR_OP_HEADER *) OpCodeData)->Length;
FormSetBuffer = TempBuffer;
diff --git a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
index b81110ff98..e39036aed9 100644
--- a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
+++ b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
@@ -562,7 +562,8 @@ FvSimpleFileSystemOpen (
// No, there was no extension. So add one and search again for the file
// NewFileNameLength = FileNameLength + 1 + 4 = (Number of non-null character) + (file extension) + (a null character)
NewFileNameLength = FileNameLength + 1 + 4;
- FileNameWithExtension = AllocateCopyPool (NewFileNameLength * 2, FileName);
+ FileNameWithExtension = AllocatePool (NewFileNameLength * 2);
+ StrCpyS (FileNameWithExtension, NewFileNameLength, FileName);
StrCatS (FileNameWithExtension, NewFileNameLength, L".EFI");
for (FvFileInfoLink = GetFirstNode (&Instance->FileInfoHead);
diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
index 1b48c1cebe..5d5f17fb17 100644
--- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
+++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
@@ -2543,12 +2543,15 @@ MergeToMultiKeywordResp (
MultiKeywordRespLen = (StrLen (*MultiKeywordResp) + 1 + StrLen (*KeywordResp) + 1) * sizeof (CHAR16);
- StringPtr = AllocateCopyPool (MultiKeywordRespLen, *MultiKeywordResp);
+ StringPtr = ReallocatePool (
+ StrSize (*MultiKeywordResp),
+ MultiKeywordRespLen,
+ *MultiKeywordResp
+ );
if (StringPtr == NULL) {
return EFI_OUT_OF_RESOURCES;
}
-
- FreePool (*MultiKeywordResp);
+
*MultiKeywordResp = StringPtr;
StrCatS (StringPtr, MultiKeywordRespLen / sizeof (CHAR16), L"&");
--
2.14.1.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v3 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool
2017-11-08 2:37 ` Zeng, Star
@ 2017-11-08 2:46 ` Wang, Jian J
2017-11-08 2:57 ` Zeng, Star
0 siblings, 1 reply; 10+ messages in thread
From: Wang, Jian J @ 2017-11-08 2:46 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org; +Cc: Dong, Eric, Bi, Dandan
Hi Star,
I agree the issues you mentioned. But they're already there before this patch.
I'd suggest to file a new bug tracker for them instead of fixing them in this one.
Thanks,
Jian
> -----Original Message-----
> From: Zeng, Star
> Sent: Wednesday, November 08, 2017 10:38 AM
> To: Wang, Jian J <jian.j.wang@intel.com>; edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Bi, Dandan <dandan.bi@intel.com>;
> Zeng, Star <star.zeng@intel.com>
> Subject: RE: [PATCH v3 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool
>
> In FrontPageCustomizedUiSupport.c, suggest to use "(CurrentSize +
> UI_HII_DRIVER_LIST_SIZE)" instead of "(Count + UI_HII_DRIVER_LIST_SIZE)" to
> be consistent with the following code "CurrentSize +=
> UI_HII_DRIVER_LIST_SIZE".
>
> Same comment to BootMaintenanceManagerCustomizedUiSupport.c
>
> In HiiLib.c, suggest removing "FormSetBuffer = NULL".
> And the code logic below in HiiLib.c is strange and suggest refining the code.
> TempBuffer = AllocatePool (TempSize + ((EFI_IFR_OP_HEADER *) OpCodeData)-
> >Length);
> ...
> CopyMem (TempBuffer, OpCodeData, ((EFI_IFR_OP_HEADER *) OpCodeData)-
> >Length);
>
>
> Thanks,
> Star
> -----Original Message-----
> From: Wang, Jian J
> Sent: Wednesday, November 8, 2017 10:12 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; Bi,
> Dandan <dandan.bi@intel.com>
> Subject: [PATCH v3 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool
>
> >v3:
> > a. Add ASSERT for returned pointer
> > b. Correct DestMax parameter in calling StrCpyS
> > c. Fix coding style
>
> >v2:
> > a. Use ReallocatePool to replace AllocateCopyPool wherever applicable.
>
> AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of
> memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger
> than size of "Buffer", heap memory overflow occurs during copy.
>
> One solution is to allocate pool first then copy the necessary bytes to new
> memory. Another is using ReallocatePool instead if old buffer will be freed
> on spot.
>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Bi Dandan <dandan.bi@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> ---
> .../Application/UiApp/FrontPageCustomizedUiSupport.c | 8 ++++++--
> .../BootMaintenanceManagerCustomizedUiSupport.c | 8 ++++++--
> MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | 10 +++++--
> ---
> MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 12 ++++++++----
> .../Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c | 3 ++-
> MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 9
> ++++++---
> 6 files changed, 33 insertions(+), 17 deletions(-)
>
> diff --git a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
> b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
> index 1505ef9319..17fc3db507 100644
> --- a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
> +++ b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
> @@ -639,9 +639,13 @@ UiListThirdPartyDrivers (
>
> Count++;
> if (Count >= CurrentSize) {
> - DriverListPtr = AllocateCopyPool ((Count + UI_HII_DRIVER_LIST_SIZE) *
> sizeof (UI_HII_DRIVER_INSTANCE), gHiiDriverList);
> + DriverListPtr = ReallocatePool (
> + CurrentSize * sizeof (UI_HII_DRIVER_INSTANCE),
> + (Count + UI_HII_DRIVER_LIST_SIZE)
> + * sizeof (UI_HII_DRIVER_INSTANCE),
> + gHiiDriverList
> + );
> ASSERT (DriverListPtr != NULL);
> - FreePool (gHiiDriverList);
> gHiiDriverList = DriverListPtr;
> CurrentSize += UI_HII_DRIVER_LIST_SIZE;
> }
> diff --git
> a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceM
> anagerCustomizedUiSupport.c
> b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceM
> anagerCustomizedUiSupport.c
> index b25bc67c06..6dd4fce139 100644
> ---
> a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceM
> anagerCustomizedUiSupport.c
> +++
> b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceM
> anagerCustomizedUiSupport.c
> @@ -435,9 +435,13 @@ BmmListThirdPartyDrivers (
>
> Count++;
> if (Count >= CurrentSize) {
> - DriverListPtr = AllocateCopyPool ((Count + UI_HII_DRIVER_LIST_SIZE) *
> sizeof (UI_HII_DRIVER_INSTANCE), gHiiDriverList);
> + DriverListPtr = ReallocatePool (
> + CurrentSize * sizeof (UI_HII_DRIVER_INSTANCE),
> + (Count + UI_HII_DRIVER_LIST_SIZE)
> + * sizeof (UI_HII_DRIVER_INSTANCE),
> + gHiiDriverList
> + );
> ASSERT (DriverListPtr != NULL);
> - FreePool (gHiiDriverList);
> gHiiDriverList = DriverListPtr;
> CurrentSize += UI_HII_DRIVER_LIST_SIZE;
> }
> diff --git a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c
> b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c
> index 23ae6c5392..ac8a975bf6 100644
> --- a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c
> +++ b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c
> @@ -240,7 +240,11 @@ AddIdToMacDeviceList (
> } else {
> mMacDeviceList.MaxListLen += MAX_MAC_ADDRESS_NODE_LIST_LEN;
> if (mMacDeviceList.CurListLen != 0) {
> - TempDeviceList = (MENU_INFO_ITEM *)AllocateCopyPool (sizeof
> (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen, (VOID
> *)mMacDeviceList.NodeList);
> + TempDeviceList = ReallocatePool (
> + sizeof (MENU_INFO_ITEM) * mMacDeviceList.CurListLen,
> + sizeof (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen,
> + mMacDeviceList.NodeList
> + );
> } else {
> TempDeviceList = (MENU_INFO_ITEM *)AllocatePool (sizeof
> (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen);
> }
> @@ -251,10 +255,6 @@ AddIdToMacDeviceList (
> TempDeviceList[mMacDeviceList.CurListLen].PromptId = PromptId;
> TempDeviceList[mMacDeviceList.CurListLen].QuestionId =
> (EFI_QUESTION_ID) (mMacDeviceList.CurListLen +
> NETWORK_DEVICE_LIST_KEY_OFFSET);
>
> - if (mMacDeviceList.CurListLen > 0) {
> - FreePool(mMacDeviceList.NodeList);
> - }
> -
> mMacDeviceList.NodeList = TempDeviceList;
> }
> mMacDeviceList.CurListLen ++;
> diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> index ce894c08b5..f9b8c3df27 100644
> --- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> +++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> @@ -464,20 +464,24 @@ HiiGetFormSetFromHiiHandle(
> }
>
> if (FormSetBuffer != NULL){
> - TempBuffer = AllocateCopyPool (TempSize + ((EFI_IFR_OP_HEADER *)
> OpCodeData)->Length, FormSetBuffer);
> - FreePool(FormSetBuffer);
> - FormSetBuffer = NULL;
> + TempBuffer = ReallocatePool (
> + TempSize,
> + TempSize + ((EFI_IFR_OP_HEADER *) OpCodeData)->Length,
> + FormSetBuffer
> + );
> if (TempBuffer == NULL) {
> Status = EFI_OUT_OF_RESOURCES;
> goto Done;
> }
> CopyMem (TempBuffer + TempSize, OpCodeData, ((EFI_IFR_OP_HEADER *)
> OpCodeData)->Length);
> + FormSetBuffer = NULL;
> } else {
> - TempBuffer = AllocateCopyPool (TempSize + ((EFI_IFR_OP_HEADER *)
> OpCodeData)->Length, OpCodeData);
> + TempBuffer = AllocatePool (TempSize + ((EFI_IFR_OP_HEADER *)
> OpCodeData)->Length);
> if (TempBuffer == NULL) {
> Status = EFI_OUT_OF_RESOURCES;
> goto Done;
> }
> + CopyMem (TempBuffer, OpCodeData, ((EFI_IFR_OP_HEADER *)
> OpCodeData)->Length);
> }
> TempSize += ((EFI_IFR_OP_HEADER *) OpCodeData)->Length;
> FormSetBuffer = TempBuffer;
> diff --git
> a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
> b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
> index b81110ff98..e39036aed9 100644
> --- a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
> +++ b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
> @@ -562,7 +562,8 @@ FvSimpleFileSystemOpen (
> // No, there was no extension. So add one and search again for the file
> // NewFileNameLength = FileNameLength + 1 + 4 = (Number of non-null
> character) + (file extension) + (a null character)
> NewFileNameLength = FileNameLength + 1 + 4;
> - FileNameWithExtension = AllocateCopyPool (NewFileNameLength * 2,
> FileName);
> + FileNameWithExtension = AllocatePool (NewFileNameLength * 2);
> + StrCpyS (FileNameWithExtension, NewFileNameLength, FileName);
> StrCatS (FileNameWithExtension, NewFileNameLength, L".EFI");
>
> for (FvFileInfoLink = GetFirstNode (&Instance->FileInfoHead);
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
> index 1b48c1cebe..5d5f17fb17 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
> @@ -2543,12 +2543,15 @@ MergeToMultiKeywordResp (
>
> MultiKeywordRespLen = (StrLen (*MultiKeywordResp) + 1 + StrLen
> (*KeywordResp) + 1) * sizeof (CHAR16);
>
> - StringPtr = AllocateCopyPool (MultiKeywordRespLen, *MultiKeywordResp);
> + StringPtr = ReallocatePool (
> + StrSize (*MultiKeywordResp),
> + MultiKeywordRespLen,
> + *MultiKeywordResp
> + );
> if (StringPtr == NULL) {
> return EFI_OUT_OF_RESOURCES;
> }
> -
> - FreePool (*MultiKeywordResp);
> +
> *MultiKeywordResp = StringPtr;
>
> StrCatS (StringPtr, MultiKeywordRespLen / sizeof (CHAR16), L"&");
> --
> 2.14.1.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool
2017-11-08 2:46 ` Wang, Jian J
@ 2017-11-08 2:57 ` Zeng, Star
0 siblings, 0 replies; 10+ messages in thread
From: Zeng, Star @ 2017-11-08 2:57 UTC (permalink / raw)
To: Wang, Jian J, edk2-devel@lists.01.org; +Cc: Dong, Eric, Bi, Dandan, Zeng, Star
Fine, https://bugzilla.tianocore.org/show_bug.cgi?id=762 is submitted.
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: Wang, Jian J
Sent: Wednesday, November 8, 2017 10:46 AM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>; Bi, Dandan <dandan.bi@intel.com>
Subject: RE: [PATCH v3 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool
Hi Star,
I agree the issues you mentioned. But they're already there before this patch.
I'd suggest to file a new bug tracker for them instead of fixing them in this one.
Thanks,
Jian
> -----Original Message-----
> From: Zeng, Star
> Sent: Wednesday, November 08, 2017 10:38 AM
> To: Wang, Jian J <jian.j.wang@intel.com>; edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Bi, Dandan
> <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: RE: [PATCH v3 1/3] MdeModulePkg: Fix misuses of
> AllocateCopyPool
>
> In FrontPageCustomizedUiSupport.c, suggest to use "(CurrentSize +
> UI_HII_DRIVER_LIST_SIZE)" instead of "(Count +
> UI_HII_DRIVER_LIST_SIZE)" to be consistent with the following code
> "CurrentSize += UI_HII_DRIVER_LIST_SIZE".
>
> Same comment to BootMaintenanceManagerCustomizedUiSupport.c
>
> In HiiLib.c, suggest removing "FormSetBuffer = NULL".
> And the code logic below in HiiLib.c is strange and suggest refining the code.
> TempBuffer = AllocatePool (TempSize + ((EFI_IFR_OP_HEADER *)
> OpCodeData)-
> >Length);
> ...
> CopyMem (TempBuffer, OpCodeData, ((EFI_IFR_OP_HEADER *) OpCodeData)-
> >Length);
>
>
> Thanks,
> Star
> -----Original Message-----
> From: Wang, Jian J
> Sent: Wednesday, November 8, 2017 10:12 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric
> <eric.dong@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Subject: [PATCH v3 1/3] MdeModulePkg: Fix misuses of AllocateCopyPool
>
> >v3:
> > a. Add ASSERT for returned pointer
> > b. Correct DestMax parameter in calling StrCpyS c. Fix coding style
>
> >v2:
> > a. Use ReallocatePool to replace AllocateCopyPool wherever applicable.
>
> AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize"
> bytes of memory from old "Buffer" to new allocated one. If
> "AllocationSize" is bigger than size of "Buffer", heap memory overflow occurs during copy.
>
> One solution is to allocate pool first then copy the necessary bytes
> to new memory. Another is using ReallocatePool instead if old buffer
> will be freed on spot.
>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Bi Dandan <dandan.bi@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> ---
> .../Application/UiApp/FrontPageCustomizedUiSupport.c | 8 ++++++--
> .../BootMaintenanceManagerCustomizedUiSupport.c | 8 ++++++--
> MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | 10 +++++--
> ---
> MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 12 ++++++++----
> .../Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c | 3 ++-
> MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 9
> ++++++---
> 6 files changed, 33 insertions(+), 17 deletions(-)
>
> diff --git
> a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
> b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
> index 1505ef9319..17fc3db507 100644
> --- a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
> +++ b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
> @@ -639,9 +639,13 @@ UiListThirdPartyDrivers (
>
> Count++;
> if (Count >= CurrentSize) {
> - DriverListPtr = AllocateCopyPool ((Count + UI_HII_DRIVER_LIST_SIZE) *
> sizeof (UI_HII_DRIVER_INSTANCE), gHiiDriverList);
> + DriverListPtr = ReallocatePool (
> + CurrentSize * sizeof (UI_HII_DRIVER_INSTANCE),
> + (Count + UI_HII_DRIVER_LIST_SIZE)
> + * sizeof (UI_HII_DRIVER_INSTANCE),
> + gHiiDriverList
> + );
> ASSERT (DriverListPtr != NULL);
> - FreePool (gHiiDriverList);
> gHiiDriverList = DriverListPtr;
> CurrentSize += UI_HII_DRIVER_LIST_SIZE;
> }
> diff --git
> a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceM
> anagerCustomizedUiSupport.c
> b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceM
> anagerCustomizedUiSupport.c
> index b25bc67c06..6dd4fce139 100644
> ---
> a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceM
> anagerCustomizedUiSupport.c
> +++
> b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceM
> anagerCustomizedUiSupport.c
> @@ -435,9 +435,13 @@ BmmListThirdPartyDrivers (
>
> Count++;
> if (Count >= CurrentSize) {
> - DriverListPtr = AllocateCopyPool ((Count + UI_HII_DRIVER_LIST_SIZE) *
> sizeof (UI_HII_DRIVER_INSTANCE), gHiiDriverList);
> + DriverListPtr = ReallocatePool (
> + CurrentSize * sizeof (UI_HII_DRIVER_INSTANCE),
> + (Count + UI_HII_DRIVER_LIST_SIZE)
> + * sizeof (UI_HII_DRIVER_INSTANCE),
> + gHiiDriverList
> + );
> ASSERT (DriverListPtr != NULL);
> - FreePool (gHiiDriverList);
> gHiiDriverList = DriverListPtr;
> CurrentSize += UI_HII_DRIVER_LIST_SIZE;
> }
> diff --git a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c
> b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c
> index 23ae6c5392..ac8a975bf6 100644
> --- a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c
> +++ b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c
> @@ -240,7 +240,11 @@ AddIdToMacDeviceList (
> } else {
> mMacDeviceList.MaxListLen += MAX_MAC_ADDRESS_NODE_LIST_LEN;
> if (mMacDeviceList.CurListLen != 0) {
> - TempDeviceList = (MENU_INFO_ITEM *)AllocateCopyPool (sizeof
> (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen, (VOID
> *)mMacDeviceList.NodeList);
> + TempDeviceList = ReallocatePool (
> + sizeof (MENU_INFO_ITEM) * mMacDeviceList.CurListLen,
> + sizeof (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen,
> + mMacDeviceList.NodeList
> + );
> } else {
> TempDeviceList = (MENU_INFO_ITEM *)AllocatePool (sizeof
> (MENU_INFO_ITEM) * mMacDeviceList.MaxListLen);
> }
> @@ -251,10 +255,6 @@ AddIdToMacDeviceList (
> TempDeviceList[mMacDeviceList.CurListLen].PromptId = PromptId;
> TempDeviceList[mMacDeviceList.CurListLen].QuestionId =
> (EFI_QUESTION_ID) (mMacDeviceList.CurListLen +
> NETWORK_DEVICE_LIST_KEY_OFFSET);
>
> - if (mMacDeviceList.CurListLen > 0) {
> - FreePool(mMacDeviceList.NodeList);
> - }
> -
> mMacDeviceList.NodeList = TempDeviceList;
> }
> mMacDeviceList.CurListLen ++;
> diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> index ce894c08b5..f9b8c3df27 100644
> --- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> +++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> @@ -464,20 +464,24 @@ HiiGetFormSetFromHiiHandle(
> }
>
> if (FormSetBuffer != NULL){
> - TempBuffer = AllocateCopyPool (TempSize + ((EFI_IFR_OP_HEADER *)
> OpCodeData)->Length, FormSetBuffer);
> - FreePool(FormSetBuffer);
> - FormSetBuffer = NULL;
> + TempBuffer = ReallocatePool (
> + TempSize,
> + TempSize + ((EFI_IFR_OP_HEADER *) OpCodeData)->Length,
> + FormSetBuffer
> + );
> if (TempBuffer == NULL) {
> Status = EFI_OUT_OF_RESOURCES;
> goto Done;
> }
> CopyMem (TempBuffer + TempSize, OpCodeData,
> ((EFI_IFR_OP_HEADER *) OpCodeData)->Length);
> + FormSetBuffer = NULL;
> } else {
> - TempBuffer = AllocateCopyPool (TempSize + ((EFI_IFR_OP_HEADER *)
> OpCodeData)->Length, OpCodeData);
> + TempBuffer = AllocatePool (TempSize + ((EFI_IFR_OP_HEADER *)
> OpCodeData)->Length);
> if (TempBuffer == NULL) {
> Status = EFI_OUT_OF_RESOURCES;
> goto Done;
> }
> + CopyMem (TempBuffer, OpCodeData, ((EFI_IFR_OP_HEADER *)
> OpCodeData)->Length);
> }
> TempSize += ((EFI_IFR_OP_HEADER *) OpCodeData)->Length;
> FormSetBuffer = TempBuffer;
> diff --git
> a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
> b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
> index b81110ff98..e39036aed9 100644
> ---
> a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
> +++ b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.
> +++ c
> @@ -562,7 +562,8 @@ FvSimpleFileSystemOpen (
> // No, there was no extension. So add one and search again for the file
> // NewFileNameLength = FileNameLength + 1 + 4 = (Number of
> non-null
> character) + (file extension) + (a null character)
> NewFileNameLength = FileNameLength + 1 + 4;
> - FileNameWithExtension = AllocateCopyPool (NewFileNameLength * 2,
> FileName);
> + FileNameWithExtension = AllocatePool (NewFileNameLength * 2);
> + StrCpyS (FileNameWithExtension, NewFileNameLength, FileName);
> StrCatS (FileNameWithExtension, NewFileNameLength, L".EFI");
>
> for (FvFileInfoLink = GetFirstNode (&Instance->FileInfoHead);
> diff --git
> a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
> index 1b48c1cebe..5d5f17fb17 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c
> @@ -2543,12 +2543,15 @@ MergeToMultiKeywordResp (
>
> MultiKeywordRespLen = (StrLen (*MultiKeywordResp) + 1 + StrLen
> (*KeywordResp) + 1) * sizeof (CHAR16);
>
> - StringPtr = AllocateCopyPool (MultiKeywordRespLen,
> *MultiKeywordResp);
> + StringPtr = ReallocatePool (
> + StrSize (*MultiKeywordResp),
> + MultiKeywordRespLen,
> + *MultiKeywordResp
> + );
> if (StringPtr == NULL) {
> return EFI_OUT_OF_RESOURCES;
> }
> -
> - FreePool (*MultiKeywordResp);
> +
> *MultiKeywordResp = StringPtr;
>
> StrCatS (StringPtr, MultiKeywordRespLen / sizeof (CHAR16), L"&");
> --
> 2.14.1.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 2/3] ShellPkg: Fix misuses of AllocateCopyPool
2017-11-08 2:12 ` [PATCH v3 2/3] ShellPkg: " Jian J Wang
@ 2017-11-08 15:50 ` Carsey, Jaben
2017-11-09 1:03 ` Wang, Jian J
0 siblings, 1 reply; 10+ messages in thread
From: Carsey, Jaben @ 2017-11-08 15:50 UTC (permalink / raw)
To: Wang, Jian J, edk2-devel@lists.01.org; +Cc: Ni, Ruiyu, Bi, Dandan
Why not use the StrCpy_s function to copy strings? CopyMem and StrSize feels odd to me.
> -----Original Message-----
> From: Wang, Jian J
> Sent: Tuesday, November 07, 2017 6:12 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu
> <ruiyu.ni@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Subject: [PATCH v3 2/3] ShellPkg: Fix misuses of AllocateCopyPool
> Importance: High
>
> > v3:
> > No update
>
> > v2:
> > a. Use ReallocatePool instead of allocating then copying wherever
> applicable
>
> AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of
> memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger
> than size of "Buffer", heap memory overflow occurs during copy.
>
> One solution is to allocate pool first then copy the necessary bytes to new
> memory. Another is using ReallocatePool instead if old buffer will be freed
> on spot.
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Bi Dandan <dandan.bi@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> ---
> ShellPkg/Application/Shell/Shell.c | 4 +++-
> ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 7
> +++++--
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/ShellPkg/Application/Shell/Shell.c
> b/ShellPkg/Application/Shell/Shell.c
> index 5471930ba1..656206fdce 100644
> --- a/ShellPkg/Application/Shell/Shell.c
> +++ b/ShellPkg/Application/Shell/Shell.c
> @@ -1646,7 +1646,7 @@ ShellConvertVariables (
> //
> // now do the replacements...
> //
> - NewCommandLine1 = AllocateCopyPool(NewSize, OriginalCommandLine);
> + NewCommandLine1 = AllocateZeroPool (NewSize);
> NewCommandLine2 = AllocateZeroPool(NewSize);
> ItemTemp = AllocateZeroPool(ItemSize+(2*sizeof(CHAR16)));
> if (NewCommandLine1 == NULL || NewCommandLine2 == NULL ||
> ItemTemp == NULL) {
> @@ -1655,6 +1655,8 @@ ShellConvertVariables (
> SHELL_FREE_NON_NULL(ItemTemp);
> return (NULL);
> }
> + CopyMem (NewCommandLine1, OriginalCommandLine, StrSize
> (OriginalCommandLine));
> +
> for (MasterEnvList = EfiShellGetEnv(NULL)
> ; MasterEnvList != NULL && *MasterEnvList != CHAR_NULL
> ; MasterEnvList += StrLen(MasterEnvList) + 1
> diff --git
> a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> index 1122c89b8b..ee3db63358 100644
> ---
> a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> +++
> b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> @@ -143,10 +143,11 @@ UpdateOptionalData(
> OriginalOptionDataSize += (*(UINT16*)(OriginalData + sizeof(UINT32)));
> OriginalOptionDataSize -= OriginalSize;
> NewSize = OriginalSize - OriginalOptionDataSize + DataSize;
> - NewData = AllocateCopyPool(NewSize, OriginalData);
> + NewData = AllocatePool(NewSize);
> if (NewData == NULL) {
> Status = EFI_OUT_OF_RESOURCES;
> } else {
> + CopyMem (NewData, OriginalData, OriginalSize -
> OriginalOptionDataSize);
> CopyMem(NewData + OriginalSize - OriginalOptionDataSize, Data,
> DataSize);
> }
> }
> @@ -1120,11 +1121,13 @@ BcfgAddOpt(
> // Now we know how many EFI_INPUT_KEY structs we need to attach to
> the end of the EFI_KEY_OPTION struct.
> // Re-allocate with the added information.
> //
> - KeyOptionBuffer = AllocateCopyPool(sizeof(EFI_KEY_OPTION) +
> (sizeof(EFI_INPUT_KEY) * NewKeyOption.KeyData.Options.InputKeyCount),
> &NewKeyOption);
> + KeyOptionBuffer = AllocatePool (sizeof(EFI_KEY_OPTION) +
> (sizeof(EFI_INPUT_KEY) *
> NewKeyOption.KeyData.Options.InputKeyCount));
> if (KeyOptionBuffer == NULL) {
> ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_NO_MEM),
> gShellBcfgHiiHandle, L"bcfg");
> ShellStatus = SHELL_OUT_OF_RESOURCES;
> + return ShellStatus;
> }
> + CopyMem (KeyOptionBuffer, &NewKeyOption,
> sizeof(EFI_KEY_OPTION));
> }
> for (LoopCounter = 0 ; ShellStatus == SHELL_SUCCESS && LoopCounter <
> NewKeyOption.KeyData.Options.InputKeyCount; LoopCounter++) {
> //
> --
> 2.14.1.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 2/3] ShellPkg: Fix misuses of AllocateCopyPool
2017-11-08 15:50 ` Carsey, Jaben
@ 2017-11-09 1:03 ` Wang, Jian J
0 siblings, 0 replies; 10+ messages in thread
From: Wang, Jian J @ 2017-11-09 1:03 UTC (permalink / raw)
To: Carsey, Jaben, edk2-devel@lists.01.org; +Cc: Ni, Ruiyu, Bi, Dandan
You're right StrCpyS is better for this case. Since the patch has checked in,
maybe we can refine those code in another patch. Thanks for the comment.
> -----Original Message-----
> From: Carsey, Jaben
> Sent: Wednesday, November 08, 2017 11:50 PM
> To: Wang, Jian J <jian.j.wang@intel.com>; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Subject: RE: [PATCH v3 2/3] ShellPkg: Fix misuses of AllocateCopyPool
>
> Why not use the StrCpy_s function to copy strings? CopyMem and StrSize feels
> odd to me.
>
> > -----Original Message-----
> > From: Wang, Jian J
> > Sent: Tuesday, November 07, 2017 6:12 PM
> > To: edk2-devel@lists.01.org
> > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu
> > <ruiyu.ni@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> > Subject: [PATCH v3 2/3] ShellPkg: Fix misuses of AllocateCopyPool
> > Importance: High
> >
> > > v3:
> > > No update
> >
> > > v2:
> > > a. Use ReallocatePool instead of allocating then copying wherever
> > applicable
> >
> > AllocateCopyPool(AllocationSize, *Buffer) will copy "AllocationSize" bytes of
> > memory from old "Buffer" to new allocated one. If "AllocationSize" is bigger
> > than size of "Buffer", heap memory overflow occurs during copy.
> >
> > One solution is to allocate pool first then copy the necessary bytes to new
> > memory. Another is using ReallocatePool instead if old buffer will be freed
> > on spot.
> >
> > Cc: Jaben Carsey <jaben.carsey@intel.com>
> > Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> > Cc: Bi Dandan <dandan.bi@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> > ---
> > ShellPkg/Application/Shell/Shell.c | 4 +++-
> > ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 7
> > +++++--
> > 2 files changed, 8 insertions(+), 3 deletions(-)
> >
> > diff --git a/ShellPkg/Application/Shell/Shell.c
> > b/ShellPkg/Application/Shell/Shell.c
> > index 5471930ba1..656206fdce 100644
> > --- a/ShellPkg/Application/Shell/Shell.c
> > +++ b/ShellPkg/Application/Shell/Shell.c
> > @@ -1646,7 +1646,7 @@ ShellConvertVariables (
> > //
> > // now do the replacements...
> > //
> > - NewCommandLine1 = AllocateCopyPool(NewSize, OriginalCommandLine);
> > + NewCommandLine1 = AllocateZeroPool (NewSize);
> > NewCommandLine2 = AllocateZeroPool(NewSize);
> > ItemTemp = AllocateZeroPool(ItemSize+(2*sizeof(CHAR16)));
> > if (NewCommandLine1 == NULL || NewCommandLine2 == NULL ||
> > ItemTemp == NULL) {
> > @@ -1655,6 +1655,8 @@ ShellConvertVariables (
> > SHELL_FREE_NON_NULL(ItemTemp);
> > return (NULL);
> > }
> > + CopyMem (NewCommandLine1, OriginalCommandLine, StrSize
> > (OriginalCommandLine));
> > +
> > for (MasterEnvList = EfiShellGetEnv(NULL)
> > ; MasterEnvList != NULL && *MasterEnvList != CHAR_NULL
> > ; MasterEnvList += StrLen(MasterEnvList) + 1
> > diff --git
> > a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> > b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> > index 1122c89b8b..ee3db63358 100644
> > ---
> > a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> > +++
> > b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> > @@ -143,10 +143,11 @@ UpdateOptionalData(
> > OriginalOptionDataSize += (*(UINT16*)(OriginalData + sizeof(UINT32)));
> > OriginalOptionDataSize -= OriginalSize;
> > NewSize = OriginalSize - OriginalOptionDataSize + DataSize;
> > - NewData = AllocateCopyPool(NewSize, OriginalData);
> > + NewData = AllocatePool(NewSize);
> > if (NewData == NULL) {
> > Status = EFI_OUT_OF_RESOURCES;
> > } else {
> > + CopyMem (NewData, OriginalData, OriginalSize -
> > OriginalOptionDataSize);
> > CopyMem(NewData + OriginalSize - OriginalOptionDataSize, Data,
> > DataSize);
> > }
> > }
> > @@ -1120,11 +1121,13 @@ BcfgAddOpt(
> > // Now we know how many EFI_INPUT_KEY structs we need to attach to
> > the end of the EFI_KEY_OPTION struct.
> > // Re-allocate with the added information.
> > //
> > - KeyOptionBuffer = AllocateCopyPool(sizeof(EFI_KEY_OPTION) +
> > (sizeof(EFI_INPUT_KEY) * NewKeyOption.KeyData.Options.InputKeyCount),
> > &NewKeyOption);
> > + KeyOptionBuffer = AllocatePool (sizeof(EFI_KEY_OPTION) +
> > (sizeof(EFI_INPUT_KEY) *
> > NewKeyOption.KeyData.Options.InputKeyCount));
> > if (KeyOptionBuffer == NULL) {
> > ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_GEN_NO_MEM),
> > gShellBcfgHiiHandle, L"bcfg");
> > ShellStatus = SHELL_OUT_OF_RESOURCES;
> > + return ShellStatus;
> > }
> > + CopyMem (KeyOptionBuffer, &NewKeyOption,
> > sizeof(EFI_KEY_OPTION));
> > }
> > for (LoopCounter = 0 ; ShellStatus == SHELL_SUCCESS && LoopCounter <
> > NewKeyOption.KeyData.Options.InputKeyCount; LoopCounter++) {
> > //
> > --
> > 2.14.1.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-11-09 0:59 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-08 2:11 [PATCH v3 0/3] Fix misuses of AllocateCopyPool Jian J Wang
2017-11-08 2:11 ` [PATCH v3 1/3] MdeModulePkg: " Jian J Wang
2017-11-08 2:37 ` Zeng, Star
2017-11-08 2:46 ` Wang, Jian J
2017-11-08 2:57 ` Zeng, Star
2017-11-08 2:12 ` [PATCH v3 2/3] ShellPkg: " Jian J Wang
2017-11-08 15:50 ` Carsey, Jaben
2017-11-09 1:03 ` Wang, Jian J
2017-11-08 2:12 ` [PATCH v3 3/3] IntelFrameworkModulePkg: " Jian J Wang
2017-11-08 2:33 ` Bi, Dandan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox