From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 45BE72035A7C6 for ; Thu, 16 Nov 2017 18:49:12 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Nov 2017 18:53:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,406,1505804400"; d="scan'208";a="8621951" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 16 Nov 2017 18:53:21 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 16 Nov 2017 18:53:18 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 16 Nov 2017 18:53:18 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Fri, 17 Nov 2017 10:53:16 +0800 From: "Wang, Jian J" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" , "Dong, Eric" Thread-Topic: [edk2] [PATCH v6 3/7] UefiCpuPkg/CpuDxe: Reduce debug message Thread-Index: AQHTXPZZLZF2HoOQSkaRE9RRJvT3b6MX3bgQgAAGsnA= Date: Fri, 17 Nov 2017 02:53:16 +0000 Message-ID: References: <20171114031126.23340-1-jian.j.wang@intel.com> <20171114031126.23340-4-jian.j.wang@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B9B7779@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B9B7779@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmRiMWE5ZjUtZGQzNi00OWE5LTk2NjMtZmQ4N2RkYzY4YjlmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJGTGJCSjVzbkYrY1hOXC9jd2JsUlhnWDYrWU51c0l5N2w2aGlwU3pyeG5nV2hVNkM1Tm1zTHFVakhZeU4wRWtETyJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v6 3/7] UefiCpuPkg/CpuDxe: Reduce debug message X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2017 02:49:12 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I agree. Thanks for the comment. > -----Original Message----- > From: Zeng, Star > Sent: Friday, November 17, 2017 10:31 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Dong, Eric ; > Zeng, Star > Subject: RE: [edk2] [PATCH v6 3/7] UefiCpuPkg/CpuDxe: Reduce debug messag= e >=20 > According to the definitions, DEBUG_POOL and DEBUG_PAGE are for alloc & > free pool/page. >=20 > #define DEBUG_POOL 0x00000010 // Alloc & Free (pool) > #define DEBUG_PAGE 0x00000020 // Alloc & Free (page) >=20 > How about changing the debug level to DEBUG_VERBOSE? > If you agree, you do not need send a new patch, we can update it when > pushing. :) >=20 >=20 > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ji= an J > Wang > Sent: Tuesday, November 14, 2017 11:11 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Dong, Eric > Subject: [edk2] [PATCH v6 3/7] UefiCpuPkg/CpuDxe: Reduce debug message >=20 > Heap guard feature will frequently update page attributes. The debug mess= age > in CpuDxe driver will slow down the boot performance noticeably. Changing= the > debug level to DEBUG_POOL and DEBUG_PAGE to reduce the message output > for normal debug configuration. >=20 > Cc: Eric Dong > Cc: Jiewen Yao > Suggested-by: Ayellet Wolman > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang > Reviewed-by: Jiewen Yao > Regression-tested-by: Laszlo Ersek > --- > UefiCpuPkg/CpuDxe/CpuPageTable.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c > b/UefiCpuPkg/CpuDxe/CpuPageTable.c > index d312eb66f8..5270a1124f 100644 > --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c > +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c > @@ -442,8 +442,9 @@ ConvertPageEntryAttribute ( > *PageEntry =3D NewPageEntry; > if (CurrentPageEntry !=3D NewPageEntry) { > *IsModified =3D TRUE; > - DEBUG ((DEBUG_INFO, "ConvertPageEntryAttribute 0x%lx", > CurrentPageEntry)); > - DEBUG ((DEBUG_INFO, "->0x%lx\n", NewPageEntry)); > + DEBUG ((DEBUG_POOL | DEBUG_PAGE, "ConvertPageEntryAttribute 0x%lx", > + CurrentPageEntry)); > + DEBUG ((DEBUG_POOL | DEBUG_PAGE, "->0x%lx\n", NewPageEntry)); > } else { > *IsModified =3D FALSE; > } > -- > 2.14.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel