From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Permerror (SPF Permanent Error: More than 10 MX records returned) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B7BF621B0284D for ; Thu, 7 Dec 2017 19:41:56 -0800 (PST) Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Dec 2017 19:46:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,376,1508828400"; d="scan'208";a="800943" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga007.fm.intel.com with ESMTP; 07 Dec 2017 19:46:30 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 7 Dec 2017 19:46:30 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 7 Dec 2017 19:46:29 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Fri, 8 Dec 2017 11:46:27 +0800 From: "Wang, Jian J" To: "Zeng, Star" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] MdeModulePkg DxeIpl: Move ClearFirst4KPage/IsNullDetectionEnabled definition Thread-Index: AQHTb9EQ6kqYEg0STEqedNFPxiOYBqM4znlg Date: Fri, 8 Dec 2017 03:46:27 +0000 Message-ID: References: <1512702176-13712-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1512702176-13712-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTA2YWExOTAtYjA5Yy00ZTdhLTk4MWItYjcyOGJmNDBhMTBmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiIyeGE1Q0RiSHZUU3RRa3ZtQ01EWDBjQVBrXC83R0tVYXE5WTdWZVhsdGJaOGJqMVN3c1VZZWsrS2NPSmlCT1ZNQiJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg DxeIpl: Move ClearFirst4KPage/IsNullDetectionEnabled definition X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 03:41:56 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks good to me. Reviewed-by: Jian J Wang > -----Original Message----- > From: Zeng, Star > Sent: Friday, December 08, 2017 11:03 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Wang, Jian J > Subject: [PATCH] MdeModulePkg DxeIpl: Move > ClearFirst4KPage/IsNullDetectionEnabled definition >=20 > Move ClearFirst4KPage/IsNullDetectionEnabled definition from DxeIpl.h to > VirtualMemory.h as they are implemented in VirtualMemory.c and only used > in IA32/X64 ARCH. >=20 > Cc: Jian J Wang > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > MdeModulePkg/Core/DxeIplPeim/DxeIpl.h | 27 +-----------------= ------ > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.h | 26 > ++++++++++++++++++++++- > 2 files changed, 26 insertions(+), 27 deletions(-) >=20 > diff --git a/MdeModulePkg/Core/DxeIplPeim/DxeIpl.h > b/MdeModulePkg/Core/DxeIplPeim/DxeIpl.h > index f3aabdb7e0f0..6f8e13d21335 100644 > --- a/MdeModulePkg/Core/DxeIplPeim/DxeIpl.h > +++ b/MdeModulePkg/Core/DxeIplPeim/DxeIpl.h > @@ -2,7 +2,7 @@ > Master header file for DxeIpl PEIM. All source files in this module sh= ould > include this file for common definitions. >=20 > -Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BS= D > License > which accompanies this distribution. The full text of the license may b= e found > at > @@ -240,29 +240,4 @@ Decompress ( > OUT UINTN *OutputSize > ); >=20 > -/** > - Clear legacy memory located at the first 4K-page. > - > - This function traverses the whole HOB list to check if memory from 0 t= o 4095 > - exists and has not been allocated, and then clear it if so. > - > - @param HobStart The start of HobList passed to DxeCore. > - > -**/ > -VOID > -ClearFirst4KPage ( > - IN VOID *HobStart > - ); > - > -/** > - Return configure status of NULL pointer detection feature. > - > - @return TRUE NULL pointer detection feature is enabled > - @return FALSE NULL pointer detection feature is disabled > -**/ > -BOOLEAN > -IsNullDetectionEnabled ( > - VOID > - ); > - > #endif > diff --git a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.h > b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.h > index 7c9bb49e3e2c..26a2100f0b80 100644 > --- a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.h > +++ b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.h > @@ -7,7 +7,7 @@ > 3) IA-32 Intel(R) Architecture Software Developer's Manual Volume 3:= System > Programmer's Guide, Intel > 4) AMD64 Architecture Programmer's Manual Volume 2: System > Programming >=20 > -Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> Copyright (c) 2017, AMD Incorporated. All rights reserved.
>=20 > This program and the accompanying materials > @@ -227,5 +227,29 @@ AsmGetVectorTemplatInfo ( > OUT VOID **TemplateBase > ); >=20 > +/** > + Clear legacy memory located at the first 4K-page. > + > + This function traverses the whole HOB list to check if memory from 0 t= o 4095 > + exists and has not been allocated, and then clear it if so. > + > + @param HobStart The start of HobList passed to DxeCore. > + > +**/ > +VOID > +ClearFirst4KPage ( > + IN VOID *HobStart > + ); > + > +/** > + Return configure status of NULL pointer detection feature. > + > + @return TRUE NULL pointer detection feature is enabled > + @return FALSE NULL pointer detection feature is disabled > +**/ > +BOOLEAN > +IsNullDetectionEnabled ( > + VOID > + ); >=20 > #endif > -- > 2.7.0.windows.1