From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7082421CB87AD for ; Sun, 24 Dec 2017 18:18:44 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Dec 2017 18:23:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,453,1508828400"; d="scan'208";a="5381743" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 24 Dec 2017 18:23:36 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Dec 2017 18:23:36 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Dec 2017 18:23:35 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Mon, 25 Dec 2017 10:23:33 +0800 From: "Wang, Jian J" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Zeng, Star" , "Dong, Eric" Thread-Topic: [PATCH 1/4] MdePkg/BaseLib.h: Coding style clean-up Thread-Index: AQHTfSLer7oFh6sMDk2n2KUiz5X0l6NTVGFw Date: Mon, 25 Dec 2017 02:23:33 +0000 Message-ID: References: <20171225010659.13428-1-jian.j.wang@intel.com> <20171225010659.13428-2-jian.j.wang@intel.com> <3C0D5C461C9E904E8F62152F6274C0BB3B9F0502@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB3B9F0502@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDFhYjc0ZjQtYmUwMS00MDA3LTgwZmItMWU2MzU2YmFkOWJhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJ5cVNsT052S1M3alRZZXRoZHhMOXoxYW90RllRVGxNUHJCS1wveVlZNFlGMWsyM2YzcW10bWwxSnd2ZmZyNzFCZCJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/4] MdePkg/BaseLib.h: Coding style clean-up X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Dec 2017 02:18:44 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ok. Thanks for catching it. Regards, Jian > -----Original Message----- > From: Bi, Dandan > Sent: Monday, December 25, 2017 9:51 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Zeng, Star ; Dong, Eric > Subject: RE: [PATCH 1/4] MdePkg/BaseLib.h: Coding style clean-up >=20 > Hi Jian, >=20 > This patch is fine. > Could you help to add a period(.) for following function description whe= n you > commit the patch? Thanks! > /** > Load given selector into TR register // Add a period(.) here, or ECC = tool will > report an error here. >=20 > @param[in] Selector Task segment selector > **/ > VOID > EFIAPI > AsmWriteTr ( > IN UINT16 Selector > ); >=20 > With this update, Reviewed-by: Dandan Bi >=20 > Regards, > Dandan > -----Original Message----- > From: Wang, Jian J > Sent: Monday, December 25, 2017 9:07 AM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan ; Zeng, Star ; > Dong, Eric > Subject: [PATCH 1/4] MdePkg/BaseLib.h: Coding style clean-up >=20 > Cc: Dandan Bi > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang > --- > MdePkg/Include/Library/BaseLib.h | 72 ++++++++++++++++++++--------------= ---- > -- > 1 file changed, 36 insertions(+), 36 deletions(-) >=20 > diff --git a/MdePkg/Include/Library/BaseLib.h > b/MdePkg/Include/Library/BaseLib.h > index 2b98af4cd1..f51079aeb1 100644 > --- a/MdePkg/Include/Library/BaseLib.h > +++ b/MdePkg/Include/Library/BaseLib.h > @@ -6672,41 +6672,41 @@ typedef union { > typedef struct { > UINT16 PreviousTaskLink; > UINT16 Reserved_2; > - UINT32 ESP0; > - UINT16 SS0; > + UINT32 Esp0; > + UINT16 Ss0; > UINT16 Reserved_10; > - UINT32 ESP1; > - UINT16 SS1; > + UINT32 Esp1; > + UINT16 Ss1; > UINT16 Reserved_18; > - UINT32 ESP2; > - UINT16 SS2; > + UINT32 Esp2; > + UINT16 Ss2; > UINT16 Reserved_26; > - UINT32 CR3; > - UINT32 EIP; > - UINT32 EFLAGS; > - UINT32 EAX; > - UINT32 ECX; > - UINT32 EDX; > - UINT32 EBX; > - UINT32 ESP; > - UINT32 EBP; > - UINT32 ESI; > - UINT32 EDI; > - UINT16 ES; > + UINT32 Cr3; > + UINT32 Eip; > + UINT32 Eflags; > + UINT32 Eax; > + UINT32 Ecx; > + UINT32 Edx; > + UINT32 Ebx; > + UINT32 Esp; > + UINT32 Ebp; > + UINT32 Esi; > + UINT32 Edi; > + UINT16 Es; > UINT16 Reserved_74; > - UINT16 CS; > + UINT16 Cs; > UINT16 Reserved_78; > - UINT16 SS; > + UINT16 Ss; > UINT16 Reserved_82; > - UINT16 DS; > + UINT16 Ds; > UINT16 Reserved_86; > - UINT16 FS; > + UINT16 Fs; > UINT16 Reserved_90; > - UINT16 GS; > + UINT16 Gs; > UINT16 Reserved_94; > UINT16 LDTSegmentSelector; > UINT16 Reserved_98; > - UINT16 T; > + UINT16 Tflag; > UINT16 IOMapBaseAddress; > } IA32_TASK_STATE_SEGMENT; >=20 > @@ -6717,12 +6717,12 @@ typedef union { > UINT32 BaseMid:8; ///< Base Address 23..16 > UINT32 Type:4; ///< Type (1 0 B 1) > UINT32 Reserved_43:1; ///< 0 > - UINT32 DPL:2; ///< Descriptor Privilege Level > - UINT32 P:1; ///< Segment Present > + UINT32 Dpl:2; ///< Descriptor Privilege Level > + UINT32 Present:1; ///< Segment Present > UINT32 LimitHigh:4; ///< Segment Limit 19..16 > - UINT32 AVL:1; ///< Available for use by system software > + UINT32 Avl:1; ///< Available for use by system software > UINT32 Reserved_52:2; ///< 0 0 > - UINT32 G:1; ///< Granularity > + UINT32 Granularity:1; ///< Granularity > UINT32 BaseHigh:8; ///< Base Address 31..24 > } Bits; > UINT64 Uint64; > @@ -6757,11 +6757,11 @@ typedef union { > // > typedef struct { > UINT32 Reserved_0; > - UINT64 RSP0; > - UINT64 RSP1; > - UINT64 RSP2; > + UINT64 Rsp0; > + UINT64 Rsp1; > + UINT64 Rsp2; > UINT64 Reserved_28; > - UINT64 IST[7]; > + UINT64 Ist[7]; > UINT64 Reserved_92; > UINT16 Reserved_100; > UINT16 IOMapBaseAddress; > @@ -6774,12 +6774,12 @@ typedef union { > UINT32 BaseMidl:8; ///< Base Address 23..16 > UINT32 Type:4; ///< Type (1 0 B 1) > UINT32 Reserved_43:1; ///< 0 > - UINT32 DPL:2; ///< Descriptor Privilege Level > - UINT32 P:1; ///< Segment Present > + UINT32 Dpl:2; ///< Descriptor Privilege Level > + UINT32 Present:1; ///< Segment Present > UINT32 LimitHigh:4; ///< Segment Limit 19..16 > - UINT32 AVL:1; ///< Available for use by system software > + UINT32 Avl:1; ///< Available for use by system software > UINT32 Reserved_52:2; ///< 0 0 > - UINT32 G:1; ///< Granularity > + UINT32 Granularity:1; ///< Granularity > UINT32 BaseMidh:8; ///< Base Address 31..24 > UINT32 BaseHigh:32; ///< Base Address 63..32 > UINT32 Reserved_96:32; ///< Reserved > -- > 2.15.1.windows.2