From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 17B2321CB87A2 for ; Sun, 24 Dec 2017 18:23:32 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Dec 2017 18:28:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,453,1508828400"; d="scan'208";a="5382428" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 24 Dec 2017 18:28:24 -0800 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Dec 2017 18:28:24 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Dec 2017 18:28:23 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Mon, 25 Dec 2017 10:28:21 +0800 From: "Wang, Jian J" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , Laszlo Ersek Thread-Topic: [PATCH 3/4] UefiCpuPkg/UefiCpuPkg.uni: Add missing string definition for new PCDs Thread-Index: AQHTfSPoT4/RGnaKC0mINjvD+JjQgaNTVb8Q Date: Mon, 25 Dec 2017 02:28:21 +0000 Message-ID: References: <20171225010659.13428-1-jian.j.wang@intel.com> <20171225010659.13428-4-jian.j.wang@intel.com> <3C0D5C461C9E904E8F62152F6274C0BB3B9F051C@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB3B9F051C@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTg5ZjRmMDEtNzIzMi00NjJjLTlhMzMtYmI2MjE3NzMwNjAyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJEd1doRWt0YTVGY21idlNlWFRLQXMrVlM0OHJid2t2ekpSK2VvdUtkRDVZbHVFQzM0Z1lzdEtyWFZnTXViK25xIn0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 3/4] UefiCpuPkg/UefiCpuPkg.uni: Add missing string definition for new PCDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Dec 2017 02:23:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sure. Thanks. Regards, Jian > -----Original Message----- > From: Bi, Dandan > Sent: Monday, December 25, 2017 9:59 AM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Dong, Eric ; Laszlo Ersek > Subject: RE: [PATCH 3/4] UefiCpuPkg/UefiCpuPkg.uni: Add missing string > definition for new PCDs >=20 > Hi Jian, >=20 > Could you add the "string" keyword before the string token when you commi= t > the patch. You can refer to other codes in the uni file. > With this update, Reviewed-by: Dandan Bi >=20 > Thanks, > Dandan > -----Original Message----- > From: Wang, Jian J > Sent: Monday, December 25, 2017 9:07 AM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan ; Dong, Eric ; > Laszlo Ersek > Subject: [PATCH 3/4] UefiCpuPkg/UefiCpuPkg.uni: Add missing string defini= tion > for new PCDs >=20 > Cc: Dandan Bi > Cc: Eric Dong > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang > --- > UefiCpuPkg/UefiCpuPkg.uni | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) >=20 > diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index > a7073b10c8..6fcfc6e7f2 100644 > --- a/UefiCpuPkg/UefiCpuPkg.uni > +++ b/UefiCpuPkg/UefiCpuPkg.uni > @@ -230,5 +230,17 @@ > = "Processor trace is enabled > through set BIT44(CPU_FEATURE_PROC_TRACE) in > PcdCpuFeaturesSetting.

\n" > = "This PCD is ignored if CPU > processor trace is disabled.

\n" > = "Default value is 0 which means > single range output scheme will be used if CPU processor trace is > enabled.
\n" > - = "0 - Single Range output > scheme.
\n" >=20 > - = "1 - ToPA(Table of physical > address) scheme.
\n" > \ No newline at end of file > + = "0 - Single Range output > scheme.
\n" > + = "1 - ToPA(Table of physical > address) scheme.
\n" > + > +#STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuStackSwitchExceptionList_PROMP > T #language en-US "Specify exception vectors which need switching stack.= " > + > +#STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuStackSwitchExceptionList_HELP > #language en-US "List of exception vectors which need switching stack.\n" > + = "This PCD will only take into > effect if PcdCpuStackGuard is enabled.n" > + = "By default exception #DD(8), > #PF(14) are supported.n" > + > +#STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuKnownGoodStackSize_PROMPT > #language en-US "Specify size of good stack of exception which need switc= hing > stack." > + > +#STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuKnownGoodStackSize_HELP > #language en-US "Size of good stack for an exception.\n" > + = "This PCD will only take into effect if > PcdCpuStackGuard is enabled.\n" > + > -- > 2.15.1.windows.2