From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1A7A92219BC93 for ; Tue, 26 Dec 2017 16:35:14 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Dec 2017 16:40:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,462,1508828400"; d="scan'208";a="190186300" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 26 Dec 2017 16:40:09 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 26 Dec 2017 16:40:08 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.189]) with mapi id 14.03.0319.002; Wed, 27 Dec 2017 08:40:07 +0800 From: "Wang, Jian J" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH 0/4] Coding style clean-up Thread-Index: AQHTfRy64D5IreeHvkiiDvDyS/BwP6NVUjYAgAEH6DA= Date: Wed, 27 Dec 2017 00:40:06 +0000 Message-ID: References: <20171225010659.13428-1-jian.j.wang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODBmZmIxYTMtMWNiMC00MjE2LTlmM2QtYjI0Y2UxMmY3ZTQ5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJuUWhBdHNPaXlRbnJCbm9EbE1iUWRnaWxXckFtR3lNcmhTUXZ4WGhcLysra1hVZDhwWTVOM3VPXC82cTlTSHhoQ00ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/4] Coding style clean-up X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Dec 2017 00:35:15 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Mike, Since this patch has been checked in trunk, do you think it should be rever= ted? In addition, instead of using exception list for the ECC tool, I think it'd= be better to update ECC tool to use keyword match to check if a field name is public = spec defined one. Otherwise, if there's new structure type using those field nam= es, the tool will still report errors. Regards, Jian > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, December 27, 2017 12:48 AM > To: Wang, Jian J ; edk2-devel@lists.01.org; Kinney= , > Michael D > Subject: RE: [edk2] [PATCH 0/4] Coding style clean-up >=20 > Jian, >=20 > I do not think this change should be made. >=20 > One of the exceptions for not following the > EDK II code style is if the field names are > defined in a public specification. In this case > these fields are all listed in a structure in > the Intel 64 and IA-32 Architectures Software > Development Manual, Section 7.2.1, Figure 7-2 > using upper case register names. >=20 > Thanks, >=20 > Mike >=20 >=20 >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] > > On Behalf Of Jian J Wang > > Sent: Sunday, December 24, 2017 5:07 PM > > To: edk2-devel@lists.01.org > > Subject: [edk2] [PATCH 0/4] Coding style clean-up > > > > This patch series are meant for cleaning up code > > according to coding style > > requirements. > > > > Jian J Wang (4): > > MdePkg/BaseLib.h: Coding style clean-up > > MdeModulePkg/Core: Coding style clean-up > > UefiCpuPkg/UefiCpuPkg.uni: Add missing string > > definition for new PCDs > > UefiCpuPkg: Update code to use new structure field > > names > > > > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 5 > > ++ > > MdePkg/Include/Library/BaseLib.h | 72 > > +++++++++++----------- > > .../Ia32/ArchExceptionHandler.c | 24 > > ++++---- > > .../X64/ArchExceptionHandler.c | 6 > > +- > > UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 > > +- > > UefiCpuPkg/UefiCpuPkg.uni | 16 > > ++++- > > 6 files changed, 71 insertions(+), 54 deletions(-) > > > > -- > > 2.15.1.windows.2 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel