public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 0/4] Coding style clean-up
Date: Thu, 28 Dec 2017 00:53:29 +0000	[thread overview]
Message-ID: <D827630B58408649ACB04F44C510003624CC7C4D@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5A7DF30D0@ORSMSX113.amr.corp.intel.com>

Theoretically, yes. But I think it's a rare case in which someone
will use ESP in a structure but not to represent ESP register.

Regards,
Jian


> -----Original Message-----
> From: Kinney, Michael D
> Sent: Thursday, December 28, 2017 8:37 AM
> To: Wang, Jian J <jian.j.wang@intel.com>; edk2-devel@lists.01.org; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Subject: RE: [edk2] [PATCH 0/4] Coding style clean-up
> 
> Jian,
> 
> I think <typename>.<fieldname> is the correct way to list
> this type of exception.  Otherwise we can miss incorrect
> use of that field name.
> 
> Mike
> 
> > -----Original Message-----
> > From: Wang, Jian J
> > Sent: Wednesday, December 27, 2017 4:28 PM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > edk2-devel@lists.01.org
> > Subject: RE: [edk2] [PATCH 0/4] Coding style clean-up
> >
> > Current ECC use <type-name>.<field-name> in exception
> > list to exclude those special
> > field name spec defined. Whenever there's a new
> > structure introduced with those field
> > names, which have been added to exception list, the ECC
> > will still report coding style
> > violation. Maybe we can just use <field-name> to do
> > field name match for any structure
> > type to exclude those special names. This can avoid the
> > false reports as many as possible.
> >
> > Regards,
> > Jian
> >
> >
> > > -----Original Message-----
> > > From: Kinney, Michael D
> > > Sent: Thursday, December 28, 2017 12:35 AM
> > > To: Wang, Jian J <jian.j.wang@intel.com>; edk2-
> > devel@lists.01.org; Kinney,
> > > Michael D <michael.d.kinney@intel.com>
> > > Subject: RE: [edk2] [PATCH 0/4] Coding style clean-up
> > >
> > > Yes.  Please revert.
> > >
> > > I am not sure I understand the ECC tool update you
> > are suggesting.
> > > Can you provide more details?
> > >
> > > Mike
> > >
> > > > -----Original Message-----
> > > > From: Wang, Jian J
> > > > Sent: Tuesday, December 26, 2017 4:40 PM
> > > > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > edk2-
> > > > devel@lists.01.org
> > > > Subject: RE: [edk2] [PATCH 0/4] Coding style clean-
> > up
> > > >
> > > > Hi Mike,
> > > >
> > > > Since this patch has been checked in trunk, do you
> > think
> > > > it should be reverted?
> > > > In addition, instead of using exception list for
> > the ECC
> > > > tool, I think it'd be better
> > > > to update ECC tool to use keyword match to check if
> > a
> > > > field name is public spec
> > > > defined one. Otherwise, if there's new structure
> > type
> > > > using those field names,
> > > > the tool will still report errors.
> > > >
> > > > Regards,
> > > > Jian
> > > >
> > > > > -----Original Message-----
> > > > > From: Kinney, Michael D
> > > > > Sent: Wednesday, December 27, 2017 12:48 AM
> > > > > To: Wang, Jian J <jian.j.wang@intel.com>; edk2-
> > > > devel@lists.01.org; Kinney,
> > > > > Michael D <michael.d.kinney@intel.com>
> > > > > Subject: RE: [edk2] [PATCH 0/4] Coding style
> > clean-up
> > > > >
> > > > > Jian,
> > > > >
> > > > > I do not think this change should be made.
> > > > >
> > > > > One of the exceptions for not following the
> > > > > EDK II code style is if the field names are
> > > > > defined in a public specification.  In this case
> > > > > these fields are all listed in a structure in
> > > > > the Intel 64 and IA-32 Architectures Software
> > > > > Development Manual, Section 7.2.1, Figure 7-2
> > > > > using upper case register names.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Mike
> > > > >
> > > > >
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: edk2-devel [mailto:edk2-devel-
> > > > bounces@lists.01.org]
> > > > > > On Behalf Of Jian J Wang
> > > > > > Sent: Sunday, December 24, 2017 5:07 PM
> > > > > > To: edk2-devel@lists.01.org
> > > > > > Subject: [edk2] [PATCH 0/4] Coding style clean-
> > up
> > > > > >
> > > > > > This patch series are meant for cleaning up
> > code
> > > > > > according to coding style
> > > > > > requirements.
> > > > > >
> > > > > > Jian J Wang (4):
> > > > > >   MdePkg/BaseLib.h: Coding style clean-up
> > > > > >   MdeModulePkg/Core: Coding style clean-up
> > > > > >   UefiCpuPkg/UefiCpuPkg.uni: Add missing string
> > > > > > definition for new PCDs
> > > > > >   UefiCpuPkg: Update code to use new structure
> > field
> > > > > > names
> > > > > >
> > > > > >
> > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c   |
> > > > 5
> > > > > > ++
> > > > > >  MdePkg/Include/Library/BaseLib.h
> > |
> > > > 72
> > > > > > +++++++++++-----------
> > > > > >  .../Ia32/ArchExceptionHandler.c
> > |
> > > > 24
> > > > > > ++++----
> > > > > >  .../X64/ArchExceptionHandler.c
> > |
> > > > 6
> > > > > > +-
> > > > > >  UefiCpuPkg/Library/MpInitLib/MpLib.c
> > |
> > > > 2
> > > > > > +-
> > > > > >  UefiCpuPkg/UefiCpuPkg.uni
> > |
> > > > 16
> > > > > > ++++-
> > > > > >  6 files changed, 71 insertions(+), 54
> > deletions(-)
> > > > > >
> > > > > > --
> > > > > > 2.15.1.windows.2
> > > > > >
> > > > > > _______________________________________________
> > > > > > edk2-devel mailing list
> > > > > > edk2-devel@lists.01.org
> > > > > > https://lists.01.org/mailman/listinfo/edk2-
> > devel


      reply	other threads:[~2017-12-28  0:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-25  1:06 [PATCH 0/4] Coding style clean-up Jian J Wang
2017-12-25  1:06 ` [PATCH 1/4] MdePkg/BaseLib.h: " Jian J Wang
2017-12-25  1:51   ` Bi, Dandan
2017-12-25  2:23     ` Wang, Jian J
2017-12-25  1:06 ` [PATCH 2/4] MdeModulePkg/Core: " Jian J Wang
2017-12-25  1:19   ` Zeng, Star
2017-12-25  2:01   ` Bi, Dandan
2017-12-25  1:06 ` [PATCH 3/4] UefiCpuPkg/UefiCpuPkg.uni: Add missing string definition for new PCDs Jian J Wang
2017-12-25  1:58   ` Bi, Dandan
2017-12-25  2:28     ` Wang, Jian J
2017-12-25  1:06 ` [PATCH 4/4] UefiCpuPkg: Update code to use new structure field names Jian J Wang
2017-12-25  2:01   ` Bi, Dandan
2017-12-26 16:47 ` [PATCH 0/4] Coding style clean-up Kinney, Michael D
2017-12-27  0:40   ` Wang, Jian J
2017-12-27  9:29     ` Gao, Liming
2017-12-27 16:35     ` Kinney, Michael D
2017-12-28  0:27       ` Wang, Jian J
2017-12-28  0:37         ` Kinney, Michael D
2017-12-28  0:53           ` Wang, Jian J [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D827630B58408649ACB04F44C510003624CC7C4D@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox