From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8B38B2205BE91 for ; Tue, 2 Jan 2018 00:18:07 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2018 00:23:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,495,1508828400"; d="scan'208";a="20694507" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 02 Jan 2018 00:23:08 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 2 Jan 2018 00:23:08 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 2 Jan 2018 00:23:08 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.189]) with mapi id 14.03.0319.002; Tue, 2 Jan 2018 16:23:06 +0800 From: "Wang, Jian J" To: Ard Biesheuvel CC: "edk2-devel@lists.01.org" , "Kinney, Michael D" , "Yao, Jiewen" , "Zeng, Star" , "Gao, Liming" Thread-Topic: [edk2] [PATCH v2 1/2] MdePkg/BasePrintLib: Fix error in Precision position calculation Thread-Index: AQHTf4UB0bw8XwWCQU2v6pSGKIQLJ6NdGsGAgAMrzZA= Date: Tue, 2 Jan 2018 08:23:06 +0000 Message-ID: References: <20171228023828.18752-1-jian.j.wang@intel.com> <20171228023828.18752-2-jian.j.wang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTQ1YmNlZGQtYWEzZS00ZTQ1LTk5YTQtZGJkYzE4MjI2ZGYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJaYkVQbTRmOWU5NWxzVHdEUE1aYytwQkUxOThvYVhodG1UMUFNSUI3MUtmTytLM3pwTkNQaEZTSzB6UnpsNmZZIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 1/2] MdePkg/BasePrintLib: Fix error in Precision position calculation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jan 2018 08:18:08 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 QXJkLA0KDQpUaGFua3MgZm9yIHRoZSBmaXguDQoNClJlZ2FyZHMsDQpKaWFuDQoNCj4gLS0tLS1P cmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQXJkIEJpZXNoZXV2ZWwgW21haWx0bzphcmQu Ymllc2hldXZlbEBsaW5hcm8ub3JnXQ0KPiBTZW50OiBTdW5kYXksIERlY2VtYmVyIDMxLCAyMDE3 IDExOjU3IFBNDQo+IFRvOiBXYW5nLCBKaWFuIEogPGppYW4uai53YW5nQGludGVsLmNvbT4NCj4g Q2M6IGVkazItZGV2ZWxAbGlzdHMuMDEub3JnOyBLaW5uZXksIE1pY2hhZWwgRCA8bWljaGFlbC5k Lmtpbm5leUBpbnRlbC5jb20+Ow0KPiBZYW8sIEppZXdlbiA8amlld2VuLnlhb0BpbnRlbC5jb20+ OyBaZW5nLCBTdGFyIDxzdGFyLnplbmdAaW50ZWwuY29tPjsgR2FvLA0KPiBMaW1pbmcgPGxpbWlu Zy5nYW9AaW50ZWwuY29tPg0KPiBTdWJqZWN0OiBSZTogW2VkazJdIFtQQVRDSCB2MiAxLzJdIE1k ZVBrZy9CYXNlUHJpbnRMaWI6IEZpeCBlcnJvciBpbiBQcmVjaXNpb24NCj4gcG9zaXRpb24gY2Fs Y3VsYXRpb24NCj4gDQo+IE9uIDI4IERlY2VtYmVyIDIwMTcgYXQgMDI6MzgsIEppYW4gSiBXYW5n IDxqaWFuLmoud2FuZ0BpbnRlbC5jb20+IHdyb3RlOg0KPiA+PiB2MjoNCj4gPj4gICAgYS4gQ29y cmVjdCBpbmNvcnJlY3QgZGVzY3JpcHRpb24gaW4gY29tbWl0IGxvZw0KPiA+PiAgICBiLiBGaXgg YW5vdGhlciBzaW1pbGFyIGlzc3VlIGluIHRoZSBzYW1lIGZ1bmN0aW9uDQo+ID4NCj4gPiBEdWUg dG8gYSBwb3RlbnRpYWwgaG9sZSBpbiB0aGUgc3RvcCBjb25kaXRpb24gb2YgbG9vcCwgdGhlIHR3 byBjb250aW51b3VzDQo+ID4gYWNjZXNzIHRvIEFyZ3VtZW50U3RyaW5nIChpbmRleCwgaW5kZXgr MSkgaW5zaWRlIHRoZSBsb29wIG1pZ2h0IGNhdXNlIHRoZQ0KPiA+IHN0cmluZyBlbmRpbmcgY2hh cmFjdGVyICgnXDAnKSBhbmQgdGhlIGJ5dGUgYWZ0ZXIgaXQgdG8gYmUgcmVhZC4NCj4gPg0KPiA+ IENjOiBNaWNoYWVsIEQgS2lubmV5IDxtaWNoYWVsLmQua2lubmV5QGludGVsLmNvbT4NCj4gPiBD YzogTGltaW5nIEdhbyA8bGltaW5nLmdhb0BpbnRlbC5jb20+DQo+ID4gQ2M6IEppZXdlbiBZYW8g PGppZXdlbi55YW9AaW50ZWwuY29tPg0KPiA+IENjOiBTdGFyIFplbmcgPHN0YXIuemVuZ0BpbnRl bC5jb20+DQo+ID4gQ29udHJpYnV0ZWQtdW5kZXI6IFRpYW5vQ29yZSBDb250cmlidXRpb24gQWdy ZWVtZW50IDEuMQ0KPiA+IFNpZ25lZC1vZmYtYnk6IEppYW4gSiBXYW5nIDxqaWFuLmoud2FuZ0Bp bnRlbC5jb20+DQo+ID4gLS0tDQo+ID4gIE1kZVBrZy9MaWJyYXJ5L0Jhc2VQcmludExpYi9Qcmlu dExpYkludGVybmFsLmMgfCA3ICsrKysrLS0NCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0 aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS9NZGVQa2cvTGli cmFyeS9CYXNlUHJpbnRMaWIvUHJpbnRMaWJJbnRlcm5hbC5jDQo+IGIvTWRlUGtnL0xpYnJhcnkv QmFzZVByaW50TGliL1ByaW50TGliSW50ZXJuYWwuYw0KPiA+IGluZGV4IDI4ZDk0NjQ3MmYuLmZj NTcyNTUwNjggMTAwNjQ0DQo+ID4gLS0tIGEvTWRlUGtnL0xpYnJhcnkvQmFzZVByaW50TGliL1By aW50TGliSW50ZXJuYWwuYw0KPiA+ICsrKyBiL01kZVBrZy9MaWJyYXJ5L0Jhc2VQcmludExpYi9Q cmludExpYkludGVybmFsLmMNCj4gPiBAQCAtMTEwNyw3ICsxMTA3LDEwIEBAIEJhc2VQcmludExp YlNQcmludE1hcmtlciAoDQo+ID4gICAgICAgIC8vIENvbXB1dGUgdGhlIG51bWJlciBvZiBjaGFy YWN0ZXJzIGluIEFyZ3VtZW50U3RyaW5nIGFuZCBzdG9yZSBpdCBpbg0KPiBDb3VudA0KPiA+ICAg ICAgICAvLyBBcmd1bWVudFN0cmluZyBpcyBlaXRoZXIgbnVsbC10ZXJtaW5hdGVkLCBvciBpdCBj b250YWlucyBQcmVjaXNpb24NCj4gY2hhcmFjdGVycw0KPiA+ICAgICAgICAvLw0KPiA+IC0gICAg ICBmb3IgKENvdW50ID0gMDsgQ291bnQgPCBQcmVjaXNpb24gfHwgKChGbGFncyAmIFBSRUNJU0lP TikgPT0gMCk7IENvdW50KyspIHsNCj4gPiArICAgICAgZm9yIChDb3VudCA9IDA7DQo+ID4gKyAg ICAgICAgICAgIEFyZ3VtZW50U3RyaW5nW0NvdW50ICogQnl0ZXNQZXJBcmd1bWVudENoYXJhY3Rl cl0gIT0gJ1wwJyAmJg0KPiA+ICsgICAgICAgICAgICAoQ291bnQgPCBQcmVjaXNpb24gfHwgKChG bGFncyAmIFBSRUNJU0lPTikgPT0gMCkpOw0KPiA+ICsgICAgICAgICAgICAgIENvdW50KyspIHsN Cj4gPiAgICAgICAgICBBcmd1bWVudENoYXJhY3RlciA9ICgoQXJndW1lbnRTdHJpbmdbQ291bnQg Kg0KPiBCeXRlc1BlckFyZ3VtZW50Q2hhcmFjdGVyXSAmIDB4ZmYpIHwgKChBcmd1bWVudFN0cmlu Z1tDb3VudCAqDQo+IEJ5dGVzUGVyQXJndW1lbnRDaGFyYWN0ZXIgKyAxXSkgPDwgOCkpICYgQXJn dW1lbnRNYXNrOw0KPiA+ICAgICAgICAgIGlmIChBcmd1bWVudENoYXJhY3RlciA9PSAwKSB7DQo+ ID4gICAgICAgICAgICBicmVhazsNCj4gPiBAQCAtMTE2NCw3ICsxMTY3LDcgQEAgQmFzZVByaW50 TGliU1ByaW50TWFya2VyICgNCj4gPiAgICAgIC8vDQo+ID4gICAgICAvLyBDb3B5IHRoZSBzdHJp bmcgaW50byB0aGUgb3V0cHV0IGJ1ZmZlciBwZXJmb3JtaW5nIHRoZSByZXF1aXJlZCB0eXBlDQo+ IGNvbnZlcnNpb25zDQo+ID4gICAgICAvLw0KPiA+IC0gICAgd2hpbGUgKEluZGV4IDwgQ291bnQp IHsNCj4gPiArICAgIHdoaWxlIChJbmRleCA8IENvdW50ICYmICgqQXJndW1lbnRTdHJpbmcpICE9 ICdcMCcpIHsNCj4gPiAgICAgICAgQXJndW1lbnRDaGFyYWN0ZXIgPSAoKCpBcmd1bWVudFN0cmlu ZyAmIDB4ZmYpIHwNCj4gKCgoVUlOVDgpKihBcmd1bWVudFN0cmluZyArIDEpKSA8PCA4KSkgJiBB cmd1bWVudE1hc2s7DQo+ID4NCj4gPiAgICAgICAgTGVuZ3RoVG9SZXR1cm4gKz0gKDEgKiBCeXRl c1Blck91dHB1dENoYXJhY3Rlcik7DQo+IA0KPiBUaGlzIHBhdGNoIGJyZWFrcyBVRUZJIG1lbnUg cmVuZGVyaW5nOiB0aGUgZm9sbG93aW5nDQo+IA0KPiAvLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tXA0K PiB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERldmljZSBNYW5hZ2VyICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgfA0KPiBcLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLw0KPiAN Cj4gDQo+IGlzIHJlbmRlcmVkIGFzDQo+IA0KPiAvXA0KPiB8ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIERldmljZSBNYW5hZ2VyICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg fA0KPiBcLy4wICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IDIuMDAgR0h6DQo+IA0KPiAodGhlIHNwdXJpb3VzIGRpZ2l0cyBhcmUgU01CSU9TIGRhdGEgZnJv bSB0aGUgaG9tZSBzY3JlZW4pDQo+IA0KPiBUaGUgcHJvYmxlbSBhcHBlYXJzIHRvIGJlIHRoYXQg dGhlIENIQVIxNiB2YWx1ZSBvZiBCT1hEUkFXX0hPUklaT05UQUwNCj4gZXF1YWxzIDB4MjUwMCwg d2hpY2ggbWVhbnMgdGhhdCB0ZXN0aW5nIEFyZ3VtZW50U3RyaW5nW10gIT0gJ1wwJw0KPiAod2hp Y2ggdGVzdHMgdGhlIGxvdyBieXRlIG9ubHkpIHdpbGwgeWllbGQgRkFMU0UgYW5kIHRlcm1pbmF0 ZSB0aGUNCj4gbG9vcCBwcmVtYXR1cmVseS4NCj4gDQo+IFRoZSBmb2xsb3dpbmcgcGF0Y2ggZml4 ZXMgdGhpbmdzIGZvciBtZS4NCj4gDQo+IGRpZmYgLS1naXQgYS9NZGVQa2cvTGlicmFyeS9CYXNl UHJpbnRMaWIvUHJpbnRMaWJJbnRlcm5hbC5jDQo+IGIvTWRlUGtnL0xpYnJhcnkvQmFzZVByaW50 TGliL1ByaW50TGliSW50ZXJuYWwuYw0KPiBpbmRleCBmYzU3MjU1MDY4NDguLjNmNGJlOTMyZjM2 OSAxMDA2NDQNCj4gLS0tIGEvTWRlUGtnL0xpYnJhcnkvQmFzZVByaW50TGliL1ByaW50TGliSW50 ZXJuYWwuYw0KPiArKysgYi9NZGVQa2cvTGlicmFyeS9CYXNlUHJpbnRMaWIvUHJpbnRMaWJJbnRl cm5hbC5jDQo+IEBAIC0xMTA4LDcgKzExMDgsOSBAQCBCYXNlUHJpbnRMaWJTUHJpbnRNYXJrZXIg KA0KPiAgICAgICAgLy8gQXJndW1lbnRTdHJpbmcgaXMgZWl0aGVyIG51bGwtdGVybWluYXRlZCwg b3IgaXQgY29udGFpbnMNCj4gUHJlY2lzaW9uIGNoYXJhY3RlcnMNCj4gICAgICAgIC8vDQo+ICAg ICAgICBmb3IgKENvdW50ID0gMDsNCj4gLSAgICAgICAgICAgIEFyZ3VtZW50U3RyaW5nW0NvdW50 ICogQnl0ZXNQZXJBcmd1bWVudENoYXJhY3Rlcl0gIT0gJ1wwJyAmJg0KPiArICAgICAgICAgICAg KEFyZ3VtZW50U3RyaW5nW0NvdW50ICogQnl0ZXNQZXJBcmd1bWVudENoYXJhY3Rlcl0gIT0gJ1ww JyB8fA0KPiArICAgICAgICAgICAgIChCeXRlc1BlckFyZ3VtZW50Q2hhcmFjdGVyID4gMSAmJg0K PiArICAgICAgICAgICAgICBBcmd1bWVudFN0cmluZ1tDb3VudCAqIEJ5dGVzUGVyQXJndW1lbnRD aGFyYWN0ZXIgKyAxXQ0KPiAhPSAnXDAnKSkgJiYNCj4gICAgICAgICAgICAgIChDb3VudCA8IFBy ZWNpc2lvbiB8fCAoKEZsYWdzICYgUFJFQ0lTSU9OKSA9PSAwKSk7DQo+ICAgICAgICAgICAgICAg IENvdW50KyspIHsNCj4gICAgICAgICAgQXJndW1lbnRDaGFyYWN0ZXIgPSAoKEFyZ3VtZW50U3Ry aW5nW0NvdW50ICoNCj4gQnl0ZXNQZXJBcmd1bWVudENoYXJhY3Rlcl0gJiAweGZmKSB8ICgoQXJn dW1lbnRTdHJpbmdbQ291bnQgKg0KPiBCeXRlc1BlckFyZ3VtZW50Q2hhcmFjdGVyICsgMV0pIDw8 IDgpKSAmIEFyZ3VtZW50TWFzazsNCj4gQEAgLTExNjcsNyArMTE2OSw5IEBAIEJhc2VQcmludExp YlNQcmludE1hcmtlciAoDQo+ICAgICAgLy8NCj4gICAgICAvLyBDb3B5IHRoZSBzdHJpbmcgaW50 byB0aGUgb3V0cHV0IGJ1ZmZlciBwZXJmb3JtaW5nIHRoZSByZXF1aXJlZA0KPiB0eXBlIGNvbnZl cnNpb25zDQo+ICAgICAgLy8NCj4gLSAgICB3aGlsZSAoSW5kZXggPCBDb3VudCAmJiAoKkFyZ3Vt ZW50U3RyaW5nKSAhPSAnXDAnKSB7DQo+ICsgICAgd2hpbGUgKEluZGV4IDwgQ291bnQgJiYNCj4g KyAgICAgICAgICAgKEFyZ3VtZW50U3RyaW5nWzBdICE9ICdcMCcgfHwNCj4gKyAgICAgICAgICAg IChCeXRlc1BlckFyZ3VtZW50Q2hhcmFjdGVyID4gMSAmJiBBcmd1bWVudFN0cmluZ1sxXSAhPSAn XDAnKSkpIHsNCj4gICAgICAgIEFyZ3VtZW50Q2hhcmFjdGVyID0gKCgqQXJndW1lbnRTdHJpbmcg JiAweGZmKSB8DQo+ICgoKFVJTlQ4KSooQXJndW1lbnRTdHJpbmcgKyAxKSkgPDwgOCkpICYgQXJn dW1lbnRNYXNrOw0KPiANCj4gICAgICAgIExlbmd0aFRvUmV0dXJuICs9ICgxICogQnl0ZXNQZXJP dXRwdXRDaGFyYWN0ZXIpOw0K