From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D5CBE22283508 for ; Tue, 6 Mar 2018 17:44:11 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2018 17:50:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,434,1515484800"; d="scan'208";a="36059496" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 06 Mar 2018 17:50:25 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 6 Mar 2018 17:50:25 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 6 Mar 2018 17:50:25 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.125]) with mapi id 14.03.0319.002; Wed, 7 Mar 2018 09:50:23 +0800 From: "Wang, Jian J" To: "Wu, Hao A" , "edk2-devel@lists.01.org" CC: "Zeng, Star" , "Dong, Eric" , "Yao, Jiewen" , "Ni, Ruiyu" Thread-Topic: [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard Thread-Index: AQHTtU+prjU2B8vLO0G1XZSN45LHaaPEAnKA Date: Wed, 7 Mar 2018 01:50:23 +0000 Message-ID: References: <20180306133303.14772-1-hao.a.wu@intel.com> In-Reply-To: <20180306133303.14772-1-hao.a.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzM4YjY4MjItNjNjMS00NTY0LTg2NzYtY2I4YmE4ODg2NGY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJkWnozWnFxMzdLUE5JUEVFdFIyNTNrYkVOanNJWkRmT2lUcXE2NFBHK0VvZ0xhRmtnRHZIcEZZZnhIZFdkbWhIIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 0/2] Resolve feature conflict between NX and Stack guard X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 01:44:12 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for fixing the issue. For this patch series: Reviewed-by: Jian J Wang > -----Original Message----- > From: Wu, Hao A > Sent: Tuesday, March 06, 2018 9:33 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Wang, Jian J ; > Zeng, Star ; Dong, Eric ; Yao, > Jiewen ; Ni, Ruiyu > Subject: [PATCH v2 0/2] Resolve feature conflict between NX and Stack gua= rd >=20 > V2 changes: >=20 > A. Use Hoblib APIs to get the base of stack from Hob. > B. Remove unnecessary local variable used in function > InitializeDxeNxMemoryProtectionPolicy(). >=20 > V1 history: >=20 > If enabled, NX memory protection feature will mark some types of active > memory as NX (non-executable), which includes the first page of the stack= . > This will overwrite the attributes of the first page of the stack if the > stack guard feature is also enabled. >=20 > The series will override the attributes setting to the first page of the > stack by adding back the 'EFI_MEMORY_RP' attribute when the stack guard > feature is enabled. >=20 > Cc: Jian J Wang > Cc: Star Zeng > Cc: Eric Dong > Cc: Jiewen Yao > Cc: Ruiyu Ni >=20 > Hao Wu (2): > MdeModulePkg/Core: Refine handling NULL detection in NX setting > MdeModulePkg/Core: Fix feature conflict between NX and Stack guard >=20 > MdeModulePkg/Core/Dxe/DxeMain.inf | 4 +- > MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 74 > +++++++++++++++++++++++---- > 2 files changed, 67 insertions(+), 11 deletions(-) >=20 > -- > 2.12.0.windows.1