public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [Patch] UefiCpuPkg CpuExceptionHandlerLib: use FixedPcdGetSize() as the macro value
Date: Fri, 16 Mar 2018 03:16:19 +0000	[thread overview]
Message-ID: <D827630B58408649ACB04F44C510003624D163BB@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20180316014706.15952-1-liming.gao@intel.com>

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

> -----Original Message-----
> From: Gao, Liming
> Sent: Friday, March 16, 2018 9:47 AM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [Patch] UefiCpuPkg CpuExceptionHandlerLib: use FixedPcdGetSize() as
> the macro value
> 
> FixedPcdGetSize() is used as the macro value, PcdGetSize() is used as global
> variable or function. Here usage is to access macro value.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Wang Jian J <jian.j.wang@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> ---
>  UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchInterruptDefs.h | 6 +++-
> --
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git
> a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchInterruptDefs.h
> b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchInterruptDefs.h
> index d9ded5977f..ac3650a2a3 100644
> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchInterruptDefs.h
> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchInterruptDefs.h
> @@ -1,7 +1,7 @@
>  /** @file
>    Ia32 arch definition for CPU Exception Handler Library.
> 
> -  Copyright (c) 2013, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2013 - 2018, Intel Corporation. All rights reserved.<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
>    which accompanies this distribution.  The full text of the license may be found
> at
> @@ -43,10 +43,10 @@ typedef struct {
> 
>  #define CPU_TSS_DESC_SIZE \
>    (sizeof (IA32_TSS_DESCRIPTOR) * \
> -   (PcdGetSize (PcdCpuStackSwitchExceptionList) + 1))
> +   (FixedPcdGetSize (PcdCpuStackSwitchExceptionList) + 1))
> 
>  #define CPU_TSS_SIZE \
>    (sizeof (IA32_TASK_STATE_SEGMENT) * \
> -   (PcdGetSize (PcdCpuStackSwitchExceptionList) + 1))
> +   (FixedPcdGetSize (PcdCpuStackSwitchExceptionList) + 1))
> 
>  #endif
> --
> 2.11.0.windows.1



      reply	other threads:[~2018-03-16  3:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-16  1:47 [Patch] UefiCpuPkg CpuExceptionHandlerLib: use FixedPcdGetSize() as the macro value Liming Gao
2018-03-16  3:16 ` Wang, Jian J [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D827630B58408649ACB04F44C510003624D163BB@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox