From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0AC2D21962301 for ; Wed, 8 Aug 2018 20:43:49 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2018 20:43:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,213,1531810800"; d="scan'208,217";a="71364381" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 08 Aug 2018 20:43:49 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Aug 2018 20:43:48 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Aug 2018 20:43:48 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.240]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Thu, 9 Aug 2018 11:43:46 +0800 From: "Wang, Jian J" To: "Ni, Ruiyu" , "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH 16/26] MdeModulePkg Core/Dxe: Remove redundant functions Thread-Index: AQHULvSmsALfgsSK3kGvAi7nY1WxqaS2OOwAgACPTfA= Date: Thu, 9 Aug 2018 03:43:45 +0000 Message-ID: References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-17-shenglei.zhang@intel.com> <734D49CCEBEEF84792F5B80ED585239D5BDC958B@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BDC958B@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmFhYzM5ZmUtZDc5Zi00NzFmLTkxYWEtYjU1ZGUyNmNmMmJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYXRzUTRnTHZ2TFV6SVJESFdIN21aOFlRT1BsU0cyUGdKVE85aFlDUE8zeXpCVXkwdmtmVUs1Q0NtVzh2cm1iaiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.27 Subject: Re: [PATCH 16/26] MdeModulePkg Core/Dxe: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 03:43:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For HeapGuard.c part, Reviewed-by: Jian J Wang > Regards, Jian From: Ni, Ruiyu Sent: Thursday, August 09, 2018 11:10 AM To: Zhang, Shenglei ; edk2-devel@lists.01.org Cc: Dong, Eric ; Zeng, Star ; Wan= g, Jian J Subject: RE: [edk2] [PATCH 16/26] MdeModulePkg Core/Dxe: Remove redundant f= unctions Copying Wang Jian. Reviewed-by: Ruiyu Ni > Thanks/Ray > -----Original Message----- > From: edk2-devel > On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric >; Zeng, S= tar > > Subject: [edk2] [PATCH 16/26] MdeModulePkg Core/Dxe: Remove > redundant functions > > The functions that are never called have been removed. > They are ClearGuardMapBit,SetGuardMapBit,IsHeadGuard, > IsTailGuard and CoreEfiNotAvailableYetArg0. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 > > Cc: Star Zeng > > Cc: Eric Dong > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > > --- > MdeModulePkg/Core/Dxe/DxeMain.h | 13 ----- > MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 22 ------- > MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 78 ------------------------- > 3 files changed, 113 deletions(-) > > diff --git a/MdeModulePkg/Core/Dxe/DxeMain.h > b/MdeModulePkg/Core/Dxe/DxeMain.h index 7ec82388a3..8f0b28d095 > 100644 > --- a/MdeModulePkg/Core/Dxe/DxeMain.h > +++ b/MdeModulePkg/Core/Dxe/DxeMain.h > @@ -2178,19 +2178,6 @@ CoreDisplayDiscoveredNotDispatched ( > ); > > > -/** > - Place holder function until all the Boot Services and Runtime Services= are > - available. > - > - @return EFI_NOT_AVAILABLE_YET > - > -**/ > -EFI_STATUS > -EFIAPI > -CoreEfiNotAvailableYetArg0 ( > - VOID > - ); > - > > /** > Place holder function until all the Boot Services and Runtime Services= are > diff --git a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c > b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c > index fc46022c3c..bbb048a127 100644 > --- a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c > +++ b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c > @@ -560,28 +560,6 @@ DxeMain ( > > > > -/** > - Place holder function until all the Boot Services and Runtime Services= are > - available. > - > - @return EFI_NOT_AVAILABLE_YET > - > -**/ > -EFI_STATUS > -EFIAPI > -CoreEfiNotAvailableYetArg0 ( > - VOID > - ) > -{ > - // > - // This function should never be executed. If it does, then the archi= tectural > protocols > - // have not been designed correctly. The CpuBreakpoint () is commente= d > out for now until the > - // DXE Core and all the Architectural Protocols are complete. > - // > - > - return EFI_NOT_AVAILABLE_YET; > -} > - > > /** > Place holder function until all the Boot Services and Runtime Services= are > diff --git a/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c > b/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c > index 447c56bb11..663f969c0d 100644 > --- a/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c > +++ b/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c > @@ -443,51 +443,6 @@ GetGuardMapBit ( > return 0; > } > > -/** > - Set the bit in bitmap table for the given address. > - > - @param[in] Address The address to set for. > - > - @return VOID. > -**/ > -VOID > -EFIAPI > -SetGuardMapBit ( > - IN EFI_PHYSICAL_ADDRESS Address > - ) > -{ > - UINT64 *GuardMap; > - UINT64 BitMask; > - > - FindGuardedMemoryMap (Address, TRUE, &GuardMap); > - if (GuardMap !=3D NULL) { > - BitMask =3D LShiftU64 (1, GUARDED_HEAP_MAP_ENTRY_BIT_INDEX > (Address)); > - *GuardMap |=3D BitMask; > - } > -} > - > -/** > - Clear the bit in bitmap table for the given address. > - > - @param[in] Address The address to clear for. > - > - @return VOID. > -**/ > -VOID > -EFIAPI > -ClearGuardMapBit ( > - IN EFI_PHYSICAL_ADDRESS Address > - ) > -{ > - UINT64 *GuardMap; > - UINT64 BitMask; > - > - FindGuardedMemoryMap (Address, TRUE, &GuardMap); > - if (GuardMap !=3D NULL) { > - BitMask =3D LShiftU64 (1, GUARDED_HEAP_MAP_ENTRY_BIT_INDEX > (Address)); > - *GuardMap &=3D ~BitMask; > - } > -} > > /** > Check to see if the page at the given address is a Guard page or not. > @@ -514,39 +469,6 @@ IsGuardPage ( > return ((BitMap =3D=3D BIT0) || (BitMap =3D=3D BIT2) || (BitMap =3D=3D= (BIT2 | BIT0))); } > > -/** > - Check to see if the page at the given address is a head Guard page or = not. > - > - @param[in] Address The address to check for > - > - @return TRUE The page at Address is a head Guard page > - @return FALSE The page at Address is not a head Guard page -**/ - > BOOLEAN -EFIAPI -IsHeadGuard ( > - IN EFI_PHYSICAL_ADDRESS Address > - ) > -{ > - return (GetGuardedMemoryBits (Address, 2) =3D=3D BIT1); -} > - > -/** > - Check to see if the page at the given address is a tail Guard page or = not. > - > - @param[in] Address The address to check for. > - > - @return TRUE The page at Address is a tail Guard page. > - @return FALSE The page at Address is not a tail Guard page. > -**/ > -BOOLEAN > -EFIAPI > -IsTailGuard ( > - IN EFI_PHYSICAL_ADDRESS Address > - ) > -{ > - return (GetGuardedMemoryBits (Address - EFI_PAGE_SIZE, 2) =3D=3D BIT0)= ; -} > > /** > Check to see if the page at the given address is guarded or not. > -- > 2.18.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel