public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
	edk2-devel <edk2-devel-bounces@lists.01.org>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 0/4] Add PEI Stack Guard feature
Date: Mon, 3 Sep 2018 04:56:37 +0000	[thread overview]
Message-ID: <D827630B58408649ACB04F44C510003624E2B72B@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503AD3BC46@shsmsx102.ccr.corp.intel.com>

Here're the tests I've done:

* Emulate stack overflow by calling a function recursively, for all BSP and APs, and
  check the RSP and CR2 to see if they're close in exception message.
* OS boot (x64): Fedora 26, Ubuntu 18.04, Windows 10, Windows 7 (Platform: OVMF)

Regards,
Jian

From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yao, Jiewen
Sent: Monday, September 03, 2018 12:15 PM
To: edk2-devel <edk2-devel-bounces@lists.01.org>; edk2-devel@lists.01.org
Subject: Re: [edk2] [PATCH 0/4] Add PEI Stack Guard feature

Hi
Would you please add more description on what test has been done for this patch?

Thank you
Yao Jiewen

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org]
> Sent: Monday, September 3, 2018 11:16 AM
> To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> Subject: [edk2] [PATCH 0/4] Add PEI Stack Guard feature
>
> This patch series try to add PEI Stack Guard feature. Please refer to
> following trackers for details.
>
> The machanism behind this feature is the same as Stack Guard for UEFI
> drivers, and similiar implementation is also employed.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1126
>      https://bugzilla.tianocore.org/show_bug.cgi?id=1137
>
> Jian J Wang (4):
>   MdeModulePkg/DxeIpl: disable paging before creating new page table
>   UefiCpuPkg/CpuExceptionHandlerLib: support stack switch for PEI
>     exceptions
>   UefiCpuPkg/MpInitLib: fix register restore issue in AP wakeup
>   UefiCpuPkg/CpuMpPei: support stack guard feature
>
>  MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c    |  10 +
>  UefiCpuPkg/CpuMpPei/CpuMpPei.c                     | 269 ++++++++-
>  UefiCpuPkg/CpuMpPei/CpuMpPei.h                     |  14 +
>  UefiCpuPkg/CpuMpPei/CpuMpPei.inf                   |  11 +-
>  UefiCpuPkg/CpuMpPei/CpuPaging.c                    | 637
> +++++++++++++++++++++
>  .../CpuExceptionHandlerLib/PeiCpuException.c       |  27 +-
>  .../PeiCpuExceptionHandlerLib.inf                  |   4 +
>  UefiCpuPkg/Library/MpInitLib/MpLib.c               |   8 +-
>  8 files changed, 962 insertions(+), 18 deletions(-)
>  create mode 100644 UefiCpuPkg/CpuMpPei/CpuPaging.c
>
> --
> 2.16.2.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2018-09-03  4:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03  3:15 [PATCH 0/4] Add PEI Stack Guard feature Jian J Wang
2018-09-03  3:15 ` [PATCH 1/4] MdeModulePkg/DxeIpl: disable paging before creating new page table Jian J Wang
2018-09-03  3:15 ` [PATCH 2/4] UefiCpuPkg/CpuExceptionHandlerLib: support stack switch for PEI exceptions Jian J Wang
2018-09-06  1:38   ` Dong, Eric
2018-09-03  3:15 ` [PATCH 3/4] UefiCpuPkg/MpInitLib: fix register restore issue in AP wakeup Jian J Wang
2018-09-05  5:29   ` Dong, Eric
2018-09-03  3:15 ` [PATCH 4/4] UefiCpuPkg/CpuMpPei: support stack guard feature Jian J Wang
2018-09-06  1:45   ` Dong, Eric
2018-09-06  2:42     ` Wang, Jian J
2018-09-03  4:14 ` [PATCH 0/4] Add PEI Stack Guard feature Yao, Jiewen
2018-09-03  4:56   ` Wang, Jian J [this message]
2018-09-03 14:52 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D827630B58408649ACB04F44C510003624E2B72B@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox