From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel-bounces@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CE74521125487; Fri, 7 Sep 2018 20:32:58 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Sep 2018 20:32:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,344,1531810800"; d="scan'208,217";a="68455599" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga007.fm.intel.com with ESMTP; 07 Sep 2018 20:32:25 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 7 Sep 2018 20:32:25 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 7 Sep 2018 20:32:24 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.240]) by shsmsx102.ccr.corp.intel.com ([169.254.2.226]) with mapi id 14.03.0319.002; Sat, 8 Sep 2018 11:32:22 +0800 From: "Wang, Jian J" To: edk2-devel , "edk2-devel@lists.01.org" CC: "Wu, Hao A" Thread-Topic: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix an incorrect bit-wise operation Thread-Index: AQHURx5qN2wAIicRAEG+UKaCfuN6UKTluJIggAACMNA= Date: Sat, 8 Sep 2018 03:32:22 +0000 Message-ID: References: <20180908024802.13488-1-jian.j.wang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjc1NDk3YmEtOGZlOC00YWY5LTg1MzktNTFiYzJjNmE1M2JiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUUEwZytDVFwvSklvQ1pvb0dCZkYyeWJkZyttc3hZOG53RFA3UGdmRDIxMWJ6ZzNrV21kWURxc1JxTGNUb2djTkoifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH] UefiCpuPkg/CpuDxe: fix an incorrect bit-wise operation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Sep 2018 03:32:59 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable And BZ#1164: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1164 Regards, Jian From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] Sent: Saturday, September 08, 2018 11:25 AM To: edk2-devel ; edk2-devel@lists.01.org Cc: Wu, Hao A Subject: Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix an incorrect bit-wise op= eration Forgot to mention BZ info: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1095 Regards, Jian > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] > Sent: Saturday, September 08, 2018 10:48 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > > Subject: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix an incorrect bit-wise oper= ation > > The left operand is 64-bit but right operand could be 32-bit. > A typecast is a must because of '~' op before it. > > Cc: Hao A Wu > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang > > --- > UefiCpuPkg/CpuDxe/CpuPageTable.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c > b/UefiCpuPkg/CpuDxe/CpuPageTable.c > index ef6e080a07..0a980b9753 100644 > --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c > +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c > @@ -1181,7 +1181,7 @@ DebugExceptionHandler ( > > for (PFEntry =3D 0; PFEntry < mPFEntryCount[CpuIndex]; PFEntry++) { > if (mLastPFEntryPointer[CpuIndex][PFEntry] !=3D NULL) { > - *mLastPFEntryPointer[CpuIndex][PFEntry] &=3D ~IA32_PG_P; > + *mLastPFEntryPointer[CpuIndex][PFEntry] &=3D ~(UINT64)IA32_PG_P; > } > } > > -- > 2.16.2.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel