From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A516121157439 for ; Tue, 25 Sep 2018 19:19:49 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 19:19:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,304,1534834800"; d="scan'208";a="93270124" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 25 Sep 2018 19:18:58 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 25 Sep 2018 19:18:58 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 25 Sep 2018 19:18:57 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.245]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.37]) with mapi id 14.03.0319.002; Wed, 26 Sep 2018 10:18:55 +0800 From: "Wang, Jian J" To: Laszlo Ersek , "Justen, Jordan L" , "edk2-devel@lists.01.org" CC: "Wu, Hao A" , "Bi, Dandan" , "Dong, Eric" , "Kinney, Michael D" Thread-Topic: [edk2] [PATCH] UefiCpuPkg/CpuMpPei: fix unsafe way to get stack pointer Thread-Index: AQHUTy68dbvzRFiZWU23OOPmG6gJqaT1zyeAgAEhAQCACu300A== Date: Wed, 26 Sep 2018 02:18:55 +0000 Message-ID: References: <20180918090448.7324-1-jian.j.wang@intel.com> <153729377116.1021.13677753557698494356@jljusten-skl> <47392a62-419a-45e2-6a09-5cec8b35cd55@redhat.com> In-Reply-To: <47392a62-419a-45e2-6a09-5cec8b35cd55@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjY3MjZjN2UtYjU2OS00NTAyLTkxYWMtMzM3ZDdkZTIzY2YzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidVVlbkRlYVJKTzVRbDN1cEFiZko4U28wUWplTFZ2UmtvRTV5NkJ3cHZZdmpGOEdcL3BreXdEWEhHcXA1OElqOFkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] UefiCpuPkg/CpuMpPei: fix unsafe way to get stack pointer X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 02:19:49 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGksDQoNClNpbmNlIHRoZSBwYXRjaCB3aWxsIGludHJvZHVjZSAiI2lmIGRlZmluZWQoLi4uKSIg bWFjcm8gaW4gY29kZSwgd2hpY2ggdmlvbGF0ZXMNCmVkazIgY29kaW5nIHN0eWxlLCBpdCdzIHN1 Z2dlc3RlZCB0byBhZGQgZXhjZXB0aW9uIHRvIHN0YXRpYyBjaGVja2VyLg0KDQpJJ2xsIHdhaXQg Zm9yIG9uZSBvciB0d28gZGF5cyBpbiBjYXNlIHRoZXJlJ3Mgb3RoZXIgc3VnZ2VzdGlvbnMuIElm IG5vIG9iamVjdGlvbg0KdGhlbiwgSSdsbCB3aXRoZHJhdyB0aGlzIHBhdGNoIGFuZCBjbG9zZSBC WiMxMTg2IGFzIG5vdC1maXguDQoNClJlZ2FyZHMsDQpKaWFuDQoNCg0KPiAtLS0tLU9yaWdpbmFs IE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBMYXN6bG8gRXJzZWsgW21haWx0bzpsZXJzZWtAcmVkaGF0 LmNvbV0NCj4gU2VudDogV2VkbmVzZGF5LCBTZXB0ZW1iZXIgMTksIDIwMTggNzoxNyBQTQ0KPiBU bzogSnVzdGVuLCBKb3JkYW4gTCA8am9yZGFuLmwuanVzdGVuQGludGVsLmNvbT47IFdhbmcsIEpp YW4gSg0KPiA8amlhbi5qLndhbmdAaW50ZWwuY29tPjsgZWRrMi1kZXZlbEBsaXN0cy4wMS5vcmcN Cj4gQ2M6IFd1LCBIYW8gQSA8aGFvLmEud3VAaW50ZWwuY29tPjsgQmksIERhbmRhbiA8ZGFuZGFu LmJpQGludGVsLmNvbT47DQo+IERvbmcsIEVyaWMgPGVyaWMuZG9uZ0BpbnRlbC5jb20+OyBLaW5u ZXksIE1pY2hhZWwgRA0KPiA8bWljaGFlbC5kLmtpbm5leUBpbnRlbC5jb20+DQo+IFN1YmplY3Q6 IFJlOiBbZWRrMl0gW1BBVENIXSBVZWZpQ3B1UGtnL0NwdU1wUGVpOiBmaXggdW5zYWZlIHdheSB0 byBnZXQgc3RhY2sNCj4gcG9pbnRlcg0KPiANCj4gT24gMDkvMTgvMTggMjA6MDIsIEpvcmRhbiBK dXN0ZW4gd3JvdGU6DQo+ID4gSSBndWVzcyB0aGUgZ2l0IGNvbmZpZyBzZW5kZW1haWwuZnJvbSBz ZXR0aW5nIGRpZCBub3QgaGVscCB5b3VyDQo+ID4gcGF0Y2hlcy4gPz8gSXQgc3RpbGwgaXMgY29t aW5nIHRocm91Z2ggd2l0aCBhIEZyb20gZmllbGQgb2YNCj4gPiA8ZWRrMi1kZXZlbC1ib3VuY2Vz QGxpc3RzLjAxLm9yZz4uDQo+ID4NCj4gPiBSZWdhcmRpbmcgdGhpcyBwYXRjaCwgSSBzdXBwb3Nl IGl0IGlzIHdvcnRoIGFza2luZyBpZiAmU3RhY2tCYXNlIGluDQo+ID4gdGhlIG9sZCBjb2RlIGNv dWxkIHBvc3NpYmx5IGJlIGFuIGFkZHJlc3Mgbm90IG9uIHRoZSBzdGFjay4gSSBkb24ndA0KPiA+ IHRoaW5rIGl0IGlzIHBvc3NpYmxlLCBhbmQgSSdtIGd1ZXNzaW5nIHRoZSBDIHNwZWNpZmljYXRp b24gd291bGQNCj4gPiBwcm9iYWJseSBiYWNrIHRoYXQgdXAuDQo+ID4NCj4gPiBJdCBjYW4gYmUg dW5zYWZlIHRvIGdldCBhbiBhZGRyZXNzIG9mIHNvbWV0aGluZyBvbiB0aGUgc3RhY2sgYW5kIHRo ZW4NCj4gPiByZWZlciB0byB0aGF0IGFkZHJlc3MgYWZ0ZXIgdGhlIHZhcmlhYmxlIGlzIG5vIGxv bmdlciBpbiBzY29wZS4gSQ0KPiA+IHN1c3BlY3QgdGhpcyBpcyB3aGF0IHRoZSBzdGF0aWMgY2hl Y2tlciBpcyBub3RpY2luZy4gQnkgY2FsbGluZw0KPiA+IFNldEp1bXAsIGFyZW4ndCB3ZSBqdXN0 IGRvaW5nIHRoZSBzYW1lIHRoaW5nLCBidXQgaGlkaW5nIHdoYXQgd2UgYXJlDQo+ID4gZG9pbmcg ZnJvbSB0aGUgc3RhdGljIGNoZWNrZXI/DQo+IA0KPiBZZXAsIHdlJ3JlIHRvdGFsbHkgZG9pbmcg dGhhdC4NCj4gDQo+IFRoYW5rcywNCj4gTGFzemxvDQo+IA0KPiA+DQo+ID4gU28sIGNhbid0IHdl IGp1c3QgdGVsbCB0aGUgc3RhdGljIGNoZWNrZXIgdG8gaWdub3JlIHRoZSBlcnJvciBiZWNhdXNl DQo+ID4gd2Uga25vdyB3aGF0IHdlIGFyZSBkb2luZz8NCj4gPg0KPiA+IC1Kb3JkYW4NCj4gPg0K PiA+IE9uIDIwMTgtMDktMTggMDI6MDQ6NDgsICB3cm90ZToNCj4gPj4gUkVGOiBodHRwczovL2J1 Z3ppbGxhLnRpYW5vY29yZS5vcmcvc2hvd19idWcuY2dpP2lkPTExODYNCj4gPj4NCj4gPj4gVGhp cyBwYXRjaCB1c2VzIFNldEp1bXAoKSB0byBnZXQgdGhlIHN0YWNrIHBvaW50ZXIgZnJvbSBlc3Av cnNwDQo+ID4+IHJlZ2lzdGVyIHRvIHJlcGxhY2UgbG9jYWwgdmFyaWFibGUgd2F5LCB3aGljaCB3 YXMgbWFya2VkIGJ5IHN0YXRpYw0KPiA+PiBjb2RlIGNoZWNrZXIgYXMgYW4gdW5zYWZlIHdheS4N Cj4gPj4NCj4gPj4gQ2M6IERhbmRhbiBCaSA8ZGFuZGFuLmJpQGludGVsLmNvbT4NCj4gPj4gQ2M6 IEhhbyBBIFd1IDxoYW8uYS53dUBpbnRlbC5jb20+DQo+ID4+IENjOiBFcmljIERvbmcgPGVyaWMu ZG9uZ0BpbnRlbC5jb20+DQo+ID4+IENjOiBMYXN6bG8gRXJzZWsgPGxlcnNla0ByZWRoYXQuY29t Pg0KPiA+PiBDb250cmlidXRlZC11bmRlcjogVGlhbm9Db3JlIENvbnRyaWJ1dGlvbiBBZ3JlZW1l bnQgMS4xDQo+ID4+IFNpZ25lZC1vZmYtYnk6IEppYW4gSiBXYW5nIDxqaWFuLmoud2FuZ0BpbnRl bC5jb20+DQo+ID4+IC0tLQ0KPiA+PiAgVWVmaUNwdVBrZy9DcHVNcFBlaS9DcHVNcFBlaS5oICB8 IDggKysrKysrKysNCj4gPj4gIFVlZmlDcHVQa2cvQ3B1TXBQZWkvQ3B1UGFnaW5nLmMgfCA5ICsr KysrKystLQ0KPiA+PiAgMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAyIGRlbGV0 aW9ucygtKQ0KPiA+Pg0KPiA+PiBkaWZmIC0tZ2l0IGEvVWVmaUNwdVBrZy9DcHVNcFBlaS9DcHVN cFBlaS5oDQo+IGIvVWVmaUNwdVBrZy9DcHVNcFBlaS9DcHVNcFBlaS5oDQo+ID4+IGluZGV4IGQw OTdhNjZhYTguLmZlNjFmNWUzYmMgMTAwNjQ0DQo+ID4+IC0tLSBhL1VlZmlDcHVQa2cvQ3B1TXBQ ZWkvQ3B1TXBQZWkuaA0KPiA+PiArKysgYi9VZWZpQ3B1UGtnL0NwdU1wUGVpL0NwdU1wUGVpLmgN Cj4gPj4gQEAgLTM1LDYgKzM1LDE0IEBADQo+ID4+DQo+ID4+ICBleHRlcm4gRUZJX1BFSV9QUElf REVTQ1JJUFRPUiAgIG1QZWlDcHVNcFBwaURlc2M7DQo+ID4+DQo+ID4+ICsjaWYgICBkZWZpbmVk IChNREVfQ1BVX0lBMzIpDQo+ID4+ICsjZGVmaW5lIENQVV9TVEFDS19QT0lOVEVSKENvbnRleHQp ICAoKENvbnRleHQpLkVzcCkNCj4gPj4gKyNlbGlmIGRlZmluZWQgKE1ERV9DUFVfWDY0KQ0KPiA+ PiArI2RlZmluZSBDUFVfU1RBQ0tfUE9JTlRFUihDb250ZXh0KSAgKChDb250ZXh0KS5Sc3ApDQo+ ID4+ICsjZWxzZQ0KPiA+PiArI2Vycm9yIENQVSB0eXBlIG5vdCBzdXBwb3J0ZWQhDQo+ID4+ICsj ZW5kaWYNCj4gPj4gKw0KPiA+PiAgLyoqDQo+ID4+ICAgIFRoaXMgc2VydmljZSByZXRyaWV2ZXMg dGhlIG51bWJlciBvZiBsb2dpY2FsIHByb2Nlc3NvciBpbiB0aGUgcGxhdGZvcm0NCj4gPj4gICAg YW5kIHRoZSBudW1iZXIgb2YgdGhvc2UgbG9naWNhbCBwcm9jZXNzb3JzIHRoYXQgYXJlIGVuYWJs ZWQgb24gdGhpcyBib290Lg0KPiA+PiBkaWZmIC0tZ2l0IGEvVWVmaUNwdVBrZy9DcHVNcFBlaS9D cHVQYWdpbmcuYw0KPiBiL1VlZmlDcHVQa2cvQ3B1TXBQZWkvQ3B1UGFnaW5nLmMNCj4gPj4gaW5k ZXggYzdlMDgyMjQ1Mi4uOTk3YzIwYzI2ZSAxMDA2NDQNCj4gPj4gLS0tIGEvVWVmaUNwdVBrZy9D cHVNcFBlaS9DcHVQYWdpbmcuYw0KPiA+PiArKysgYi9VZWZpQ3B1UGtnL0NwdU1wUGVpL0NwdVBh Z2luZy5jDQo+ID4+IEBAIC01MTcsOSArNTE3LDE0IEBAIEdldFN0YWNrQmFzZSAoDQo+ID4+ICAg IElOIE9VVCBWT0lEICpCdWZmZXINCj4gPj4gICAgKQ0KPiA+PiAgew0KPiA+PiAtICBFRklfUEhZ U0lDQUxfQUREUkVTUyAgICBTdGFja0Jhc2U7DQo+ID4+ICsgIEVGSV9QSFlTSUNBTF9BRERSRVNT ICAgICAgU3RhY2tCYXNlOw0KPiA+PiArICBCQVNFX0xJQlJBUllfSlVNUF9CVUZGRVIgIENvbnRl eHQ7DQo+ID4+DQo+ID4+IC0gIFN0YWNrQmFzZSA9IChFRklfUEhZU0lDQUxfQUREUkVTUykoVUlO VE4pJlN0YWNrQmFzZTsNCj4gPj4gKyAgLy8NCj4gPj4gKyAgLy8gUmV0cmlldmUgc3RhY2sgcG9p bnRlciBmcm9tIGN1cnJlbnQgcHJvY2Vzc29yIGNvbnRleHQuDQo+ID4+ICsgIC8vDQo+ID4+ICsg IFNldEp1bXAgKCZDb250ZXh0KTsNCj4gPj4gKyAgU3RhY2tCYXNlID0gKEVGSV9QSFlTSUNBTF9B RERSRVNTKUNQVV9TVEFDS19QT0lOVEVSIChDb250ZXh0KTsNCj4gPj4gICAgU3RhY2tCYXNlICs9 IEJBU0VfNEtCOw0KPiA+PiAgICBTdGFja0Jhc2UgJj0gfigoRUZJX1BIWVNJQ0FMX0FERFJFU1Mp QkFTRV80S0IgLSAxKTsNCj4gPj4gICAgU3RhY2tCYXNlIC09IFBjZEdldDMyKFBjZENwdUFwU3Rh Y2tTaXplKTsNCj4gPj4gLS0NCj4gPj4gMi4xNi4yLndpbmRvd3MuMQ0KPiA+Pg0KPiA+PiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0KPiA+PiBlZGsyLWRl dmVsIG1haWxpbmcgbGlzdA0KPiA+PiBlZGsyLWRldmVsQGxpc3RzLjAxLm9yZw0KPiA+PiBodHRw czovL2xpc3RzLjAxLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2VkazItZGV2ZWwNCg0K