From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>, "Ni, Ruiyu" <ruiyu.ni@intel.com>
Subject: Re: [PATCH] MdeModulePkg: Remove PcdIdentifyMappingPageTablePtr
Date: Fri, 16 Nov 2018 01:59:51 +0000 [thread overview]
Message-ID: <D827630B58408649ACB04F44C510003624EA1CE2@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20181115074605.11832-1-shenglei.zhang@intel.com>
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Thursday, November 15, 2018 3:46 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Ni,
> Ruiyu <ruiyu.ni@intel.com>; Zhang, Shenglei <shenglei.zhang@intel.com>
> Subject: [PATCH] MdeModulePkg: Remove PcdIdentifyMappingPageTablePtr
>
> PcdIdentifyMappingPageTablePtr is useless and could be
> removed.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1304
>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> ---
> MdeModulePkg/MdeModulePkg.dec | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec
> index 428eeeb670..0abacc1a90 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -2007,12 +2007,6 @@
> # @ValidList 0x80000001 | 0x0
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdS3BootScriptTablePrivateSmmDataPtr|
> 0x0|UINT64|0x00030001
>
> - ## This dynamic PCD hold an address to point to the memory of page table.
> The page table establishes a 1:1
> - # Virtual to Physical mapping according to the processor physical address bits.
> - # @Prompt Identify Mapping Page Table pointer.
> - # @ValidList 0x80000001 | 0x0
> -
> gEfiMdeModulePkgTokenSpaceGuid.PcdIdentifyMappingPageTablePtr|0x0|UIN
> T64|0x00030002
> -
> ## This dynamic PCD holds the information if there is any test key used by the
> platform.
> # @Prompt If there is any test key used by the platform.
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdTestKeyUsed|FALSE|BOOLEAN|0x0003
> 0003
> --
> 2.18.0.windows.1
next prev parent reply other threads:[~2018-11-16 2:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 7:46 [PATCH] MdeModulePkg: Remove PcdIdentifyMappingPageTablePtr Shenglei Zhang
2018-11-16 1:59 ` Wang, Jian J [this message]
2018-11-16 2:37 ` Zeng, Star
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D827630B58408649ACB04F44C510003624EA1CE2@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox