From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Sun, Zailiang" <zailiang.sun@intel.com>,
"Zeng, Star" <star.zeng@intel.com>,
"Ni, Ruiyu" <ruiyu.ni@intel.com>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH v2 0/3] Remove S3Lib and RecoveryLib class
Date: Tue, 20 Nov 2018 01:15:21 +0000 [thread overview]
Message-ID: <D827630B58408649ACB04F44C510003624EA3195@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20181119073015.16100-1-shenglei.zhang@intel.com>
Shenglei,
I think it would be better to split the patch series in following order:
1. package dec/dsc/uni
2. changes of each module (one patch per module)
3. public header files
Regards,
Jian
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Monday, November 19, 2018 3:30 PM
> To: edk2-devel@lists.01.org
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Zeng, Star <star.zeng@intel.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Gao,
> Liming <liming.gao@intel.com>
> Subject: [PATCH v2 0/3] Remove S3Lib and RecoveryLib class
>
> S3Lib and RecoveryLib have been deprecated since 2009.
> There is no code using AcpiS3ResumeOs() interface in
> S3Lib and PeiRecoverFirmware() interface in RecoveryLib.
> So they can be removed from edk2 repo.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1299
>
> v2:Remove S3Lib.h and RecoveryLib.h. in MdeModulePkg.
>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> Shenglei Zhang (3):
> IntelFrameworkModulePkg: Remove PeiS3Lib and PeiRecoveryLib
> Vlv2TbltDevicePkg: Remove PeiS3Lib in DSC
> MdeModulePkg: Remove PeiS3LibNull and PeiRecoveryLibNull
>
> .../IntelFrameworkModulePkg.dsc | 2 -
> .../Library/PeiRecoveryLib/PeiRecoveryLib.c | 50 ------------------
> .../Library/PeiRecoveryLib/PeiRecoveryLib.inf | 50 ------------------
> .../Library/PeiRecoveryLib/PeiRecoveryLib.uni | 23 ---------
> .../Library/PeiS3Lib/PeiS3Lib.c | 51 -------------------
> .../Library/PeiS3Lib/PeiS3Lib.inf | 49 ------------------
> .../Library/PeiS3Lib/PeiS3Lib.uni | 23 ---------
> MdeModulePkg/Core/DxeIplPeim/DxeIpl.h | 2 -
> MdeModulePkg/Include/Library/RecoveryLib.h | 35 -------------
> MdeModulePkg/Include/Library/S3Lib.h | 34 -------------
> .../PeiRecoveryLibNull/PeiRecoveryLibNull.c | 34 -------------
> .../PeiRecoveryLibNull/PeiRecoveryLibNull.inf | 39 --------------
> .../PeiRecoveryLibNull/PeiRecoveryLibNull.uni | 24 ---------
> .../Library/PeiS3LibNull/PeiS3LibNull.c | 35 -------------
> .../Library/PeiS3LibNull/PeiS3LibNull.inf | 40 ---------------
> .../Library/PeiS3LibNull/PeiS3LibNull.uni | 24 ---------
> MdeModulePkg/MdeModulePkg.dec | 10 ----
> MdeModulePkg/MdeModulePkg.dsc | 2 -
> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 3 --
> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 3 --
> Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 3 --
> 21 files changed, 536 deletions(-)
> delete mode 100644
> IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.c
> delete mode 100644
> IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.inf
> delete mode 100644
> IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.uni
> delete mode 100644 IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.c
> delete mode 100644 IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.inf
> delete mode 100644 IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.uni
> delete mode 100644 MdeModulePkg/Include/Library/RecoveryLib.h
> delete mode 100644 MdeModulePkg/Include/Library/S3Lib.h
> delete mode 100644
> MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.c
> delete mode 100644
> MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.inf
> delete mode 100644
> MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.uni
> delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.c
> delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.inf
> delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.uni
>
> --
> 2.18.0.windows.1
prev parent reply other threads:[~2018-11-20 1:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 7:30 [PATCH v2 0/3] Remove S3Lib and RecoveryLib class Shenglei Zhang
2018-11-19 7:30 ` [PATCH v2 1/3] IntelFrameworkModulePkg: Remove PeiS3Lib and PeiRecoveryLib Shenglei Zhang
2018-11-19 7:30 ` [PATCH v2 2/3] Vlv2TbltDevicePkg: Remove PeiS3Lib in DSC Shenglei Zhang
2018-11-19 7:30 ` [PATCH v2 3/3] MdeModulePkg: Remove PeiS3LibNull and PeiRecoveryLibNull Shenglei Zhang
2018-11-20 1:15 ` Wang, Jian J [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D827630B58408649ACB04F44C510003624EA3195@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox