From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C95F521A07A82 for ; Mon, 19 Nov 2018 17:15:25 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2018 17:15:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,254,1539673200"; d="scan'208";a="101601112" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 19 Nov 2018 17:15:24 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 19 Nov 2018 17:15:24 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 19 Nov 2018 17:15:23 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.161]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.117]) with mapi id 14.03.0415.000; Tue, 20 Nov 2018 09:15:22 +0800 From: "Wang, Jian J" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Sun, Zailiang" , "Zeng, Star" , "Ni, Ruiyu" , "Gao, Liming" Thread-Topic: [PATCH v2 0/3] Remove S3Lib and RecoveryLib class Thread-Index: AQHUf9nG5C3SbK2V1EGeDC+BY/44AqVX21Ug Date: Tue, 20 Nov 2018 01:15:21 +0000 Message-ID: References: <20181119073015.16100-1-shenglei.zhang@intel.com> In-Reply-To: <20181119073015.16100-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjMzYjMyNjctYjA3OC00MWZkLTgxNjktNzVlMGE0M2ExZWZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaStyRGgzR1A4WVBGWlluMlN3aUhnbHVGWmNxaUUzZTRGTkhjbDhzM2hDYlBoSlUzWTZWXC8zVnRlME82TGF4eUYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 0/3] Remove S3Lib and RecoveryLib class X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 01:15:26 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Shenglei, I think it would be better to split the patch series in following order: 1. package dec/dsc/uni 2. changes of each module (one patch per module) 3. public header files Regards, Jian > -----Original Message----- > From: Zhang, Shenglei > Sent: Monday, November 19, 2018 3:30 PM > To: edk2-devel@lists.01.org > Cc: Sun, Zailiang ; Zeng, Star ; > Wang, Jian J ; Ni, Ruiyu ; Gao= , > Liming > Subject: [PATCH v2 0/3] Remove S3Lib and RecoveryLib class >=20 > S3Lib and RecoveryLib have been deprecated since 2009. > There is no code using AcpiS3ResumeOs() interface in > S3Lib and PeiRecoverFirmware() interface in RecoveryLib. > So they can be removed from edk2 repo. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1299 >=20 > v2:Remove S3Lib.h and RecoveryLib.h. in MdeModulePkg. >=20 > Cc: Zailiang Sun > Cc: Star Zeng > Cc: Jian J Wang > Cc: Ruiyu Ni > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > Shenglei Zhang (3): > IntelFrameworkModulePkg: Remove PeiS3Lib and PeiRecoveryLib > Vlv2TbltDevicePkg: Remove PeiS3Lib in DSC > MdeModulePkg: Remove PeiS3LibNull and PeiRecoveryLibNull >=20 > .../IntelFrameworkModulePkg.dsc | 2 - > .../Library/PeiRecoveryLib/PeiRecoveryLib.c | 50 ------------------ > .../Library/PeiRecoveryLib/PeiRecoveryLib.inf | 50 ------------------ > .../Library/PeiRecoveryLib/PeiRecoveryLib.uni | 23 --------- > .../Library/PeiS3Lib/PeiS3Lib.c | 51 ------------------- > .../Library/PeiS3Lib/PeiS3Lib.inf | 49 ------------------ > .../Library/PeiS3Lib/PeiS3Lib.uni | 23 --------- > MdeModulePkg/Core/DxeIplPeim/DxeIpl.h | 2 - > MdeModulePkg/Include/Library/RecoveryLib.h | 35 ------------- > MdeModulePkg/Include/Library/S3Lib.h | 34 ------------- > .../PeiRecoveryLibNull/PeiRecoveryLibNull.c | 34 ------------- > .../PeiRecoveryLibNull/PeiRecoveryLibNull.inf | 39 -------------- > .../PeiRecoveryLibNull/PeiRecoveryLibNull.uni | 24 --------- > .../Library/PeiS3LibNull/PeiS3LibNull.c | 35 ------------- > .../Library/PeiS3LibNull/PeiS3LibNull.inf | 40 --------------- > .../Library/PeiS3LibNull/PeiS3LibNull.uni | 24 --------- > MdeModulePkg/MdeModulePkg.dec | 10 ---- > MdeModulePkg/MdeModulePkg.dsc | 2 - > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 3 -- > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 3 -- > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 3 -- > 21 files changed, 536 deletions(-) > delete mode 100644 > IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.c > delete mode 100644 > IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.inf > delete mode 100644 > IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.uni > delete mode 100644 IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.c > delete mode 100644 IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.inf > delete mode 100644 IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.uni > delete mode 100644 MdeModulePkg/Include/Library/RecoveryLib.h > delete mode 100644 MdeModulePkg/Include/Library/S3Lib.h > delete mode 100644 > MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.c > delete mode 100644 > MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.inf > delete mode 100644 > MdeModulePkg/Library/PeiRecoveryLibNull/PeiRecoveryLibNull.uni > delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.c > delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.inf > delete mode 100644 MdeModulePkg/Library/PeiS3LibNull/PeiS3LibNull.uni >=20 > -- > 2.18.0.windows.1