Re: [PATCH V2 0/7] Remove PcdPeiCoreMaxXXX PCDs

["Wang, Jian J" <jian.j.wang@intel.com>]

For patch 1,3,4,7, 

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>


> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star
> Zeng
> Sent: Tuesday, December 18, 2018 2:08 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH V2 0/7] Remove PcdPeiCoreMaxXXX PCDs
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405
> 
> V2:
> 1. Pick up some RB tags.
> 2. Handle the great comment from Jian for patch 1/7 at
> https://lists.01.org/pipermail/edk2-devel/2018-December/034121.html.
> 
> Repo: git@github.com:lzeng14/edk2.git
> Branch: RemovePcdPeiCoreMaxXXX_V2
> 
> Test done:
> Make sure the Private->CurrentFvFileHandles content could be same.
> 
> V1:
> Repo: git@github.com:lzeng14/edk2.git
> Branch: RemovePcdPeiCoreMaxXXX
> 
> Background as below.
> 
> Problem:
> As static configuration from the PCDs, the binary PeiCore (for example
> in FSP binary with dispatch mode) could not predict how many FVs,
> Files or PPIs for different platforms.
> 
> Burden:
> Platform developers need configure the PCDs accordingly for different
> platforms.
> 
> To solve the problem and remove the burden, we can update code to
> remove the using of PcdPeiCoreMaxFvSupported, PcdPeiCoreMaxPeimPerFv
> and PcdPeiCoreMaxPpiSupported by extending buffer dynamically for FV,
> File and PPI management.
> 
> Test done:
> Build code with VS2012, VS2015 and GCC49.
> Boot Nt32, Ovmf (including 32, 3264 and 64 with no SMM) to UEFI SHELL.
> Boot some internal platforms (including a platform with dispatch mode
> FSP binary) to UEFI SHELL and Windows.
> 
> More test will be welcome and appreciated. :)
> 
> Patches to update edk2-platforms Repo will be sent out separately.
> 
> Star Zeng (7):
>   MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPeimPerFv
>   SecurityPkg Tcg(2)Pei: Remove the using of PcdPeiCoreMaxFvSupported
>   MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxFvSupported
>   MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPpiSupported
>   OvmfPkg: Remove PcdPeiCoreMaxXXX PCDs' statement
>   Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' statement
>   MdeModulePkg: Remove PcdPeiCoreMaxXXX PCDs
> 
>  MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 181 +++++++------
>  MdeModulePkg/Core/Pei/FwVol/FwVol.c           |  67 ++++-
>  MdeModulePkg/Core/Pei/PeiMain.h               |  96 +++++--
>  MdeModulePkg/Core/Pei/PeiMain.inf             |   3 -
>  MdeModulePkg/Core/Pei/PeiMain/PeiMain.c       |  94 +++----
>  MdeModulePkg/Core/Pei/Ppi/Ppi.c               | 355 ++++++++++++++------------
>  MdeModulePkg/MdeModulePkg.dec                 |  13 -
>  MdeModulePkg/MdeModulePkg.uni                 |  12 -
>  OvmfPkg/OvmfPkgIa32.dsc                       |   2 -
>  OvmfPkg/OvmfPkgIa32X64.dsc                    |   2 -
>  OvmfPkg/OvmfPkgX64.dsc                        |   2 -
>  SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c             |  59 +++--
>  SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf           |   1 -
>  SecurityPkg/Tcg/TcgPei/TcgPei.c               |  59 +++--
>  SecurityPkg/Tcg/TcgPei/TcgPei.inf             |   1 -
>  Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc       |   2 -
>  Vlv2TbltDevicePkg/PlatformPkgIA32.dsc         |   2 -
>  Vlv2TbltDevicePkg/PlatformPkgX64.dsc          |   2 -
>  18 files changed, 539 insertions(+), 414 deletions(-)
> 
> --
> 2.7.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel