From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 17B4F2119BAE2 for ; Mon, 17 Dec 2018 23:21:39 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2018 23:21:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,367,1539673200"; d="scan'208";a="260346533" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 17 Dec 2018 23:21:37 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 17 Dec 2018 23:21:37 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 17 Dec 2018 23:21:36 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.59]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.201]) with mapi id 14.03.0415.000; Tue, 18 Dec 2018 15:21:35 +0800 From: "Wang, Jian J" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [edk2] [PATCH V2 0/7] Remove PcdPeiCoreMaxXXX PCDs Thread-Index: AQHUlpgptELmphH9TU29nhgxRZkdaqWEFwsQ Date: Tue, 18 Dec 2018 07:21:34 +0000 Message-ID: References: <1545113286-49760-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1545113286-49760-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmNjZjY2MmQtMDUwYy00YTgxLWIxNGItOGJlZDM0ODg4MzU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMVJqV0w4RmJJbG1hNXpxZ3FLVDhxbzJ3SUt0ZGtPNlhGYlZRN1FxanBxMDlCMm5Ycys3SlhaT2FIOTBNWkNPQSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH V2 0/7] Remove PcdPeiCoreMaxXXX PCDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2018 07:21:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For patch 1,3,4,7,=20 Reviewed-by: Jian J Wang > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of St= ar > Zeng > Sent: Tuesday, December 18, 2018 2:08 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: [edk2] [PATCH V2 0/7] Remove PcdPeiCoreMaxXXX PCDs >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1405 >=20 > V2: > 1. Pick up some RB tags. > 2. Handle the great comment from Jian for patch 1/7 at > https://lists.01.org/pipermail/edk2-devel/2018-December/034121.html. >=20 > Repo: git@github.com:lzeng14/edk2.git > Branch: RemovePcdPeiCoreMaxXXX_V2 >=20 > Test done: > Make sure the Private->CurrentFvFileHandles content could be same. >=20 > V1: > Repo: git@github.com:lzeng14/edk2.git > Branch: RemovePcdPeiCoreMaxXXX >=20 > Background as below. >=20 > Problem: > As static configuration from the PCDs, the binary PeiCore (for example > in FSP binary with dispatch mode) could not predict how many FVs, > Files or PPIs for different platforms. >=20 > Burden: > Platform developers need configure the PCDs accordingly for different > platforms. >=20 > To solve the problem and remove the burden, we can update code to > remove the using of PcdPeiCoreMaxFvSupported, PcdPeiCoreMaxPeimPerFv > and PcdPeiCoreMaxPpiSupported by extending buffer dynamically for FV, > File and PPI management. >=20 > Test done: > Build code with VS2012, VS2015 and GCC49. > Boot Nt32, Ovmf (including 32, 3264 and 64 with no SMM) to UEFI SHELL. > Boot some internal platforms (including a platform with dispatch mode > FSP binary) to UEFI SHELL and Windows. >=20 > More test will be welcome and appreciated. :) >=20 > Patches to update edk2-platforms Repo will be sent out separately. >=20 > Star Zeng (7): > MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPeimPerFv > SecurityPkg Tcg(2)Pei: Remove the using of PcdPeiCoreMaxFvSupported > MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxFvSupported > MdeModulePkg PeiCore: Remove the using of PcdPeiCoreMaxPpiSupported > OvmfPkg: Remove PcdPeiCoreMaxXXX PCDs' statement > Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' statement > MdeModulePkg: Remove PcdPeiCoreMaxXXX PCDs >=20 > MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 181 +++++++------ > MdeModulePkg/Core/Pei/FwVol/FwVol.c | 67 ++++- > MdeModulePkg/Core/Pei/PeiMain.h | 96 +++++-- > MdeModulePkg/Core/Pei/PeiMain.inf | 3 - > MdeModulePkg/Core/Pei/PeiMain/PeiMain.c | 94 +++---- > MdeModulePkg/Core/Pei/Ppi/Ppi.c | 355 ++++++++++++++------= ------ > MdeModulePkg/MdeModulePkg.dec | 13 - > MdeModulePkg/MdeModulePkg.uni | 12 - > OvmfPkg/OvmfPkgIa32.dsc | 2 - > OvmfPkg/OvmfPkgIa32X64.dsc | 2 - > OvmfPkg/OvmfPkgX64.dsc | 2 - > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 59 +++-- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 - > SecurityPkg/Tcg/TcgPei/TcgPei.c | 59 +++-- > SecurityPkg/Tcg/TcgPei/TcgPei.inf | 1 - > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 2 - > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 2 - > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 2 - > 18 files changed, 539 insertions(+), 414 deletions(-) >=20 > -- > 2.7.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel