From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AD6D521962301 for ; Wed, 2 Jan 2019 21:02:07 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2019 21:02:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,433,1539673200"; d="scan'208";a="122933397" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 02 Jan 2019 21:02:06 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 2 Jan 2019 21:02:06 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 2 Jan 2019 21:02:06 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.150]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.45]) with mapi id 14.03.0415.000; Thu, 3 Jan 2019 13:02:04 +0800 From: "Wang, Jian J" To: Laszlo Ersek , edk2-devel-01 CC: "Wei, Gang" , "Ye, Ting" Thread-Topic: [PATCH 25/26] CryptoPkg/BaseCryptLib: drop build flags specific to GCC44 Thread-Index: AQHUow7ugcAgBtOb1kSfp0aekU3yfKWc/MVA Date: Thu, 3 Jan 2019 05:02:04 +0000 Message-ID: References: <20190103024816.9236-1-lersek@redhat.com> <20190103024816.9236-26-lersek@redhat.com> In-Reply-To: <20190103024816.9236-26-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjdmZWU5Y2MtZDZjYy00NDYyLWE0YWItNGIxNWU4MzY0MDNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUVZcL05sb0JBbUpmdlIrbk51N0lkSVV1d2FWQnZvOWw1UWdNUDFzd1NCenB0ZEdacmFoZVpBWmJ0eFwvSFc2MVRkIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 25/26] CryptoPkg/BaseCryptLib: drop build flags specific to GCC44 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 05:02:07 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jian J Wang > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Thursday, January 03, 2019 10:48 AM > To: edk2-devel-01 > Cc: Wei, Gang ; Wang, Jian J ; > Ye, Ting > Subject: [PATCH 25/26] CryptoPkg/BaseCryptLib: drop build flags specific = to > GCC44 >=20 > We've removed BaseTools support for GCC44..GCC47. Drop > CryptoPkg/BaseCryptLib build flags that are specific to any of those gcc > versions. >=20 > No GCC44..GCC47 references remain under CryptoPkg after this patch. >=20 > Cc: Gang Wei > Cc: Jian Wang > Cc: Ting Ye > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1377 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > Build tested with: >=20 > ( > set -e > for INF in CryptoPkg/Library/BaseCryptLib/*.inf; do > build -t GCC48 -a IA32 -b DEBUG -p CryptoPkg/CryptoPkg.dsc \ > -m "$INF" > done > ) >=20 > CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 2 -- > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 -- > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 2 -- > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 1 - > 4 files changed, 7 deletions(-) >=20 > diff --git a/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > index f29445ce3402..0d81db2fbd7f 100644 > --- a/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > @@ -96,8 +96,6 @@ [BuildOptions] > # > MSFT:*_*_*_CC_FLAGS =3D /wd4090 >=20 > - GCC:*_GCC44_IA32_CC_FLAGS =3D "-D__cdecl=3D__attribute__((cdecl))" "- > D__declspec(t)=3D__attribute__((t))" > - > # -JCryptoPkg/Include : To disable the use of the system includes prov= ided by > RVCT > # --diag_remark=3D1 : Reduce severity of "#1-D: last line of file = ends without a > newline" > RVCT:*_*_ARM_CC_FLAGS =3D -JCryptoPkg/Include --diag_remark=3D1 > diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > index e7b4b2f61855..4bcf064c5623 100644 > --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > @@ -93,8 +93,6 @@ [BuildOptions] > # > MSFT:*_*_*_CC_FLAGS =3D /wd4090 /wd4718 >=20 > - GCC:*_GCC44_IA32_CC_FLAGS =3D "-D__cdecl=3D__attribute__((cdecl))" "- > D__declspec(t)=3D__attribute__((t))" > - > # -JCryptoPkg/Include : To disable the use of the system includes prov= ided by > RVCT > # --diag_remark=3D1 : Reduce severity of "#1-D: last line of file = ends without a > newline" > RVCT:*_*_ARM_CC_FLAGS =3D -JCryptoPkg/Include --diag_remark=3D1 > diff --git a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > index 32628c8835a6..a6e433f6ced1 100644 > --- a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > @@ -102,8 +102,6 @@ [BuildOptions] > # > MSFT:*_*_*_CC_FLAGS =3D /wd4090 >=20 > - GCC:*_GCC44_IA32_CC_FLAGS =3D "-D__cdecl=3D__attribute__((cdecl))" "- > D__declspec(t)=3D__attribute__((t))" > - > # -JCryptoPkg/Include : To disable the use of the system includes prov= ided by > RVCT > # --diag_remark=3D1 : Reduce severity of "#1-D: last line of file = ends without a > newline" > RVCT:*_*_ARM_CC_FLAGS =3D -JCryptoPkg/Include --diag_remark=3D1 > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > index 4829669c1f3f..c34699cd62bf 100644 > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > @@ -100,5 +100,4 @@ [BuildOptions] > # > MSFT:*_*_*_CC_FLAGS =3D /wd4090 >=20 > - GCC:*_GCC44_IA32_CC_FLAGS =3D "-D__cdecl=3D__attribute__((cdecl))" "- > D__declspec(t)=3D__attribute__((t))" > XCODE:*_*_*_CC_FLAGS =3D -mmmx -msse > -- > 2.19.1.3.g30247aa5d201 >=20