From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 69B602118FF2F for ; Tue, 8 Jan 2019 16:51:03 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2019 16:51:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,455,1539673200"; d="scan'208";a="308736199" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 08 Jan 2019 16:51:02 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 8 Jan 2019 16:51:02 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 8 Jan 2019 16:51:01 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.239]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.196]) with mapi id 14.03.0415.000; Wed, 9 Jan 2019 08:50:59 +0800 From: "Wang, Jian J" To: "Carsey, Jaben" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib Thread-Index: AQHUp51F7teHNPdST02XOESDXnMKHaWmG37w Date: Wed, 9 Jan 2019 00:50:58 +0000 Message-ID: References: <59678190473f66f8a44d5be7ff416275c365342c.1546984652.git.jaben.carsey@intel.com> In-Reply-To: <59678190473f66f8a44d5be7ff416275c365342c.1546984652.git.jaben.carsey@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjMyZTE0NWUtMDA0ZS00Y2ExLTg4NTctODgxYjZiM2FkNDA0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoic0ZNREhRRElLd0IxMWdLdTUrajlmaytOdXVnaTcwaFJmNlloejZFUmE0cjFGMVdUU2JuS1dsbldHVm50UUNyaCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 00:51:03 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jian J Wang > -----Original Message----- > From: Carsey, Jaben > Sent: Wednesday, January 09, 2019 5:58 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Wang, Jian J > Subject: [Patch v1 1/1] MdeModulePkg: fix comments in BaseSortLib >=20 > The comments are incorrect for the base version of this lib. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jaben Carsey > Cc: Star Zeng > Cc: Jian J Wang > --- > MdeModulePkg/Library/BaseSortLib/BaseSortLib.c | 22 ++++++++------------ > 1 file changed, 9 insertions(+), 13 deletions(-) >=20 > diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c > b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c > index ab8a60585ee2..8f30c00971eb 100644 > --- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c > +++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.c > @@ -1,7 +1,7 @@ > /** @file > Library used for sorting routines. >=20 > - Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved. > + Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved. > This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > which accompanies this distribution. The full text of the license may= be found > at > @@ -193,14 +193,12 @@ DevicePathCompare ( > } >=20 > /** > - Function to compare 2 strings without regard to case of the characters= . > + Not supported in Base version. >=20 > - @param[in] Buffer1 Pointer to String to compare. > - @param[in] Buffer2 Pointer to second String to compare. > + @param[in] Buffer1 Ignored. > + @param[in] Buffer2 Ignored. >=20 > - @retval 0 Buffer1 equal to Buffer2. > - @return < 0 Buffer1 is less than Buffer2. > - @return > 0 Buffer1 is greater than Buffer2. > + ASSERT and return 0. > **/ > INTN > EFIAPI > @@ -215,14 +213,12 @@ StringNoCaseCompare ( >=20 >=20 > /** > - Function to compare 2 strings. > + Not supported in Base version. >=20 > - @param[in] Buffer1 Pointer to String to compare (CHAR16**). > - @param[in] Buffer2 Pointer to second String to compare (CHA= R16**). > + @param[in] Buffer1 Ignored. > + @param[in] Buffer2 Ignored. >=20 > - @retval 0 Buffer1 equal to Buffer2. > - @return < 0 Buffer1 is less than Buffer2. > - @return > 0 Buffer1 is greater than Buffer2. > + ASSERT and return 0. > **/ > INTN > EFIAPI > -- > 2.16.2.windows.1