From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=jian.j.wang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C3193211B85F8 for ; Thu, 17 Jan 2019 23:08:59 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2019 23:08:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,489,1539673200"; d="scan'208";a="119456534" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 17 Jan 2019 23:08:58 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 17 Jan 2019 23:08:58 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 17 Jan 2019 23:08:58 -0800 Received: from shsmsx107.ccr.corp.intel.com ([169.254.9.239]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.85]) with mapi id 14.03.0415.000; Fri, 18 Jan 2019 15:06:38 +0800 From: "Wang, Jian J" To: Ard Biesheuvel , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Gao, Liming" , "Ye, Ting" , "Wei, Gang" , "Zhang, Chao B" , "Yao, Jiewen" , "Wu, Hao A" , "Zeng, Star" , Achin Gupta , Jagadeesh Ujja Thread-Topic: [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules Thread-Index: AQHUreGgJoVbY5PVoEuNdPQEpb6oi6W0nOLA Date: Fri, 18 Jan 2019 07:06:36 +0000 Message-ID: References: <20190116212221.7460-1-ard.biesheuvel@linaro.org> <20190116212221.7460-4-ard.biesheuvel@linaro.org> In-Reply-To: <20190116212221.7460-4-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGFkZGMwNTAtZjVmMS00MzEwLThmYjItNTJjNzNiMmJjMjhiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoib3lncWtjdHpEZTFMVU9xZEJIYlwva1wvS2I1cnhvXC9SbWJaT2I1dU1RNGpsRjQ2UEtHR2RPeURQK2gyeVVCWnYxMyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2019 07:09:00 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jian J Wang > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Thursday, January 17, 2019 5:22 AM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel ; Kinney, Michael D > ; Gao, Liming ; Ye, Tin= g > ; Wei, Gang ; Wang, Jian J > ; Zhang, Chao B ; Yao, > Jiewen ; Wu, Hao A ; Zeng, Star > ; Achin Gupta ; Jagadeesh Ujja > > Subject: [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by > MM_STANDALONE modules >=20 > Permit VarCheckLib and VarCheckUefiLib to be used by MM_STANDALONE > modules. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf | 4 ++-- > MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c | 9 > +++++---- > 2 files changed, 7 insertions(+), 6 deletions(-) >=20 > diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > index 128c44d695e1..8873fd51a02a 100644 > --- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > +++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > @@ -19,9 +19,9 @@ [Defines] > BASE_NAME =3D VarCheckUefiLib > MODULE_UNI_FILE =3D VarCheckUefiLib.uni > FILE_GUID =3D AC24A4C7-F845-4665-90E5-6431D6E28DC= 0 > - MODULE_TYPE =3D DXE_RUNTIME_DRIVER > + MODULE_TYPE =3D BASE > VERSION_STRING =3D 1.0 > - LIBRARY_CLASS =3D NULL|DXE_RUNTIME_DRIVER DXE_SMM_DRI= VER > + LIBRARY_CLASS =3D NULL|DXE_RUNTIME_DRIVER DXE_SMM_DRI= VER > MM_STANDALONE > CONSTRUCTOR =3D VarCheckUefiLibNullClassConstructor >=20 > # > diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClas= s.c > b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c > index 80dc6341adcf..5e419831e8cc 100644 > --- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c > +++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c > @@ -12,6 +12,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY > KIND, EITHER EXPRESS OR IMPLIED. >=20 > **/ >=20 > +#include > + > #include > #include > #include > @@ -927,15 +929,14 @@ VariablePropertySetUefiDefined ( > @retval EFI_SUCCESS The constructor executed correctly. >=20 > **/ > -EFI_STATUS > +RETURN_STATUS > EFIAPI > VarCheckUefiLibNullClassConstructor ( > - IN EFI_HANDLE ImageHandle, > - IN EFI_SYSTEM_TABLE *SystemTable > + VOID > ) > { > VariablePropertySetUefiDefined (); > VarCheckLibRegisterSetVariableCheckHandler > (SetVariableCheckHandlerUefiDefined); >=20 > - return EFI_SUCCESS; > + return RETURN_SUCCESS; > } > -- > 2.17.1